Re: [PATCH v2] zsmalloc: prefer the the original page's node for compressed data

Dan Williams
2025-04-02T23:22:44Z

Nhat Pham wrote:
> On Wed, Apr 2, 2025 at 2:41 PM Dan Williams <dan.j.williams@intel.com> wrote>
> >
> > Why do the work to pass in @nid only to hardcode 0 to
> > alloc_pages_node()?
>
> That 0 is the order, i.e we want a single page here :)
>
> The node id is the first argument of alloc_pages_node. I made the same
> mistake in one of the earlier versions of this patch series (which,
> fortunately I did not send out) - hopefully this time I'm correct :)

Oops, sorry for the noise. My eyes were so trained on @nid as the final
argument in all the other conversions that I overlooked that.

You can add:

Acked-by: Dan Williams <dan.j.williams@intel.com>