From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6D8A02232B; Sun, 14 Apr 2024 14:13:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713104009; cv=none; b=sH7e/ZmvO81k4291BnEpFdhUDV5wbW54QotA0aNKHFjPBqZSjnX4g3nu5Q+BP+VlJyygmA2kkhAF3KVTsJbcV64CUpol9UlMArByXekEmgdxxVcyNoC5p9n8FarvH76myVwlioIGL2OFwM8QQ1L7HcfeRZlOPZC9Q0MzGwNp/Mk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713104009; c=relaxed/simple; bh=vVSKlyA+67Dp+p6DZueNAg9OF64+thIvRjbveFftyBQ=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=WYWkHwYXH/SsBUqWwfrffEIc8CwsBFPGKQFvvvifDLT18YsyUmUmNiV7bKY7FFptABOWsDnynzjPNgto0C440DEKVuPBDNACX+zIz7L2FnhhaI352SamnRCp7ULVTwEvAFQqYHX4BzEtUl+eKvEvuFJrLE1AP1v2OefNXueLnkI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=o9DPKYlE; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="o9DPKYlE" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6B36FC072AA; Sun, 14 Apr 2024 14:13:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1713104008; bh=vVSKlyA+67Dp+p6DZueNAg9OF64+thIvRjbveFftyBQ=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=o9DPKYlErsti9IGFIs8rqIrycL+KVcvJcS8gFZeiO6KFN5LQ4J1vPR9VcEsK5uLGS lorzHgxhbplhR3Cp/JB6SPwaqnKIdtpUX05zODg4bUhohT/rVk/PejQXztvu1M4h7w I6ZHzIRWCCEuCH/CvGkr5Yi/AlWdqbc5ccjpB5aIpq2io1iTmjTIFjWHgRQCY9MKTy OWdg82NLrqc8R9unYftuGHrZYcAsbNZeoGTNdF59xxpVqBBLXGeRHWeX31i4dXN11T vQ1dH0aydBTTiUwfWrLvI7v6eSabW5zKxeInz/epyCAWNQBcbjVn5Rh/fiqS+loa+2 Lr0u0peduSgGQ== Message-ID: Date: Sun, 14 Apr 2024 16:13:21 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 3/4] ARM: dts: BCM5301X: Add DT for ASUS RT-AC3200 To: arinc.unal@arinc9.com, Rob Herring , Krzysztof Kozlowski , Conor Dooley , Florian Fainelli , Hauke Mehrtens , Rafal Milecki , Florian Fainelli , Broadcom internal kernel review list Cc: Tom Brautaset , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org References: <20240414-for-soc-asus-rt-ac3200-ac5300-v1-0-118c90bae6e5@arinc9.com> <20240414-for-soc-asus-rt-ac3200-ac5300-v1-3-118c90bae6e5@arinc9.com> Content-Language: en-US From: Krzysztof Kozlowski Autocrypt: addr=krzk@kernel.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzSVLcnp5c3p0b2Yg S296bG93c2tpIDxrcnprQGtlcm5lbC5vcmc+wsGVBBMBCgA/AhsDBgsJCAcDAgYVCAIJCgsE FgIDAQIeAQIXgBYhBJvQfg4MUfjVlne3VBuTQ307QWKbBQJgPO8PBQkUX63hAAoJEBuTQ307 QWKbBn8P+QFxwl7pDsAKR1InemMAmuykCHl+XgC0LDqrsWhAH5TYeTVXGSyDsuZjHvj+FRP+ gZaEIYSw2Yf0e91U9HXo3RYhEwSmxUQ4Fjhc9qAwGKVPQf6YuQ5yy6pzI8brcKmHHOGrB3tP /MODPt81M1zpograAC2WTDzkICfHKj8LpXp45PylD99J9q0Y+gb04CG5/wXs+1hJy/dz0tYy iua4nCuSRbxnSHKBS5vvjosWWjWQXsRKd+zzXp6kfRHHpzJkhRwF6ArXi4XnQ+REnoTfM5Fk VmVmSQ3yFKKePEzoIriT1b2sXO0g5QXOAvFqB65LZjXG9jGJoVG6ZJrUV1MVK8vamKoVbUEe 0NlLl/tX96HLowHHoKhxEsbFzGzKiFLh7hyboTpy2whdonkDxpnv/H8wE9M3VW/fPgnL2nPe xaBLqyHxy9hA9JrZvxg3IQ61x7rtBWBUQPmEaK0azW+l3ysiNpBhISkZrsW3ZUdknWu87nh6 eTB7mR7xBcVxnomxWwJI4B0wuMwCPdgbV6YDUKCuSgRMUEiVry10xd9KLypR9Vfyn1AhROrq AubRPVeJBf9zR5UW1trJNfwVt3XmbHX50HCcHdEdCKiT9O+FiEcahIaWh9lihvO0ci0TtVGZ MCEtaCE80Q3Ma9RdHYB3uVF930jwquplFLNF+IBCn5JRzsFNBFVDXDQBEADNkrQYSREUL4D3 Gws46JEoZ9HEQOKtkrwjrzlw/tCmqVzERRPvz2Xg8n7+HRCrgqnodIYoUh5WsU84N03KlLue MNsWLJBvBaubYN4JuJIdRr4dS4oyF1/fQAQPHh8Thpiz0SAZFx6iWKB7Qrz3OrGCjTPcW6ei OMheesVS5hxietSmlin+SilmIAPZHx7n242u6kdHOh+/SyLImKn/dh9RzatVpUKbv34eP1wA GldWsRxbf3WP9pFNObSzI/Bo3kA89Xx2rO2roC+Gq4LeHvo7ptzcLcrqaHUAcZ3CgFG88CnA 6z6lBZn0WyewEcPOPdcUB2Q7D/NiUY+HDiV99rAYPJztjeTrBSTnHeSBPb+qn5ZZGQwIdUW9 YegxWKvXXHTwB5eMzo/RB6vffwqcnHDoe0q7VgzRRZJwpi6aMIXLfeWZ5Wrwaw2zldFuO4Dt 91pFzBSOIpeMtfgb/Pfe/a1WJ/GgaIRIBE+NUqckM+3zJHGmVPqJP/h2Iwv6nw8U+7Yyl6gU BLHFTg2hYnLFJI4Xjg+AX1hHFVKmvl3VBHIsBv0oDcsQWXqY+NaFahT0lRPjYtrTa1v3tem/ JoFzZ4B0p27K+qQCF2R96hVvuEyjzBmdq2esyE6zIqftdo4MOJho8uctOiWbwNNq2U9pPWmu 4vXVFBYIGmpyNPYzRm0QPwARAQABwsF8BBgBCgAmAhsMFiEEm9B+DgxR+NWWd7dUG5NDfTtB YpsFAmA872oFCRRflLYACgkQG5NDfTtBYpvScw/9GrqBrVLuJoJ52qBBKUBDo4E+5fU1bjt0 Gv0nh/hNJuecuRY6aemU6HOPNc2t8QHMSvwbSF+Vp9ZkOvrM36yUOufctoqON+wXrliEY0J4 ksR89ZILRRAold9Mh0YDqEJc1HmuxYLJ7lnbLYH1oui8bLbMBM8S2Uo9RKqV2GROLi44enVt vdrDvo+CxKj2K+d4cleCNiz5qbTxPUW/cgkwG0lJc4I4sso7l4XMDKn95c7JtNsuzqKvhEVS oic5by3fbUnuI0cemeizF4QdtX2uQxrP7RwHFBd+YUia7zCcz0//rv6FZmAxWZGy5arNl6Vm lQqNo7/Poh8WWfRS+xegBxc6hBXahpyUKphAKYkah+m+I0QToCfnGKnPqyYIMDEHCS/RfqA5 t8F+O56+oyLBAeWX7XcmyM6TGeVfb+OZVMJnZzK0s2VYAuI0Rl87FBFYgULdgqKV7R7WHzwD uZwJCLykjad45hsWcOGk3OcaAGQS6NDlfhM6O9aYNwGL6tGt/6BkRikNOs7VDEa4/HlbaSJo 7FgndGw1kWmkeL6oQh7wBvYll2buKod4qYntmNKEicoHGU+x91Gcan8mCoqhJkbqrL7+nXG2 5Q/GS5M9RFWS+nYyJh+c3OcfKqVcZQNANItt7+ULzdNJuhvTRRdC3g9hmCEuNSr+CLMdnRBY fv0= In-Reply-To: <20240414-for-soc-asus-rt-ac3200-ac5300-v1-3-118c90bae6e5@arinc9.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit On 14/04/2024 13:46, Arınç ÜNAL via B4 Relay wrote: > From: Arınç ÜNAL > > Add the device tree for ASUS RT-AC3200 which is an AC3200 router featuring > 5 Ethernet ports over the integrated Broadcom switch. > > Hardware info: > * Processor: Broadcom BCM4709A0 dual-core @ 1.0 GHz > * Switch: BCM53012 in BCM4709A0 > * DDR3 RAM: 256 MB > * Flash: 128 MB > * 2.4GHz: BCM43602 3x3 single chip 802.11b/g/n SoC > * 5GHz: BCM43602 3x3 two chips 802.11a/n/ac SoC > * Ports: 4 LAN Ports, 1 WAN Port > > Co-developed-by: Tom Brautaset > Signed-off-by: Tom Brautaset > Signed-off-by: Arınç ÜNAL > --- > arch/arm/boot/dts/broadcom/Makefile | 1 + > .../boot/dts/broadcom/bcm4709-asus-rt-ac3200.dts | 164 +++++++++++++++++++++ > 2 files changed, 165 insertions(+) > > diff --git a/arch/arm/boot/dts/broadcom/Makefile b/arch/arm/boot/dts/broadcom/Makefile > index 7099d9560033..c61fca514775 100644 > --- a/arch/arm/boot/dts/broadcom/Makefile > +++ b/arch/arm/boot/dts/broadcom/Makefile > @@ -64,6 +64,7 @@ dtb-$(CONFIG_ARCH_BCM_5301X) += \ > bcm47081-luxul-xap-1410.dtb \ > bcm47081-luxul-xwr-1200.dtb \ > bcm47081-tplink-archer-c5-v2.dtb \ > + bcm4709-asus-rt-ac3200.dtb \ > bcm4709-asus-rt-ac87u.dtb \ > bcm4709-buffalo-wxr-1900dhp.dtb \ > bcm4709-linksys-ea9200.dtb \ > diff --git a/arch/arm/boot/dts/broadcom/bcm4709-asus-rt-ac3200.dts b/arch/arm/boot/dts/broadcom/bcm4709-asus-rt-ac3200.dts > new file mode 100644 > index 000000000000..8640dda211ae > --- /dev/null > +++ b/arch/arm/boot/dts/broadcom/bcm4709-asus-rt-ac3200.dts > @@ -0,0 +1,164 @@ > +// SPDX-License-Identifier: GPL-2.0-or-later OR MIT > +/* > + * Author: Tom Brautaset > + */ > + > +/dts-v1/; > + > +#include "bcm4709.dtsi" > +#include "bcm5301x-nand-cs0-bch8.dtsi" > + > +#include > + > +/ { > + compatible = "asus,rt-ac3200", "brcm,bcm4709", "brcm,bcm4708"; > + model = "ASUS RT-AC3200"; > + > + chosen { > + bootargs = "console=ttyS0,115200 earlycon"; 1. Use stdout. 2. Drop earlycon, it is for debugging, not regular mainline usage. > + }; > + > + memory@0 { > + device_type = "memory"; > + reg = <0x00000000 0x08000000>, > + <0x88000000 0x08000000>; > + }; > + > + nvram@1c080000 { > + compatible = "brcm,nvram"; > + reg = <0x1c080000 0x00180000>; Why is this outside of soc? Both soc node and soc DTSI? Best regards, Krzysztof