From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f179.google.com (mail-pf1-f179.google.com [209.85.210.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A8236632 for ; Thu, 7 May 2026 00:02:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.179 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778112152; cv=none; b=RD5kSGgplv1Ao7shIEbmU7eBzfVY695tjQDNr1p/OPh9ODKYyGczHUB8VTwub/2hm9WY+ZOYY3HRGU7Q6IxaU05jWgBT9XGJ9O/TsHzAUN/ewzCQZAolAjjpecDqAb1XiJWF7A88gCcHJH2Fgi0MJyj1353NMcDEkNVMaQU6q9U= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778112152; c=relaxed/simple; bh=RIL+uKE+JKvB9b/wIGnLk/iWkr3FY/lrO2LwsKtCOvE=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=BYDLxeCSFmi1Mvc+3JsW6o4xpXm5W86t1cufhNQCOPX1zlnFxk6QpAp2B0q24QVY4Px0aFcfDaPv/JovE/Uf2UO2ZyBGvgC8tUu0UqTXtJzqrGA4nmrSOiufRb3dsTPprRy5YFXHZ+NCLOK+JV/BvINBsuavITsVtOH9jj4wY60= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=QPj5EecP; arc=none smtp.client-ip=209.85.210.179 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="QPj5EecP" Received: by mail-pf1-f179.google.com with SMTP id d2e1a72fcca58-8353ca0f1f1so94297b3a.1 for ; Wed, 06 May 2026 17:02:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1778112151; x=1778716951; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=tw88zLW0m82aJmzaLGMGmwWBNKAe++QmUNLT/L5tpB8=; b=QPj5EecPShsdjiiz1CWEOS6NH+rN2SYqe9PJjDV+tiMiqrofdYssVsmzj+VyuFX/Iy UmaNYsw5bbPyU5v35BIkUahf9IkblsnJFBNAU3oR42rZ8ngpkInBVW/GYMZYminflwDV H5dH9A5H6NiB9RiwYWEl4Q3yZmhpTs4sQtbdn2Z6uQ+voRUB598KFRWLF93xW0Zz5Eul 4eHWLNbEWAdaeHvv2+u1bHNm45aM/3T91wc+0AGQ/JRzltb7QCG/MTCW7A+fsMakzIF7 gQNpuynzPbm11fP8wy2a9Mt8UIJps8AAq40tSZokBpdpnV8KIMSBErr2Oet8lniBTLGh 2uPA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778112151; x=1778716951; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=tw88zLW0m82aJmzaLGMGmwWBNKAe++QmUNLT/L5tpB8=; b=K+igWkKoY/jHcQMy6Q7xmoYO1ZIZZoYZ/s5PaVbKYU+FZZWaKoFZ5frN21WxHe6O1U IzPaV4ADm3NFHEz52r6F/euj409ObBKrUeaT+8sPV/7Sygw1ESeFfkG5nClF8cUA2Eem w5NJLQQ0oOSXvmvOpYCJiqpOXtxddp6GsJSXBs0EtN1SbS21R/ST9Lea+sUaWOtZLOIa 11AaWAGlVbk7zNh2Rn+yyb2QxKZcuWqgmyj1NOYo3xP1wjNIbvr3VkAsRyt04AiEZtwz Dw0hFJ3eHJr+WTKz8Up415KSdJ+Mg4jIJMuRFUhY4e9RsEyQWHsj3iZF/SfFtR3DD2U/ qSkg== X-Forwarded-Encrypted: i=1; AFNElJ8cgxnbvv968ql7yjhdzwh0rboYNihVMvNUzRU9cbOMCpJgtc35/0UwhJ5LKeJ8tpLtZ8ZD0RloHM6NO6s=@vger.kernel.org X-Gm-Message-State: AOJu0Yz8YMBAgG0Cvyoy/Nj/0Y9+kX93QL1AIBvQulvK6MBmoOQUvQah cse/7XbqpwSV53vg/6K0+v3FmctB8Ii4TlLHAWDO3V2g0xWNBMUBMz6u X-Gm-Gg: AeBDieupkN0bzzJD12KczSE1QGTPAVG0BgFtq3JUbSOAz7TFh8O2WK6m8iNgtMwcf82 rhikmvnHLHUFmJov3nwN+XyWzqrV3bc+w0zsvKwCalzQYiFOLsR0WPmAAi07Ns48uoADnAyk+Ht O6GG6NKGPQzav3rX/KfJ1IxfCX3KGXH5Yv+zTqje76TGx2y6k7CXohmwfN05M1UgCwgSdRkxFHc LE3k/YhsIL9e+Ga/exbmWW1PXFm6Aeq7/jSgydpwVIRJcjd+rxFs7wXumL3NAKFIDfvYy6Bg6ER Ub7PmDd8sHqMguxdpFETOaWgDswc1jwv39jkZsYTZ/d0aKqRurzNojYvadbBrZgZe//ytDdt8Fn BgDnNyYL0LqpqZeO3vXPO+KN/+A7Olch+htBR1MeJac1XYUksLKwX3GIVi+l+Zg4Nfg+sfx7dNq jA+w5gPMvKt0GnSFql5o3KVW/LJB6a8ZRSJhNr/F38aA3hQypd2pvh1f2hZYDwVWsz8enVOVVZh lJinPc= X-Received: by 2002:a05:6a00:124b:b0:835:35c0:dff3 with SMTP id d2e1a72fcca58-83bb86930f8mr486947b3a.26.1778112150891; Wed, 06 May 2026 17:02:30 -0700 (PDT) Received: from ?IPV6:2402:f000:3:1001:8803:d9da:dac1:4a73? ([2402:f000:3:1001:8803:d9da:dac1:4a73]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-8396563f03bsm6748603b3a.9.2026.05.06.17.02.29 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 06 May 2026 17:02:30 -0700 (PDT) Message-ID: Date: Thu, 7 May 2026 08:02:27 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 1/3] tools: gpio: use strscpy() for consumer name To: David Laight Cc: linux-gpio@vger.kernel.org, brgl@kernel.org, warthog618@gmail.com, linux-kernel@vger.kernel.org References: <20260503190016.13439-1-zxl434815272@gmail.com> <20260504075036.12190-1-zxl434815272@gmail.com> <20260504134532.0438e390@pumpkin> Content-Language: en-US From: 007 In-Reply-To: <20260504134532.0438e390@pumpkin> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit OK, I will check it next time, thanks for the reminder. Best regards Zhang Xiaolei On 5/4/26 20:45, David Laight wrote: > On Mon, 4 May 2026 15:50:34 +0800 > Zhang Xiaolei wrote: > >> Replace strcpy() with strscpy() to avoid potential buffer overflow >> when copying the consumer string. > You ought to run code before submitting patches. > This wasn't even compiled. > > -- David > >> Signed-off-by: Zhang Xiaolei >> --- >> tools/gpio/gpio-utils.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/tools/gpio/gpio-utils.c b/tools/gpio/gpio-utils.c >> index 4096bcd511d1..176bccfcccb0 100644 >> --- a/tools/gpio/gpio-utils.c >> +++ b/tools/gpio/gpio-utils.c >> @@ -82,7 +82,7 @@ int gpiotools_request_line(const char *device_name, unsigned int *lines, >> req.offsets[i] = lines[i]; >> >> req.config = *config; >> - strcpy(req.consumer, consumer); >> + strcpy(req.consumer, consumer, sizeof(req.consumer)); >> req.num_lines = num_lines; >> >> ret = ioctl(fd, GPIO_V2_GET_LINE_IOCTL, &req);