Re: [RFC PATCH 12/16] arm64: mm: Map p4d/pgd with privileged pkey

Peter Zijlstra
2024-12-09T10:24:45Z

On Fri, Dec 06, 2024 at 10:11:06AM +0000, Kevin Brodsky wrote:
> If CONFIG_KPKEYS_HARDENED_PGTABLES is enabled, map p4d/pgd pages
> using a privileged pkey (KPKEYS_PKEY_PGTABLES), so that they can
> only be written under guard(kpkeys_hardened_pgtables).
>
> The case where pgd is not page-sized is not currently handled -
> this is pending support for pkeys in kmem_cache.
>
> This patch is a no-op if CONFIG_KPKEYS_HARDENED_PGTABLES is disabled
> (default).

Should not this live in pagetable_*_[cd]tor() in generic code?