From: Krzysztof Kozlowski <krzk@kernel.org>
To: dimitri.fedrau@liebherr.com, Vinod Koul <vkoul@kernel.org>,
Kishon Vijay Abraham I <kishon@kernel.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>
Cc: linux-phy@lists.infradead.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
Dimitri Fedrau <dima.fedrau@gmail.com>,
Marc Kleine-Budde <mkl@pengutronix.de>,
linux-can@vger.kernel.org
Subject: Re: [PATCH v2 1/2] dt-bindings: phy: add support for NXPs TJA1145 CAN transceiver
Date: Fri, 29 Aug 2025 16:21:11 +0200 [thread overview]
Message-ID: <a91b8fba-8d26-441e-9da6-86e302703abc@kernel.org> (raw)
In-Reply-To: <bf925270-5410-407c-a4e0-472a427e6ef6@kernel.org>
On 29/08/2025 15:12, Krzysztof Kozlowski wrote:
> On 29/08/2025 11:19, Dimitri Fedrau via B4 Relay wrote:
>> From: Dimitri Fedrau <dimitri.fedrau@liebherr.com>
>>
>> Adding documentation for NXPs TJA1145 CAN transceiver.
>
> Pity you did not include resolution of discussions about directory and
> can phy bindings here. You have entire commit msg for that, but instead
> it is a copy paste of subject.
>
>>
>> Signed-off-by: Dimitri Fedrau <dimitri.fedrau@liebherr.com>
>> ---
>> .../devicetree/bindings/phy/nxp,tja1145-can.yaml | 79 ++++++++++++++++++++++
>> 1 file changed, 79 insertions(+)
>
>>
>
>
> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
And un-reviewed, I missed messed example and this was never tested.
Sending untested code only makes us grumpy.
Best regards,
Krzysztof
next prev parent reply other threads:[~2025-08-29 14:21 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-29 9:19 [PATCH v2 0/2] phy: add basic support for NXPs TJA1145 CAN transceiver Dimitri Fedrau via B4 Relay
2025-08-29 9:19 ` [PATCH v2 1/2] dt-bindings: phy: add " Dimitri Fedrau via B4 Relay
2025-08-29 13:12 ` Krzysztof Kozlowski
2025-08-29 14:21 ` Krzysztof Kozlowski [this message]
2025-08-29 13:50 ` Rob Herring (Arm)
2025-08-29 9:19 ` [PATCH v2 2/2] phy: add basic " Dimitri Fedrau via B4 Relay
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a91b8fba-8d26-441e-9da6-86e302703abc@kernel.org \
--to=krzk@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dima.fedrau@gmail.com \
--cc=dimitri.fedrau@liebherr.com \
--cc=kishon@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-can@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-phy@lists.infradead.org \
--cc=mkl@pengutronix.de \
--cc=robh@kernel.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).