Re: [PATCH] media: venus: add support for selection rectangles

Stanimir Varbanov
2018-11-01T15:02:14Z

Hi Malathi,

On 11/1/18 3:10 PM, mgottam@codeaurora.org wrote:
> On 2018-10-16 15:11, Stanimir Varbanov wrote:
>> Hi Malathi,
>>
>> On 10/09/2018 10:53 AM, Malathi Gottam wrote:
>>> Handles target type crop by setting the new active rectangle
>>> to hardware. The new rectangle should be within YUV size.
>>>
>>> Signed-off-by: Malathi Gottam <mgottam@codeaurora.org>
>>> ---
>>>  drivers/media/platform/qcom/venus/venc.c | 19 +++++++++++++++++--
>>>  1 file changed, 17 insertions(+), 2 deletions(-)
>>>
>>> diff --git a/drivers/media/platform/qcom/venus/venc.c
>>> b/drivers/media/platform/qcom/venus/venc.c
>>> index 3f50cd0..754c19a 100644
>>> --- a/drivers/media/platform/qcom/venus/venc.c
>>> +++ b/drivers/media/platform/qcom/venus/venc.c
>>> @@ -478,16 +478,31 @@ static int venc_g_fmt(struct file *file, void
>>> *fh, struct v4l2_format *f)
>>>  venc_s_selection(struct file *file, void *fh, struct v4l2_selection *s)
>>>  {
>>>      struct venus_inst *inst = to_inst(file);
>>> +    int ret;
>>> +    u32 buftype;
>>>
>>>      if (s->type != V4L2_BUF_TYPE_VIDEO_OUTPUT)
>>>          return -EINVAL;
>>>
>>>      switch (s->target) {
>>>      case V4L2_SEL_TGT_CROP:
>>> -        if (s->r.width != inst->out_width ||
>>> -            s->r.height != inst->out_height ||
>>> +        if (s->r.width > inst->out_width ||
>>> +            s->r.height > inst->out_height ||
>>>              s->r.top != 0 || s->r.left != 0)
>>>              return -EINVAL;
>>> +        if (s->r.width != inst->width ||
>>> +            s->r.height != inst->height) {
>>> +            buftype = HFI_BUFFER_OUTPUT;
>>> +            ret = venus_helper_set_output_resolution(inst,
>>> +                                 s->r.width,
>>> +                                 s->r.height,
>>> +                                 buftype);
>>
>> I'm afraid that set_output_resolution cannot be called at any time. Do
>> you think we can set it after start_session?
>
> Yes Stan, we can set output_resolution after the session has been
> initialization.
> As per the spec, this call s_selection is an optional step under
> Initialization
> procedure of encoder even before we request buffers.

What spec you are referring to? The spec for the encoders [1] or
something else.

>
> So I think setting output resolution in this api shouldn't cause any
> issue once
> we are confident on the instance state.

OK, but I want to test that on v1 and v3 as well (usually the behavior
differs between versions).

--
regards,
Stan

[1] https://patchwork.linuxtv.org/patch/52624/