From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ot1-f48.google.com (mail-ot1-f48.google.com [209.85.210.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3D5EC2356C7 for ; Sat, 30 Aug 2025 16:41:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.48 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756572091; cv=none; b=abOXNeOwapQiCoy28aNYF/uALCLLDhhj+a0f2KecTDvd/OaMyvnjDIYvptKTCPMLBUx+JZALNrmwQu0a4qdhCw7w9zqBJB4t3FpSG/iM85U1g+ZMs4Dk6KOVoVEZ23/K4i0ms4PUe8GcH3hJNdh7OYXT2kmKoOZCw08kZM4vU5w= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756572091; c=relaxed/simple; bh=9pLVtHagF9RfuVvLL5VmokTfRtBhGQ67ZkM9NHr6/xM=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=iTh4mneciizprCvoeT/M3/Dn2/xtqIamm/7KwghNypbTflmtBdCobQIBgdt4r8Dmp5byQEZG1Dl3CuemOLqU9mJ/hQC6Ft9wVl23UbSJV3IdLzrAYyXRPb5V+nmRdy9oMu6uXvV29O2lO9Wr/HjNx2EG/tftY7ZkJEWE8Q/mHHY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=rApEJ9er; arc=none smtp.client-ip=209.85.210.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="rApEJ9er" Received: by mail-ot1-f48.google.com with SMTP id 46e09a7af769-74526ca7d64so2647113a34.2 for ; Sat, 30 Aug 2025 09:41:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1756572088; x=1757176888; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=sbfBohOE3aUAe+8ggIJdFs3Ub7xyIyjcAlkbS5chGaw=; b=rApEJ9erCEAhloV58ULbDH5EvvpeMmIdIkDlBfA9xitGgEExwtWbmQkz1RUdCcMAa+ MtiyC3tIRRdc6vXoHUu2B2b3v1Uel8VaZhy9UZX/Uah6P0EyiCU15AmxTH4j9D02KAR3 uCbIyFS0BGua5quv3PSXGEZmnnhJq4+rV4xkGO4lwLZV1x+4Nttni7NvjpCSyqUeoUMW ZtCG+WSiQzT4Az4QFJAA+stUYBZvp9m+roqig8mLZZgHi8WGydgHAq8NCj/DE3EEmy14 dlMiiSme7XxvU31PHkPQcRjmmOtH3Od5NAjxz4q5/Fiw3Sg7ezmKN2AuxWgiEFwOPbGs nJmA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1756572088; x=1757176888; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=sbfBohOE3aUAe+8ggIJdFs3Ub7xyIyjcAlkbS5chGaw=; b=nWlOzCbGZSlxlFpQ3RyxgUjcjNlPu+vUDLWBYn4Ck3QXUGV7rpgNbMeLNIRu9Thyet SCMik27g7Ka0dBwdgbN2+lXFwthFVQUG2p0eprhTyJ82ucwnccJqci/Irttag5X0d6UA czPQw3CQlwD0ttH2NJR9A85Ar7b/pxmJRJi7nZfV5aw0CVVfo3sQhV03hF28AwzgNQtE 2K+c3GjynmXbEYSHK9yKDxOIn5tCv1I1Z3Fh0YkpmBTJYbsVOGaBumcB7wXJzFxJuNhC 4Bz9nMOEc6257ehty6w91v5sT/Df5P5lQg8uC32bLy89Osxgi2RtNNAi05PJHvTV4bGn 81oQ== X-Forwarded-Encrypted: i=1; AJvYcCWujbRPV1Zoq75SnhUQwyPRUXV5Mas4C3iIjJ++LaB1AdprMMjNq+XIOuyarP9SPt1oNgsgzV7pyFD3JCM=@vger.kernel.org X-Gm-Message-State: AOJu0YwYG+xCfdKXS+VKZXwdPNdBQiRcKnV5eLGsdqUF+lbJtm5R+5UK TZtIhFqxZWNuHq+IeOd1LO8UkN6J1HvXvC9dxqHqmiBbLY5qwI9uILlPGzE5ZdAJz3E= X-Gm-Gg: ASbGncv+MLRVp9lMOYFogc4Rb4k0t7yR6/fi//d6Q7ODZSLxbtwCpaTBsgfb1d6c/Dk LcxXVJyQ3KRMTEg+MpK70lXhDFKr6ICSLhlcLf32xBxgsbLPv+y41XLmoj5H6w1u6MQqM6otbhU apGogHDqxg65Ts1mJgj6qkyysVlsBRSJfilgjtzYp5AqIQzrpuvxGO/rRhFqJU4WOurbg8DTP4A Fi6rp295e7mpphSnKzgLrcMPWeU0YSkfQASVDmdrNKeTZ4DbpzSN09CkZMHFznujEF1ctew/lgm 34ZLvczXAxTUChSMQ8lyZa/Eh/Cxl9YPxi2Z1/48Lu99L3NwBP4l3r1kdgzUq2bd2IhYjX/JSiq 78uUHwRoEtQUnA8cgfriWcP2YqrVG1hxGgcQwq3LHSIxfHNDlbmviiRaP5wKmeKlCtxwaEnjfkz 0= X-Google-Smtp-Source: AGHT+IEr7AQnCq5wkF/dg8M61n6r+AfW5NR3ZpEgSAUCmyBrqg6y3i+f1Si6RhVd/teU1v3mrKvqvQ== X-Received: by 2002:a05:6830:398b:b0:744:f08e:4d30 with SMTP id 46e09a7af769-74569f18c36mr1644826a34.35.1756572088242; Sat, 30 Aug 2025 09:41:28 -0700 (PDT) Received: from ?IPV6:2600:8803:e7e4:1d00:f7b4:dfbd:5110:c59d? ([2600:8803:e7e4:1d00:f7b4:dfbd:5110:c59d]) by smtp.gmail.com with ESMTPSA id 586e51a60fabf-3196d46d8a6sm345913fac.18.2025.08.30.09.41.26 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 30 Aug 2025 09:41:26 -0700 (PDT) Message-ID: Date: Sat, 30 Aug 2025 11:41:25 -0500 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 06/15] spi: spi-offload-trigger-pwm: Use duty offset To: Marcelo Schmitt , linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, devicetree@vger.kernel.org, linux-spi@vger.kernel.org, =?UTF-8?Q?Uwe_Kleine-K=C3=B6nig?= Cc: Axel Haslam , jic23@kernel.org, Michael.Hennerich@analog.com, nuno.sa@analog.com, eblanc@baylibre.com, andy@kernel.org, corbet@lwn.net, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, broonie@kernel.org, Jonathan.Cameron@huawei.com, andriy.shevchenko@linux.intel.com, marcelo.schmitt1@gmail.com References: <2410525339f56466fa566dda367678ec92f9fb98.1756511030.git.marcelo.schmitt@analog.com> Content-Language: en-US From: David Lechner In-Reply-To: <2410525339f56466fa566dda367678ec92f9fb98.1756511030.git.marcelo.schmitt@analog.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 8/29/25 7:42 PM, Marcelo Schmitt wrote: > From: Axel Haslam > > Pass the duty offset to the waveform pwm. > > Signed-off-by: Axel Haslam > Signed-off-by: Marcelo Schmitt > --- > drivers/spi/spi-offload-trigger-pwm.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/drivers/spi/spi-offload-trigger-pwm.c b/drivers/spi/spi-offload-trigger-pwm.c > index 805ed41560df..8413aeb3689d 100644 > --- a/drivers/spi/spi-offload-trigger-pwm.c > +++ b/drivers/spi/spi-offload-trigger-pwm.c > @@ -51,13 +51,13 @@ static int spi_offload_trigger_pwm_validate(struct spi_offload_trigger *trigger, > wf.period_length_ns = DIV_ROUND_UP_ULL(NSEC_PER_SEC, periodic->frequency_hz); > /* REVISIT: 50% duty-cycle for now - may add config parameter later */ > wf.duty_length_ns = wf.period_length_ns / 2; > - > + wf.duty_offset_ns = periodic->offset_ns; I would be tempted to put the loop check here: offload_offset_ns = periodic->offset_ns; do { wf.offset_ns = offload_offset_ns; ret = pwm_round_waveform_might_sleep(st->pwm, &wf); if (ret) return ret; offload_offset_ns += 10; } while (wf.offset_ns < periodic->offset_ns); wf.duty_offset_ns = periodic->offset_ns; instead of in the ADC driver so that all future callers don't have to repeat this. Also cc: Uwe in case he has any better suggestions on how to avoid repeating such verbose validations by all uses of the PWM waveform APIs. > ret = pwm_round_waveform_might_sleep(st->pwm, &wf); > if (ret < 0) > return ret; > > periodic->frequency_hz = DIV_ROUND_UP_ULL(NSEC_PER_SEC, wf.period_length_ns); > - > + periodic->offset_ns = wf.duty_offset_ns; > return 0; > } > > @@ -77,6 +77,7 @@ static int spi_offload_trigger_pwm_enable(struct spi_offload_trigger *trigger, > wf.period_length_ns = DIV_ROUND_UP_ULL(NSEC_PER_SEC, periodic->frequency_hz); > /* REVISIT: 50% duty-cycle for now - may add config parameter later */ > wf.duty_length_ns = wf.period_length_ns / 2; > + wf.duty_offset_ns = periodic->offset_ns; > > return pwm_set_waveform_might_sleep(st->pwm, &wf, false); > }