From: Krzysztof Kozlowski <krzk@kernel.org>
To: Mohammad Rafi Shaik <mohammad.rafi.shaik@oss.qualcomm.com>,
Srinivas Kandagatla <srini@kernel.org>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>
Cc: linux-arm-msm@vger.kernel.org, linux-sound@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel@oss.qualcomm.com, prasad.kumpatla@oss.qualcomm.com,
ajay.nandam@oss.qualcomm.com
Subject: Re: [PATCH v1 1/2] ASoC: dt-bindings: qcom,sm8250: Add QCS8300 sound card
Date: Wed, 10 Sep 2025 09:39:21 +0200 [thread overview]
Message-ID: <a9507045-b900-49ee-8841-0f8fd30816ba@kernel.org> (raw)
In-Reply-To: <43090acb-ea36-4015-b14f-78d44d789d42@kernel.org>
On 10/09/2025 09:26, Krzysztof Kozlowski wrote:
>> diff --git a/Documentation/devicetree/bindings/sound/qcom,sm8250.yaml b/Documentation/devicetree/bindings/sound/qcom,sm8250.yaml
>> index 8ac91625dce5..eebf80c1d79a 100644
>> --- a/Documentation/devicetree/bindings/sound/qcom,sm8250.yaml
>> +++ b/Documentation/devicetree/bindings/sound/qcom,sm8250.yaml
>> @@ -35,6 +35,7 @@ properties:
>> - qcom,qcm6490-idp-sndcard
>> - qcom,qcs6490-rb3gen2-sndcard
>> - qcom,qcs8275-sndcard
>
> So what is the point of this compatible? There is no user of it and I
> think you added QCS8275 for this case exactly...
>
> Shall I start reverting commits from Qualcomm because you post patches
> "just in case" and turns out they are completely not needed? No single
> user of such code?
@Mark,
In case it wasn't obvious, please do not merge the patch till we get
some clarification. For sure it is wrong one way or another: either
incomplete or just duplicated.
Best regards,
Krzysztof
next prev parent reply other threads:[~2025-09-10 7:39 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-05 14:26 [PATCH v1 0/2] Add sound card support for QCS8300 Mohammad Rafi Shaik
2025-09-05 14:26 ` [PATCH v1 1/2] ASoC: dt-bindings: qcom,sm8250: Add QCS8300 sound card Mohammad Rafi Shaik
2025-09-06 19:00 ` Rob Herring (Arm)
2025-09-10 7:26 ` Krzysztof Kozlowski
2025-09-10 7:39 ` Krzysztof Kozlowski [this message]
2025-09-10 8:05 ` Mohammad Rafi Shaik
2025-09-10 9:40 ` Mohammad Rafi Shaik
2025-09-10 9:43 ` Krzysztof Kozlowski
2025-09-10 10:20 ` Konrad Dybcio
2025-09-10 11:23 ` Krzysztof Kozlowski
2025-09-10 11:17 ` Mohammad Rafi Shaik
2025-09-10 11:24 ` Krzysztof Kozlowski
2025-09-12 7:38 ` Mohammad Rafi Shaik
2025-09-05 14:26 ` [PATCH v1 2/2] ASoC: qcom: sc8280xp: Add support for QCS8300 Mohammad Rafi Shaik
2025-09-08 7:43 ` Srinivas Kandagatla
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a9507045-b900-49ee-8841-0f8fd30816ba@kernel.org \
--to=krzk@kernel.org \
--cc=ajay.nandam@oss.qualcomm.com \
--cc=broonie@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=kernel@oss.qualcomm.com \
--cc=krzk+dt@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=mohammad.rafi.shaik@oss.qualcomm.com \
--cc=perex@perex.cz \
--cc=prasad.kumpatla@oss.qualcomm.com \
--cc=robh@kernel.org \
--cc=srini@kernel.org \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox