From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out-170.mta1.migadu.com (out-170.mta1.migadu.com [95.215.58.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 915B73B27F5 for ; Mon, 3 Aug 2026 08:29:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=95.215.58.170 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785745748; cv=none; b=Ugqi+pBaYPEWODC5RlNPCkfEqR1dr9Ri7GSn7x2Py41/5wh0mPQbiLtGW/okqg6IkvISFcz17XSi9iVWbECrj/CDZcf8LrA5LGRChh9PuJnWNOUpcRMmUoCY6jXhaUTOfEoHAV/Q8D8WgtR6XbXlH9hNiUiNw0kYbZcH9bV6Z1g= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785745748; c=relaxed/simple; bh=Z/y9bxtOoGbkfjhIV9x0o1TeX0FamxcMKPkwaKtP6zo=; h=MIME-Version:Date:Content-Type:From:Message-ID:Subject:To:Cc: In-Reply-To:References; b=l3Sd/FjZRg7W7m9pfub44WS/kUlgaYIQtux4OznjBdIjKT5qKfX4hPGPNMo4MBoygY/+Qs7FEtbBZxaxYaaJutjiWpyQczhmnhOjSj94EgOusppwc4JS1Z4KN3RPzYSPkIW94t8s9mcVTs7nXaQzkbLSEwH2nfp/j78QoXkfq20= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=p3lN4kSz; arc=none smtp.client-ip=95.215.58.170 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="p3lN4kSz" Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1785745743; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=yReSINz53RALtgsTLYaQBfhtA4c8gjFI8bbYPh7aZ+U=; b=p3lN4kSzvQB6qKNF0Nd+o94KqUgK78m0DcS2fKfjsbzeEE2TCKVFOi/tYOMoyirY/eAw+0 SYYCP7tdQqo+6Q2GSg1iRiWF2MfTu+o7EUpMnFP/WWD3ogEwdqHKju7hKxGAIvOdYVoHfA G8AtVnTZ0/RUbMkcadlL5W5aZl5Fp/w= Date: Mon, 03 Aug 2026 08:28:51 +0000 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: "Siratul Islam" Message-ID: TLS-Required: No Subject: Re: [PATCH v3 2/2] iio: dac: dac8163: Add driver for DAC8163 To: "David Lechner" , "Lukas Metz" , "Jonathan Cameron" , "=?utf-8?B?TnVubyBTw6E=?=" , "Andy Shevchenko" , "Rob Herring" , "Krzysztof Kozlowski" , "Conor Dooley" Cc: linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org, devicetree@vger.kernel.org In-Reply-To: <50fee508-db53-46c3-b245-22893023f370@baylibre.com> References: <20260802-dac8163-work-v3-0-3ecc7bc66d0d@gmx.net> <20260802-dac8163-work-v3-2-3ecc7bc66d0d@gmx.net> <50fee508-db53-46c3-b245-22893023f370@baylibre.com> X-Migadu-Flow: FLOW_OUT August 2, 2026 at 11:19 PM, "David Lechner" wrote= : >=20 >=20On 8/2/26 11:07 AM, Lukas Metz wrote: ... > > +#define LDAC_CHANNEL_A_MASK BIT(0) > > +#define LDAC_CHANNEL_B_MASK BIT(1) > > +#define VREF_MASK BIT(0) > > + > > +#define DAC8163_INTERNAL_REF_mV 2500 > > +#define DAC8163_RES_12_BIT 12 > > +#define DAC8163_RES_14_BIT 14 > > +#define DAC8163_RES_16_BIT 16 > >=20 >=20Macros that just map to a number that is part of the macro name > aren't that helpful. We can just use the number directly. >=20 Each=20of them repeats 4 times. I think typing a number that many times= =20 is=20more error prone than having a macro. > >=20 >=20> > -- Best regards, Sirat