From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f173.google.com (mail-pl1-f173.google.com [209.85.214.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8EDC528EB for ; Sat, 11 Jan 2025 02:07:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.173 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736561259; cv=none; b=UVUnIXxRczLcD62VGkq3ADXwYc9fIIKx5/rQWZb5n6LTVISYTIskZMWImhPuODUPqRnut/FSG4aE/ZyMC086OOmExkx1GuAeu3Ms2LYjGfxYxrmQ5YBtvLJ/jiRQUfFM+n9KOzU+a5+XgRn3BIP+2+RzsuNN3EOsvKMkS4uTz1A= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736561259; c=relaxed/simple; bh=z0lSMq435PRV35wN+xoniUhGv8RLCIPE5mELlbbXCvY=; h=Message-ID:Date:MIME-Version:To:Cc:References:Subject:From: In-Reply-To:Content-Type; b=BFy4NZ1NbxYITZ6HiE/DMyKAQmtZiw/nE0EbdTUCd/r13g3eGbkDRzLM/dXscDqksf2oIQfdf3eCVWhtsflUw6EQeZu+HY3Xkw4keOBro/2DxOTxZt2h2c9qnNU1MSxg4wdPWJglEjfG78l6gB2M3WhQ/5RpsXfD68BsYoGFW4Y= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=mJuFpa9u; arc=none smtp.client-ip=209.85.214.173 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="mJuFpa9u" Received: by mail-pl1-f173.google.com with SMTP id d9443c01a7336-2161eb94cceso32871245ad.2 for ; Fri, 10 Jan 2025 18:07:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1736561257; x=1737166057; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:subject:references:cc:to :user-agent:mime-version:date:message-id:from:to:cc:subject:date :message-id:reply-to; bh=seLrvPT9JjZWz6saRH0pd2cljURptYB7TR64wdQqsW4=; b=mJuFpa9uFXcdEGgc/KHt+/N0meO6+yJgr3a16JJJ1bCtgjRKDyxkG0oEVijGeDuQvs LaJlf8lUxmNOBYiGDZD3mrSSNuNq9wNHzqut0MhhAHQCuN/7XOclT7Wk+iGa3EJcTllG cFgJ7U3aAdD8keiZXb5k/y3P0hRpkE+sjo71gmdybLLqjg7Xqi80DXFmPJogAqIyQewV oZMbHkuT59kHgVpADMYttjAaypvXbKHT+SmD6RUyLaoHHc7+PkQmJf5iJ9V1sJOxaYdT eaG7fW8OMGUK7EQE6wQbwya7jjbj+9CHxRmigQuTr7XMkOsPhxZ9wazteyCM6T7Q6Qlm 7oYg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736561257; x=1737166057; h=content-transfer-encoding:in-reply-to:from:subject:references:cc:to :user-agent:mime-version:date:message-id:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=seLrvPT9JjZWz6saRH0pd2cljURptYB7TR64wdQqsW4=; b=sq4pS2gdEEqBmxLGpimEtai0Ov2Bj94mndikfkvsQHKhzK+CgX5yKFybIFMqBEFCKC AkFjZQ/M0EI5+OA+4KE55EYBJp6HFuygK7d/lk8pBO8ssMWBG8B70php3euAtuZcKLnx LC33vwejDVoBwvN/5/x+/X7DWvQYMC6PgFSSkB7D31jXrsL4No6VoCnYPr6xJlNb3l2o 4VJStb7Q06P6tyaFTEbAdQXHrH8oZraVO9CHTc3pytRBr1m8Yfbpp3HzbEofsZITTs02 t0n9W/bbU1ROp1lSq3e70DVC37U3Ub86cn/FZsogSNGnoEmb8XiWXRWaELq4dLXDxv41 Nmww== X-Forwarded-Encrypted: i=1; AJvYcCXPG3ONcmNukLUCOgM/FFA8HcezS2Kqd4kNKu+7UFLBboa3X3f0Fhk5y8y6kbcQveG7w5ci2lvRDTpbl08=@vger.kernel.org X-Gm-Message-State: AOJu0YzmeIrM0TrTWNJluEaQVieT6P+UPnnA3JafFrqJvQy098xnNoJL Ncm6mQwoAWyAGJ1qd+FOKWq610C4z0LwPDMLpf4g0poPU0KyGvf+ X-Gm-Gg: ASbGncu+5dnG8M76pRkeRQggi8dRscONHA1WOf0NniWs38NR6mdPm/ftAC883nr70O4 J67n8Ll475cXAxoKFzKx4ndaBGLY0ezr00ObaB9mHfE/wT5iUpcchpPAaF5gpcUNtpy3IYcHwnF sYDfs+WaqcSvNXXpPEmIrn/vIY0ZxPYMZAzEnRPK0WoYl/ArQsRsVtJtLEU1eJM+iXDY5sfmqI9 HZz9iD9plXM4s5PDRQDSI55hVM7ORDl63fiduA0W2GFB/GPYtFe2yakNDYVAiZhqY0hIFyrLniM M5xc/+MORNCCvSOoGyUZISVxzVczMai+r6o= X-Google-Smtp-Source: AGHT+IHNq+4sDdblZNYnqKgN4AGeXVDzSpn75fbz1b5s79akmRXh5f+QvTq/EY/dvZ9s4N6QlCj0mg== X-Received: by 2002:a05:6a21:3996:b0:1db:d738:f2ff with SMTP id adf61e73a8af0-1e88cf7f75dmr21941550637.2.1736561256749; Fri, 10 Jan 2025 18:07:36 -0800 (PST) Received: from ?IPV6:240e:3af:e05:c460:74c2:d24d:3e6:13f6? ([240e:3af:e05:c460:74c2:d24d:3e6:13f6]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-72d40658fcfsm2100208b3a.111.2025.01.10.18.07.32 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 10 Jan 2025 18:07:36 -0800 (PST) Message-ID: Date: Sat, 11 Jan 2025 10:07:14 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.3.0 To: donettom@linux.ibm.com Cc: akpm@linux-foundation.org, aneesh.kumar@kernel.org, hannes@cmpxchg.org, kaiyang2@cs.cmu.edu, linux-kernel@vger.kernel.org, linux-mm@kvack.org, mhocko@kernel.org, muchun.song@linux.dev, rientjes@google.com, ritesh.list@gmail.com, roman.gushchin@linux.dev, shakeel.butt@linux.dev, weixugc@google.com, yuzhao@google.com References: <20250109060540.451261-1-donettom@linux.ibm.com> Subject: Re: [PATCH] mm: vmscan : pgdemote vmstat is not getting updated when MGLRU is enabled. From: Li Zhijian In-Reply-To: <20250109060540.451261-1-donettom@linux.ibm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit > When MGLRU is enabled, the pgdemote_kswapd, pgdemote_direct, and > pgdemote_khugepaged stats in vmstat are not being updated. > > 'Commit f77f0c751478 ("mm,memcg: provide per-cgroup counters for > NUMA balancing operations")' moved the pgdemote vmstat update > from demote_folio_list() to shrink_inactive_list(), which is in > the normal LRU path. As a result, the pgdemote stats are updated > correctly for the normal LRU but not for MGLRU. > > To address this, we have added the pgdemote stat update in the > evict_folios() function, which is in the MGLRU path. With this > patch, the pgdemote stats will now be updated correctly when MGLRU > is enabled. > > Without this patch vmstat output when MGLRU is enabled > ====================================================== > pgdemote_kswapd 0 > pgdemote_direct 0 > pgdemote_khugepaged 0 > > With this patch vmstat output when MGLRU is enabled > =================================================== > pgdemote_kswapd 43234 > pgdemote_direct 4691 > pgdemote_khugepaged 0 > > Fixes: f77f0c751478 ("mm,memcg: provide per-cgroup counters for NUMA balancing operations") > Signed-off-by: Donet Tom Great minds think alike, It's excatly same with mine[0] :) There is another bug[1] as well. [0] https://lore.kernel.org/linux-mm/20250110122133.423481-2-lizhijian@fujitsu.com/ [1] https://lore.kernel.org/linux-mm/20250110122133.423481-1-lizhijian@fujitsu.com/ Feel free to add vvv if your patch is accepted at last. Tested-by: Li Zhijian Reviewed-by: Li Zhijian > --- > mm/vmscan.c | 3 +++ > 1 filechanged , 3 insertions(+) > > diff > > --git a/mm/vmscan.c b/mm/vmscan.c index 9a859b7d18d7..b1ec5ece067e > 100644 --- a/mm/vmscan.c +++ b/mm/vmscan.c @@ -4642,6 +4642,9 @@ > static int evict_folios(struct lruvec *lruvec, struct scan_control > *sc, int swap reset_batch_size(walk); > } > > + __mod_lruvec_state(lruvec, PGDEMOTE_KSWAPD + reclaimer_offset(), + > stat.nr_demoted); + item = PGSTEAL_KSWAPD + reclaimer_offset(); > if (!cgroup_reclaim(sc)) > __count_vm_events(item, reclaimed); > --