Re: [PATCH v9 09/10] leds: flash: mt6370: Add MediaTek MT6370 flashlight support

Andy Shevchenko
2022-09-21T11:50:00Z

On Wed, Sep 21, 2022 at 4:48 AM ChiaEn Wu <peterwu.pub@gmail.com> wrote:
> On Sun, Sep 18, 2022 at 3:22 AM Han Jingoo <jingoohan1@gmail.com> wrote:
> > On Mon, Aug 29, 2022 ChiaEn Wu <peterwu.pub@gmail.com> wrote:

> > > +#define MT6370_ITORCH_MIN_uA 25000
> > > +#define MT6370_ITORCH_STEP_uA 12500
> > > +#define MT6370_ITORCH_MAX_uA 400000
> > > +#define MT6370_ITORCH_DOUBLE_MAX_uA 800000
> > > +#define MT6370_ISTRB_MIN_uA 50000
> > > +#define MT6370_ISTRB_STEP_uA 12500
> > > +#define MT6370_ISTRB_MAX_uA 1500000
> > > +#define MT6370_ISTRB_DOUBLE_MAX_uA 3000000
> >
> > Use upper letters as below:

For microseconds (and other -seconds) the common practice (I assume
historically) is to use upper letters, indeed. But for current it's
more natural to use small letters for unit multiplier as it's easier
to read and understand.

> > #define MT6370_ITORCH_MIN_UA 25000
> > #define MT6370_ITORCH_STEP_UA 12500
> > #define MT6370_ITORCH_MAX_UA 400000
> > #define MT6370_ITORCH_DOUBLE_MAX_UA 800000
> > #define MT6370_ISTRB_MIN_UA 50000
> > #define MT6370_ISTRB_STEP_UA 12500
> > #define MT6370_ISTRB_MAX_UA 1500000
> > #define MT6370_ISTRB_DOUBLE_MAX_UA 3000000
> >
> > > +#define MT6370_STRBTO_MIN_US 64000
> > > +#define MT6370_STRBTO_STEP_US 32000
> > > +#define MT6370_STRBTO_MAX_US 2432000
>
> Hi Jingoo,
>
> This coding style is in accordance with Andy's opinion in this mail:
> https://lore.kernel.org/linux-arm-kernel/CAHp75Vciq4M4kVrabNV9vTLLcd1vR=bMe8JLEdAF9MkRTpcB5g@mail.gmail.com/

True.

--
With Best Regards,
Andy Shevchenko