From: Sean Anderson <sean.anderson@linux.dev>
To: Petr Tesarik <ptesarik@suse.com>,
Steven Rostedt <rostedt@goodmis.org>,
Masami Hiramatsu <mhiramat@kernel.org>,
Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
Marek Szyprowski <m.szyprowski@samsung.com>,
Robin Murphy <robin.murphy@arm.com>
Cc: linux-trace-kernel@vger.kernel.org, iommu@lists.linux.dev,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] dma-mapping: fix direction in dma_alloc direction traces
Date: Thu, 2 Oct 2025 16:34:05 -0400 [thread overview]
Message-ID: <a97c8722-afb1-440a-83a5-32d7ab3b1a19@linux.dev> (raw)
In-Reply-To: <20251001061028.412258-1-ptesarik@suse.com>
On 10/1/25 02:10, Petr Tesarik wrote:
> Set __entry->dir to the actual "dir" parameter of all trace events
> in dma_alloc_class. This struct member was left uninitialized by
> mistake.
>
> Signed-off-by: Petr Tesarik <ptesarik@suse.com>
> Fixes: 3afff779a725 ("dma-mapping: trace dma_alloc/free direction")
> ---
> include/trace/events/dma.h | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/include/trace/events/dma.h b/include/trace/events/dma.h
> index d8ddc27b6a7c8..945fcbaae77e9 100644
> --- a/include/trace/events/dma.h
> +++ b/include/trace/events/dma.h
> @@ -134,6 +134,7 @@ DECLARE_EVENT_CLASS(dma_alloc_class,
> __entry->dma_addr = dma_addr;
> __entry->size = size;
> __entry->flags = flags;
> + __entry->dir = dir;
> __entry->attrs = attrs;
> ),
>
Reviewed-by: Sean Anderson <sean.anderson@linux.dev>
next prev parent reply other threads:[~2025-10-02 20:34 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20251001061047eucas1p1f96a848ff2643b48179dd3e55959da7e@eucas1p1.samsung.com>
2025-10-01 6:10 ` [PATCH] dma-mapping: fix direction in dma_alloc direction traces Petr Tesarik
2025-10-01 6:16 ` Petr Tesarik
2025-10-02 20:34 ` Sean Anderson [this message]
2025-10-03 7:00 ` Marek Szyprowski
2025-10-03 7:07 ` Petr Tesarik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a97c8722-afb1-440a-83a5-32d7ab3b1a19@linux.dev \
--to=sean.anderson@linux.dev \
--cc=iommu@lists.linux.dev \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=mathieu.desnoyers@efficios.com \
--cc=mhiramat@kernel.org \
--cc=ptesarik@suse.com \
--cc=robin.murphy@arm.com \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox