From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Tim Lunn <tim@feathertop.org>,
linux-rockchip@lists.infradead.org, devicetree@vger.kernel.org
Cc: linux-arm-kernel@lists.infradead.org,
Chris Zhong <zyw@rock-chips.com>,
Conor Dooley <conor+dt@kernel.org>,
Heiko Stuebner <heiko@sntech.de>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Lee Jones <lee@kernel.org>, Rob Herring <robh+dt@kernel.org>,
Zhang Qing <zhangqing@rock-chips.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/3] dt-bindings: rockchip: Document rk809 support for rk817 audio codec
Date: Wed, 17 Jan 2024 08:43:01 +0100 [thread overview]
Message-ID: <a98f1927-53fe-420c-86d0-e91eeab0e9ab@linaro.org> (raw)
In-Reply-To: <20240116132102.3272682-2-tim@feathertop.org>
On 16/01/2024 14:21, Tim Lunn wrote:
> Rockchip RK809 shares the same audio codec as the rk817 mfd, it is also
> using the same rk817_codec driver. However it is missing from the
> bindings.
>
> Update dt-binding documentation for rk809 to include the audio codec
> properties. This fixes the following warning from dtb check:
>
> pmic@20: '#sound-dai-cells', 'assigned-clock-parents', 'assigned-clocks',
> 'clock-names', 'clocks', 'codec' do not match any of the regexes:
> 'pinctrl-[0-9]+'
>
> Signed-off-by: Tim Lunn <tim@feathertop.org>
> ---
>
> (no changes since v1)
>
> .../bindings/mfd/rockchip,rk809.yaml | 30 ++++++++++++++++++-
> 1 file changed, 29 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/mfd/rockchip,rk809.yaml b/Documentation/devicetree/bindings/mfd/rockchip,rk809.yaml
> index 839c0521f1e5..bac2e751e2f2 100644
> --- a/Documentation/devicetree/bindings/mfd/rockchip,rk809.yaml
> +++ b/Documentation/devicetree/bindings/mfd/rockchip,rk809.yaml
> @@ -12,7 +12,7 @@ maintainers:
>
> description: |
> Rockchip RK809 series PMIC. This device consists of an i2c controlled MFD
> - that includes regulators, an RTC, and power button.
> + that includes regulators, an RTC, a power button, and an audio codec.
>
> properties:
> compatible:
> @@ -93,6 +93,34 @@ properties:
> unevaluatedProperties: false
> unevaluatedProperties: false
>
> + clocks:
> + description:
> + The input clock for the audio codec.
Nothing improved here. Implement the feedback.
Don't send the patchsets more than once per day, so reviewers can
actually review it.
Best regards,
Krzysztof
next prev parent reply other threads:[~2024-01-17 7:43 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-16 13:20 [PATCH v2 0/3] dt-bindings: rockchip: Add support for rk809 audio codec Tim Lunn
2024-01-16 13:21 ` [PATCH v2 1/3] dt-bindings: rockchip: Document rk809 support for rk817 " Tim Lunn
2024-01-16 17:06 ` Conor Dooley
2024-01-17 9:22 ` Tim Lunn
[not found] ` <72ed509c-f754-4e65-a65e-130185777c53@feathertop.org>
2024-01-17 9:22 ` Krzysztof Kozlowski
2024-01-17 9:58 ` Tim Lunn
2024-01-17 15:29 ` Conor Dooley
2024-01-18 15:21 ` Chris Morgan
2024-01-17 7:43 ` Krzysztof Kozlowski [this message]
2024-01-16 13:21 ` [PATCH v2 2/3] dt-bindings: rockchip: rk809 fix existing example Tim Lunn
2024-01-16 17:07 ` Conor Dooley
2024-01-17 9:29 ` Tim Lunn
2024-01-17 7:43 ` Krzysztof Kozlowski
2024-01-17 10:00 ` Tim Lunn
2024-01-16 13:21 ` [PATCH v2 3/3] dt-bindings: rockchip: Update rk809 example with audio codec properties Tim Lunn
2024-01-16 17:09 ` Conor Dooley
2024-01-16 19:52 ` [PATCH v2 0/3] dt-bindings: rockchip: Add support for rk809 audio codec Rob Herring
2024-01-17 9:42 ` Tim Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a98f1927-53fe-420c-86d0-e91eeab0e9ab@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=heiko@sntech.de \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lee@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=robh+dt@kernel.org \
--cc=tim@feathertop.org \
--cc=zhangqing@rock-chips.com \
--cc=zyw@rock-chips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).