From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from BYAPR05CU005.outbound.protection.outlook.com (mail-westusazon11010053.outbound.protection.outlook.com [52.101.85.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3ACCF282F38 for ; Fri, 8 May 2026 17:05:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.85.53 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778259961; cv=fail; b=YZqxrTSLs3Ed4LrhIJG+Yfo21tUE12Y+wfMMvPql84a+q43mCA3yzScLBa/yzlxCXxPgDkIEE6tngO9nKKkrwaVKkJJ8lrlC/G8CvvDwgig5+fI5A+nF1gl1rK/cYw86s4KxBjkxNgGHgeQv+ciU90Y0WehsMIK+at0klcOYsyM= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778259961; c=relaxed/simple; bh=/QOV4sd0TD9ZRuW+bHeGsSQzqGgff5RQ4Bkl6k80AtU=; h=Message-ID:Date:MIME-Version:Subject:To:CC:References:From: In-Reply-To:Content-Type; b=o1zuAnBRuAV4UefzFSp6zBJo3krVB/fgFNkXqLqVpcbvKlGExYLTsFFtpT7UXgDAWDvNa8bS9tcM7uNyCAulD9dk67faUhbjx8R/RK4IqBUt7ZFhF9BLrZm1arAmYlpnG6UWtWDYn46cK2YX6BpeO1f3TORb7ICiu9dyE51v/WQ= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=ti.com; spf=pass smtp.mailfrom=ti.com; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b=X5IfblKY; arc=fail smtp.client-ip=52.101.85.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=ti.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ti.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b="X5IfblKY" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=wXoBV6bpVsyruAv7qF5egHQ1WpPSkZH+MJYuUSBj1dzQw5cYUEi+NOREfO/iDMaFEpQaJBMWZUnRwrUPDaImaESPtruTzhe+w26/doWbV+PMsAHiMnvpbAJYDFzkeiFCJsk1ZTivnY23dEV2PfXje2uRheYI2dcjh62KeBF5yIcbseDUof+aJBZvSquSQYB3mCO1neCMZxLrzgUEa7aX5Lg4H84bVi+r1XKF+sxnps/nwg/xQ1p027pLIMLSzSS3TfMFtaqn8PaYNq2UAtgv4qbmkUDs2CDF3jFnVsYkgSY+aAtWHenEJH2mDej1W2ekfvw0vrdi2eYEb1EfDx9+vg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ZDlV4NWCiR4kbBA8K7jTos5DT+Ggq8KUEZufI5IYJmc=; b=QVoveNuG9eBcIsVMTDpe4kakA0TSTkhxAYvTOYRJbHx9QDpoxFczvWc/YRbVgGGxd19WCdveVNyDvU0qoX9GaaV86dYQ1WT38z1/Fbk4HkIYsOYMzoJxd8zysa8ZhbKOHNY36s4He1h7DbUCWFaW+lxyUCZX6HEvX4UOpEE2DV23IrRA+1r/rBfKtFEVywtzjtXM1aUphx473yeYyscdRKXWh5ArC/AJHIrEMxwWF1Cjc9HbRtArO4EnwgBxocLK+vfkB1MJtbwuuaGXtI4OEBMMYIRBKaOedZz+49B5XJ4nJ+PmrkIGxV83RPTAgmiPgWMTrLf9S4d8xWMjH8Ejjw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 198.47.23.194) smtp.rcpttodomain=vger.kernel.org smtp.mailfrom=ti.com; dmarc=pass (p=quarantine sp=none pct=100) action=none header.from=ti.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ZDlV4NWCiR4kbBA8K7jTos5DT+Ggq8KUEZufI5IYJmc=; b=X5IfblKY8qrSCk4IYC866Hat8eOAO5miCGDnVZ5MGCrLBOT+1kVIc9LUGBxeblYzPunKGmFZNSQSjLtRQqMyjsoyv7aDWs3pUHbU+thZCSDpJD3o2P8NLw5Nsu4R2Wxh/qiCl6ELy59sFSba2fufQPlDDvDWtGi8nmgNooLe9kQ= Received: from CH2PR02CA0018.namprd02.prod.outlook.com (2603:10b6:610:4e::28) by LV3PR10MB8202.namprd10.prod.outlook.com (2603:10b6:408:28c::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9891.18; Fri, 8 May 2026 17:05:55 +0000 Received: from CH3PEPF00000016.namprd21.prod.outlook.com (2603:10b6:610:4e:cafe::3e) by CH2PR02CA0018.outlook.office365.com (2603:10b6:610:4e::28) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.9891.20 via Frontend Transport; Fri, 8 May 2026 17:05:53 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 198.47.23.194) smtp.mailfrom=ti.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=ti.com; Received-SPF: Pass (protection.outlook.com: domain of ti.com designates 198.47.23.194 as permitted sender) receiver=protection.outlook.com; client-ip=198.47.23.194; helo=lewvzet200.ext.ti.com; pr=C Received: from lewvzet200.ext.ti.com (198.47.23.194) by CH3PEPF00000016.mail.protection.outlook.com (10.167.244.121) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.25.1 via Frontend Transport; Fri, 8 May 2026 17:05:53 +0000 Received: from DLEE214.ent.ti.com (157.170.170.117) by lewvzet200.ext.ti.com (10.4.14.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.37; Fri, 8 May 2026 12:05:51 -0500 Received: from DLEE209.ent.ti.com (157.170.170.98) by DLEE214.ent.ti.com (157.170.170.117) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.37; Fri, 8 May 2026 12:05:51 -0500 Received: from lelvem-mr06.itg.ti.com (10.180.75.8) by DLEE209.ent.ti.com (157.170.170.98) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.37 via Frontend Transport; Fri, 8 May 2026 12:05:51 -0500 Received: from [10.249.42.149] ([10.249.42.149]) by lelvem-mr06.itg.ti.com (8.18.1/8.18.1) with ESMTP id 648H5oF81803757; Fri, 8 May 2026 12:05:51 -0500 Message-ID: Date: Fri, 8 May 2026 12:05:50 -0500 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 03/11] soc: ti: knav_qmss: Inline lockdep condition in for_each_handle_rcu To: Nishanth Menon , Justin Stitt , "Bill Wendling" , Nick Desaulniers , Nathan Chancellor , Santosh Shilimkar CC: , , References: <20260508153211.3688277-1-nm@ti.com> <20260508153211.3688277-4-nm@ti.com> Content-Language: en-US From: Andrew Davis In-Reply-To: <20260508153211.3688277-4-nm@ti.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-C2ProcessedOrg: 333ef613-75bf-4e12-a4b1-8e3623f5dcea X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH3PEPF00000016:EE_|LV3PR10MB8202:EE_ X-MS-Office365-Filtering-Correlation-Id: fad5b9d4-0199-42a2-e7db-08dead240fef X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|82310400026|1800799024|36860700016|376014|22082099003|18002099003|56012099003; X-Microsoft-Antispam-Message-Info: 38Hx39yLlb4w747KTMFUFWU6g/sk2yKeWX1qIjfIR17Hh3fY8fVTEhvrVQeXB/xyiQTFyzIv2bzLbENT5i095oVnbAPz/ZNiFF2e+oEO8CCj6itIAHXKEN5VqLYS0nou9XIIGLt7222p/ScPi7OJSyvwn2fkr7vnU4JGSxwzzzEE8//gUCcH6u0FWwjVAa7/9kTAswovb2/hs7yQMXAl3fFuxd9DHE2ptQOYO1x9L5jHutg8ZJIiw5fHAkiPF90dN4FE1iYIIgJuF1cUe44bAdALznsWKsBEdWBWZbrTJ0qaZZMUPrdtWyWDn13+mN2/1BfKOFnqe4xZaf03COY63CpOFcNhxwTjuHQvstPiM8S3e5Fb4WtVfyeslb1zvKdXQIv/3OOFQ+qD1CkAHpHVkqrpvw9a9qqzJga4a5iKbsgqxTMSEF8yGTSWBy2NubT3fph6h4Zw7ScGrQK4GXYa7J6D4ZdymeE5pUHVStyrkZtjYfczmT9TqzkscWJGQHW9AyfbHNxIazD4hxtJCjWwFuDWVWJ4MQV4KdMQbzaK65z5jgG8OZrkwIm2uYlHdqMhyaL17isyvE/2HZSAHeWKKCk8qs/DNbXS5ZGbLx6do/jNU0UyU1hC5joAt8BLIO/6wgfAa9vAFUZZy34nOOCJ9tj0oHSOUxRNyRuF8uAP+fL6qdGrTNk4fkXnG3eju6fUZWQzJGi0i7TSmMCFkXwmAZsiQTMetpFAaduCaYYRBvQ= X-Forefront-Antispam-Report: CIP:198.47.23.194;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:lewvzet200.ext.ti.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(82310400026)(1800799024)(36860700016)(376014)(22082099003)(18002099003)(56012099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: S36an4qp2NrZQ6n4ytx+bZxAPE9sp/AZzZac4nRQDlnzfnVZaX0TuuBziBgsFtwJEaJ2mcbh9f+WMaER0BmO8pIzD/iq3/kGpImQ0XoVgzm/pXRkm9s3rfc42D43QWPOIsIfjsK8BZBQsD5l7NI51V0fK45SB6XwMaLHFg0o3XAy8xcYCpZuREt3nLVbboQtAMQbkYKsSpsTpztvMaib7QVZ+G/7ji7SGt9ePMujG6kE3O+lS9wD5RWL2wYHFJKfE2h3bKXyHnP6KJJJ2UehE6X3EEjsgjlIvUzrLMvRqxQ30xIGD1MawGWLA3tmDn/K3aI7Zb7UlqG8isyC7WdKxEeDK9ZIHc17q8gtrL2PJtXHIz4vYgylXImrt0sJSopwXyeOhwN3qJx4j8npoyoThS2gPaszSSO3lJLB8n/SEeZXvKjWyw2RKi5JXgLrjerZ X-OriginatorOrg: ti.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 May 2026 17:05:53.0004 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: fad5b9d4-0199-42a2-e7db-08dead240fef X-MS-Exchange-CrossTenant-Id: e5b49634-450b-4709-8abb-1e2b19b982b7 X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=e5b49634-450b-4709-8abb-1e2b19b982b7;Ip=[198.47.23.194];Helo=[lewvzet200.ext.ti.com] X-MS-Exchange-CrossTenant-AuthSource: CH3PEPF00000016.namprd21.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: LV3PR10MB8202 On 5/8/26 10:32 AM, Nishanth Menon wrote: > knav_dev_lock_held() is a single-use wrapper around > lockdep_is_held(&knav_dev_lock), used only as the lockdep condition > in for_each_handle_rcu. When CONFIG_LOCKDEP is disabled, Is it when CONFIG_LOCKDEP is disabled, or is it when CONFIG_PROVE_RCU_LIST is disabled the condition argument is ignored? Anyway, good to zap this single-use macro, so Reviewed-by: Andrew Davis > list_for_each_entry_rcu() elides the condition argument entirely, > causing clang to report the macro as unused with W=2: > > knav_qmss_queue.c:30:9: warning: macro is not used [-Wunused-macros] > 30 | #define knav_dev_lock_held() \ > > Remove the intermediate macro and open-code lockdep_is_held() directly > in the for_each_handle_rcu definition. > > Signed-off-by: Nishanth Menon > --- > drivers/soc/ti/knav_qmss_queue.c | 5 +---- > 1 file changed, 1 insertion(+), 4 deletions(-) > > diff --git a/drivers/soc/ti/knav_qmss_queue.c b/drivers/soc/ti/knav_qmss_queue.c > index 2c103bb6edef..f65658014b05 100644 > --- a/drivers/soc/ti/knav_qmss_queue.c > +++ b/drivers/soc/ti/knav_qmss_queue.c > @@ -27,9 +27,6 @@ > > static struct knav_device *knav_qdev; > static DEFINE_MUTEX(knav_dev_lock); > -#define knav_dev_lock_held() \ > - lockdep_is_held(&knav_dev_lock) > - > /* Queue manager register indices in DTS */ > #define KNAV_QUEUE_PEEK_REG_INDEX 0 > #define KNAV_QUEUE_STATUS_REG_INDEX 1 > @@ -58,7 +55,7 @@ static DEFINE_MUTEX(knav_dev_lock); > > #define for_each_handle_rcu(qh, inst) \ > list_for_each_entry_rcu(qh, &inst->handles, list, \ > - knav_dev_lock_held()) > + lockdep_is_held(&knav_dev_lock)) > > #define for_each_instance(idx, inst, kdev) \ > for (idx = 0, inst = kdev->instances; \