Re: [PATCH 1/9] dt-bindings: arm: Add support for DSB element

Tao Zhang
2022-09-13T07:57:22Z

在 9/13/2022 8:48 AM, Rob Herring 写道:
> On Thu, Sep 08, 2022 at 04:44:57PM +0800, Tao Zhang wrote:
>> Add property "qcom,dsb-elem-size" to support DSB element for TPDA.
>> Specifies the DSB element size supported by each monitor connected
>> to the aggregator on each port. Should be specified in pairs (port,
>> dsb element size).
> What is DSB?

The full name of DSB is "Discrete Single Bit".

The DSB element size supported by different DSB subunit TPDMs is
different, so TPDA needs to be informed through configuration in device
tree.

>> Signed-off-by: Tao Zhang <quic_taozha@quicinc.com>
>> ---
>> Documentation/devicetree/bindings/arm/qcom,coresight-tpda.yaml | 9 +++++++++
>> 1 file changed, 9 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/arm/qcom,coresight-tpda.yaml b/Documentation/devicetree/bindings/arm/qcom,coresight-tpda.yaml
>> index eb9bfc5..1bb3fdf 100644
>> --- a/Documentation/devicetree/bindings/arm/qcom,coresight-tpda.yaml
>> +++ b/Documentation/devicetree/bindings/arm/qcom,coresight-tpda.yaml
>> @@ -40,6 +40,13 @@ properties:
>> minItems: 1
>> maxItems: 2
>>
>> + qcom,dsb-elem-size:
>> + description: |
>> + Specifies the DSB element size supported by each monitor
>> + connected to the aggregator on each port. Should be specified
>> + in pairs (port, dsb element size).
>> + $ref: /schemas/types.yaml#/definitions/uint32-array
> The binding (not yet upstream) says there is just 1 port (port 0). So
> why do you need more than a single uint32?
>
> Rob

TPDA(Trace, Profiling and Diagnostics Aggregator) is to provide
packetization, funneling and timestamping of TPDM data.

Multiple monitors are connected to different input ports of TPDA.

- - - -                 - - - -                 - - - -
| TPDM 0|      | TPDM 1 |     | TPDM 2|
- - - -                 - - - -                 - - - -
|                       |                       |
|_ _ _ _ _ _     |         _ _ _ _  |
|   |        |
|   |        |
------------------
|        TPDA      |
------------------

There may be multiple DSB subunit TPDMs connected to different input
ports of the same TPDA, so we need to use port here to define the
distinction in device tree.

Best regards,

Tao