Re: [PATCH 1/9] dt-bindings: arm: Add support for DSB element

Rob Herring
2022-09-13T00:49:08Z

On Thu, Sep 08, 2022 at 04:44:57PM +0800, Tao Zhang wrote:
> Add property "qcom,dsb-elem-size" to support DSB element for TPDA.
> Specifies the DSB element size supported by each monitor connected
> to the aggregator on each port. Should be specified in pairs (port,
> dsb element size).

What is DSB?

>
> Signed-off-by: Tao Zhang <quic_taozha@quicinc.com>
> ---
> Documentation/devicetree/bindings/arm/qcom,coresight-tpda.yaml | 9 +++++++++
> 1 file changed, 9 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/arm/qcom,coresight-tpda.yaml b/Documentation/devicetree/bindings/arm/qcom,coresight-tpda.yaml
> index eb9bfc5..1bb3fdf 100644
> --- a/Documentation/devicetree/bindings/arm/qcom,coresight-tpda.yaml
> +++ b/Documentation/devicetree/bindings/arm/qcom,coresight-tpda.yaml
> @@ -40,6 +40,13 @@ properties:
> minItems: 1
> maxItems: 2
>
> + qcom,dsb-elem-size:
> + description: |
> + Specifies the DSB element size supported by each monitor
> + connected to the aggregator on each port. Should be specified
> + in pairs (port, dsb element size).
> + $ref: /schemas/types.yaml#/definitions/uint32-array

The binding (not yet upstream) says there is just 1 port (port 0). So
why do you need more than a single uint32?

Rob