From: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
Vikash Garodia <quic_vgarodia@quicinc.com>,
Dikshita Agarwal <quic_dikshita@quicinc.com>,
Abhinav Kumar <abhinav.kumar@linux.dev>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
linux-arm-msm@vger.kernel.org, linux-media@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] media: dt-bindings: qcom,sm8550-iris: Do not reference legacy venus properties
Date: Thu, 28 Aug 2025 16:24:39 +0200 [thread overview]
Message-ID: <a9c40b7d-d70d-48fb-b4a0-deb773969936@linaro.org> (raw)
In-Reply-To: <20250823155349.22344-2-krzysztof.kozlowski@linaro.org>
On 23/08/2025 17:53, Krzysztof Kozlowski wrote:
> The Qualcomm SoC Iris video codec is an evolution of previous Venus and
> it comes with its own Iris Linux drivers. These new drivers were
> accepted under condition they actually improve state of afairs, instead
> of duplicating old, legacy solutions.
>
> Unfortunately binding still references common parts of Venus without
> actual need and benefit. For example Iris does not use fake
> "video-firmware" device node (fake because there is no actual device
> underlying it and it was added only to work around some Linux issues
> with IOMMU mappings).
>
> Stop referencing venus-common schema in the new Qualcomm Iris bindings
> and move all necessary properties, except unused "video-firmware" (no
> driver usage, no DTS).
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
> .../devicetree/bindings/media/qcom,sm8550-iris.yaml | 13 ++++++++++++-
> 1 file changed, 12 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/media/qcom,sm8550-iris.yaml b/Documentation/devicetree/bindings/media/qcom,sm8550-iris.yaml
> index c79bf2101812..320227f437a1 100644
> --- a/Documentation/devicetree/bindings/media/qcom,sm8550-iris.yaml
> +++ b/Documentation/devicetree/bindings/media/qcom,sm8550-iris.yaml
> @@ -26,6 +26,9 @@ properties:
> - qcom,sm8550-iris
> - qcom,sm8650-iris
>
> + reg:
> + maxItems: 1
> +
> power-domains:
> maxItems: 4
>
> @@ -45,6 +48,12 @@ properties:
> - const: core
> - const: vcodec0_core
>
> + firmware-name:
> + maxItems: 1
> +
> + interrupts:
> + maxItems: 1
> +
> interconnects:
> maxItems: 2
>
> @@ -69,6 +78,9 @@ properties:
>
> dma-coherent: true
>
> + memory-region:
> + maxItems: 1
> +
> operating-points-v2: true
>
> opp-table:
> @@ -85,7 +97,6 @@ required:
> - dma-coherent
>
> allOf:
> - - $ref: qcom,venus-common.yaml#
> - if:
> properties:
> compatible:
Reviewed-by: Bryan O'Donoghue <bod@kernel.org>
next prev parent reply other threads:[~2025-08-28 14:24 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-23 15:53 [PATCH] media: dt-bindings: qcom,sm8550-iris: Do not reference legacy venus properties Krzysztof Kozlowski
2025-08-25 11:37 ` Mukesh Ojha
2025-08-25 12:02 ` Krzysztof Kozlowski
2025-08-25 12:36 ` Mukesh Ojha
2025-08-28 13:49 ` Vikash Garodia
2025-08-28 13:57 ` Krzysztof Kozlowski
2025-08-28 14:05 ` Krzysztof Kozlowski
2025-08-28 14:37 ` Vikash Garodia
2025-09-03 13:10 ` Konrad Dybcio
2025-08-26 23:50 ` Rob Herring (Arm)
2025-08-28 14:24 ` Bryan O'Donoghue [this message]
2025-08-28 14:42 ` Vikash Garodia
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a9c40b7d-d70d-48fb-b4a0-deb773969936@linaro.org \
--to=bryan.odonoghue@linaro.org \
--cc=abhinav.kumar@linux.dev \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=quic_dikshita@quicinc.com \
--cc=quic_vgarodia@quicinc.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).