From: Zenghui Yu <zenghui.yu@linux.dev>
To: Jonathan Corbet <corbet@lwn.net>,
"JiaLong.Yang" <jialong.yang@shingroup.cn>,
Alex Shi <alexs@kernel.org>, Yanteng Si <siyanteng@loongson.cn>
Cc: 2738078698@qq.com, linux-doc@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Docs/zh_CN: Fix the meaning of DEBUG to pr_debug()
Date: Wed, 20 Dec 2023 02:47:29 +0800 [thread overview]
Message-ID: <a9cbebd8-dd6e-d81c-471f-f40dcc7196ea@linux.dev> (raw)
In-Reply-To: <87wmtai77a.fsf@meer.lwn.net>
On 2023/12/19 22:43, Jonathan Corbet wrote:
> "JiaLong.Yang" <jialong.yang@shingroup.cn> writes:
>
>> Signed-off-by: JiaLong.Yang <jialong.yang@shingroup.cn>
>> ---
>> Documentation/translations/zh_CN/core-api/printk-basics.rst | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/Documentation/translations/zh_CN/core-api/printk-basics.rst b/Documentation/translations/zh_CN/core-api/printk-basics.rst
>> index 59c6efb3fc41..cafa01bccff2 100644
>> --- a/Documentation/translations/zh_CN/core-api/printk-basics.rst
>> +++ b/Documentation/translations/zh_CN/core-api/printk-basics.rst
>> @@ -100,7 +100,7 @@ printk()的用法通常是这样的::
>>
>> 为了调试,还有两个有条件编译的宏:
>> pr_debug()和pr_devel(),除非定义了 ``DEBUG`` (或者在pr_debug()的情况下定义了
>> -``CONFIG_DYNAMIC_DEBUG`` ),否则它们会被编译。
>> +``CONFIG_DYNAMIC_DEBUG`` ),否则它们不会被编译。
>>
>
> This patch needs an actual changelog. Being illiterate in Chinese, I
> can't make any connection between the subject line and what has actually
> been done here.
Agreed. The change itself looks correct though, feel free to add my
Reviewed-by: Zenghui Yu <zenghui.yu@linux.dev>
in your next revision (with Jon's suggestion addressed).
Thanks,
Zenghui
next prev parent reply other threads:[~2023-12-19 18:47 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-19 7:08 [PATCH] Docs/zh_CN: Fix the meaning of DEBUG to pr_debug() JiaLong.Yang
2023-12-19 14:43 ` Jonathan Corbet
2023-12-19 18:47 ` Zenghui Yu [this message]
2023-12-20 2:00 ` Yanteng Si
[not found] <202312201105408639401@shingroup.cn>
2023-12-20 6:28 ` JiaLong.Yang
2023-12-20 7:26 ` Yanteng Si
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a9cbebd8-dd6e-d81c-471f-f40dcc7196ea@linux.dev \
--to=zenghui.yu@linux.dev \
--cc=2738078698@qq.com \
--cc=alexs@kernel.org \
--cc=corbet@lwn.net \
--cc=jialong.yang@shingroup.cn \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=siyanteng@loongson.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox