From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1759550AbcIXQzy (ORCPT <rfc822;w@1wt.eu>);
        Sat, 24 Sep 2016 12:55:54 -0400
Received: from mout.web.de ([212.227.17.11]:61616 "EHLO mout.web.de"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1757480AbcIXQzs (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Sat, 24 Sep 2016 12:55:48 -0400
Subject: Re: [PATCH 3/4] Input-gameport: Add the macro "pr_fmt" for module
 "joydump"
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
References: <d8da8333-d83a-ca61-b887-7fd7528c63a4@users.sourceforge.net>
 <3345f7c1-b823-a819-aabf-5b4990068075@users.sourceforge.net>
 <20160924164108.GB40187@dtor-ws>
Cc: linux-input@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>,
        kernel-janitors@vger.kernel.org, Julia Lawall <julia.lawall@lip6.fr>
From: SF Markus Elfring <elfring@users.sourceforge.net>
Message-ID: <a9d9e2fc-4369-ba1a-e1a1-97b0873c28ce@users.sourceforge.net>
Date: Sat, 24 Sep 2016 18:55:41 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101
 Thunderbird/45.3.0
MIME-Version: 1.0
In-Reply-To: <20160924164108.GB40187@dtor-ws>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
X-Provags-ID: V03:K0:ZlaoPvQ+OszJpv2qp4O/Cu7iZZTktc9k1yh30tPBjwQtZlorKkW
 3YnQOpBe/Xs6HH3vit1sqBM6CFZbPnzCsvdRGhuY5giM9spsSYRikobK1qsW0+N0j6UZ7d4
 EcaRbARLNcPUANjwjliZJvNN0cTVme65stCak3oaxU59k6IrJFdqhMkvnRHX5dgCgc9jYv6
 r0vti5DyQXt02g+rdsy2w==
X-UI-Out-Filterresults: notjunk:1;V01:K0:NaWB+enLwqY=:LOkxJrMp4Q8Y3TnXduJGOB
 qTpUsQZEHhcpmsNj4zUMbIpjZCBL/9AFBK6dCK/yKrt8kTTsoIMD+OfU1Qj+WCU3Gl9a0a2RM
 R6Jh87D1HFwQ+/6H+uSaAS8lnsvj493zDZ7xBrZWo6gNp/mXsIebTKKHZ5GWo8oIHLQEmMJIS
 mZQ0PKA+BxoWYEZkTsR6gd8PfXNSekZnv3NrrcHIvRsbeIMncCOtnetj14sTp6PkE2TKx3RG5
 GiFDU/XcH3dblISlsIyU3MrRpqGR4hMzDc6nLaUjBAYAY+5J49yc1eiBj+7DQELo0HZMTNi8B
 eyyv30EH8q3BFPaWPN1itHZUxyrbM1kzStLnXakTBlZ0Yz9EAt0hO9a8EBwhx4sJlhAuT4kWe
 lWRcmSGATMkAs5K1vowkr3zh1x43iNuG40eQrsROK3+5tMwyh+1X+Uc9gTrcOgm4q66wJWisS
 4ht42vX62bggIjwRihM4z7Fts8Fh/2p11v7tabvydRMtXbgXuVk4SZxHfOji7umZoQYWA0oEJ
 0FiTx29cWS/XTf1eru3wdBAakE000GL9A3Mw33hcnKMY6+Pb1my5kXYE+w7xN5WQtgPdPFDUX
 KtGG4lXcKkWEn0K8FWRpGJPT90cs46OS/qLCI/+zLxB7j4AL8tihaUbtKGcY00nkKy7FGOWvU
 usE2NAgQ4aEtQcUXAjEMExlCxYmhZRGMeBiaVdQL10JBQqAIKdxBjNB8OC+IcDG5Y7XjaH+Qg
 nrTjSd+JN3WPL5VerzU6prHS39rEBmci7CLbsddXMt0BhxoQtng6pWcuO8Y5XSBhDUKe4DpLV
 MCX/mqF
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

>> +#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
>> +
> 
> Why did you split it off from the patch where you attempt to use it?

I chose a special patch granularity once again.


> What good does this change do on its own?

I find that it is a preparation. - If this addition could not be accepted,
the following update step would also be discussed under an other perspective,
wouldn't it?

Regards,
Markus