From: David Hildenbrand <david@redhat.com>
To: Baolin Wang <baolin.wang@linux.alibaba.com>,
akpm@linux-foundation.org, hughd@google.com
Cc: ziy@nvidia.com, lorenzo.stoakes@oracle.com,
Liam.Howlett@oracle.com, npache@redhat.com, ryan.roberts@arm.com,
dev.jain@arm.com, baohua@kernel.org, linux-mm@kvack.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 1/2] mm: huge_memory: disallow hugepages if the system-wide THP sysfs settings are disabled
Date: Mon, 23 Jun 2025 15:54:54 +0200 [thread overview]
Message-ID: <a9f77007-78c1-4980-bd31-af5dff741f27@redhat.com> (raw)
In-Reply-To: <adb8d5032ecc7b6935e3197cafffe92cbc7581e6.1750666536.git.baolin.wang@linux.alibaba.com>
> diff --git a/tools/testing/selftests/mm/khugepaged.c b/tools/testing/selftests/mm/khugepaged.c
> index 4341ce6b3b38..85bfff53dba6 100644
> --- a/tools/testing/selftests/mm/khugepaged.c
> +++ b/tools/testing/selftests/mm/khugepaged.c
> @@ -501,11 +501,7 @@ static void __madvise_collapse(const char *msg, char *p, int nr_hpages,
>
> printf("%s...", msg);
>
> - /*
> - * Prevent khugepaged interference and tests that MADV_COLLAPSE
> - * ignores /sys/kernel/mm/transparent_hugepage/enabled
> - */
> - settings.thp_enabled = THP_NEVER;
> + settings.thp_enabled = THP_ALWAYS;
Would MADVISE mode also work here? If we don't set MADV_HUGEPAGE, then
khugepaged should be excluded, correct?
--
Cheers,
David / dhildenb
next prev parent reply other threads:[~2025-06-23 13:54 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-23 8:28 [PATCH v3 0/2] fix MADV_COLLAPSE issue if THP settings are disabled Baolin Wang
2025-06-23 8:28 ` [PATCH v3 1/2] mm: huge_memory: disallow hugepages if the system-wide THP sysfs " Baolin Wang
2025-06-23 10:26 ` Lorenzo Stoakes
2025-06-24 1:45 ` Baolin Wang
2025-06-23 11:08 ` Barry Song
2025-06-24 1:44 ` Baolin Wang
2025-06-23 13:54 ` David Hildenbrand [this message]
2025-06-24 1:48 ` Baolin Wang
2025-06-24 8:29 ` David Hildenbrand
2025-06-24 9:20 ` Baolin Wang
2025-06-23 14:39 ` Zi Yan
2025-06-24 8:41 ` Dev Jain
2025-06-24 9:57 ` Baolin Wang
2025-06-24 14:08 ` Baolin Wang
2025-06-24 14:42 ` Dev Jain
2025-06-23 8:28 ` [PATCH v3 2/2] mm: shmem: disallow hugepages if the system-wide shmem " Baolin Wang
2025-06-23 10:45 ` Lorenzo Stoakes
2025-06-23 13:59 ` David Hildenbrand
2025-06-24 1:52 ` Baolin Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a9f77007-78c1-4980-bd31-af5dff741f27@redhat.com \
--to=david@redhat.com \
--cc=Liam.Howlett@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=baohua@kernel.org \
--cc=baolin.wang@linux.alibaba.com \
--cc=dev.jain@arm.com \
--cc=hughd@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lorenzo.stoakes@oracle.com \
--cc=npache@redhat.com \
--cc=ryan.roberts@arm.com \
--cc=ziy@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).