From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id DAA0CC433F5 for ; Thu, 14 Apr 2022 09:05:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241033AbiDNJIV (ORCPT ); Thu, 14 Apr 2022 05:08:21 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37110 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236690AbiDNJIS (ORCPT ); Thu, 14 Apr 2022 05:08:18 -0400 Received: from ssl.serverraum.org (ssl.serverraum.org [IPv6:2a01:4f8:151:8464::1:2]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B3AAE6D3B6 for ; Thu, 14 Apr 2022 02:05:54 -0700 (PDT) Received: from ssl.serverraum.org (web.serverraum.org [172.16.0.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ssl.serverraum.org (Postfix) with ESMTPSA id 98D4522248; Thu, 14 Apr 2022 11:05:52 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=walle.cc; s=mail2016061301; t=1649927152; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=UZn4yeEtJfu31q4sHyEIHWwLWvwhYu1ql+ooBCPiES8=; b=fDiQDkfMEpy6IN9DTmjvCCvbGW8dfhDoEYdWI9Z5+BvT3APJL+LhpkmrKMCxVg+1UkV1s6 9VjWdL8fK3K4XuKjpXvU57r1bvgtVv9S9VTmPSD4k2Qy1rR4HZfk/BCxm2tzscLxr5V1qt 9IqlXUv+Lqe+bLV47TwXh2KA+x+AWlA= MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Thu, 14 Apr 2022 11:05:52 +0200 From: Michael Walle To: Tudor Ambarus Cc: p.yadav@ti.com, miquel.raynal@bootlin.com, richard@nod.at, vigneshr@ti.com, linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org, nicolas.ferre@microchip.com Subject: Re: [PATCH v3 1/3] mtd: spi-nor: Parse BFPT to determine the 4-Byte Address Mode methods In-Reply-To: <63b485a1e48d3116f8f49cc427049f81@walle.cc> References: <20220411125346.118274-1-tudor.ambarus@microchip.com> <20220411125346.118274-2-tudor.ambarus@microchip.com> <63b485a1e48d3116f8f49cc427049f81@walle.cc> User-Agent: Roundcube Webmail/1.4.13 Message-ID: X-Sender: michael@walle.cc Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org >> + params->set_4byte_addr_mode = spansion_set_4byte_addr_mode; > > Shouldn't this be getting a neutral name? The quad_enable methods > were renamed once, too. Scrap that, I see it is done in patch 2. -michael