From: Gao Xiang <xiang@kernel.org>
To: Hongbo Li <lihongbo22@huawei.com>
Cc: xiang@kernel.org, chao@kernel.org, zbestahu@gmail.com,
jefflexu@linux.alibaba.com, dhavale@google.com,
linux-erofs@lists.ozlabs.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] erofs: remove unused enum type
Date: Mon, 28 Apr 2025 23:17:59 +0800 [thread overview]
Message-ID: <aA+cJ+aMfWdfMBWH@debian> (raw)
In-Reply-To: <20250428142631.488431-1-lihongbo22@huawei.com>
On Mon, Apr 28, 2025 at 02:26:31PM +0000, Hongbo Li wrote:
> Opt_err is not used in EROFS, we can remove it.
>
> Signed-off-by: Hongbo Li <lihongbo22@huawei.com>
> ---
> fs/erofs/super.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/fs/erofs/super.c b/fs/erofs/super.c
> index c1c350c6fbf4..fd365a611f13 100644
> --- a/fs/erofs/super.c
> +++ b/fs/erofs/super.c
> @@ -356,8 +356,7 @@ static void erofs_default_options(struct erofs_sb_info *sbi)
>
> enum {
> Opt_user_xattr, Opt_acl, Opt_cache_strategy, Opt_dax, Opt_dax_enum,
> - Opt_device, Opt_fsid, Opt_domain_id, Opt_directio,
> - Opt_err
> + Opt_device, Opt_fsid, Opt_domain_id, Opt_directio
We'd better to leave the trailing ',' so that we don't need to change
this line again if a new line is introduced.
Otherwise LGTM.
Thanks,
Gao Xiang
> };
>
> static const struct constant_table erofs_param_cache_strategy[] = {
> --
> 2.22.0
>
prev parent reply other threads:[~2025-04-28 15:18 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-28 14:26 [PATCH] erofs: remove unused enum type Hongbo Li
2025-04-28 15:17 ` Gao Xiang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aA+cJ+aMfWdfMBWH@debian \
--to=xiang@kernel.org \
--cc=chao@kernel.org \
--cc=dhavale@google.com \
--cc=jefflexu@linux.alibaba.com \
--cc=lihongbo22@huawei.com \
--cc=linux-erofs@lists.ozlabs.org \
--cc=linux-kernel@vger.kernel.org \
--cc=zbestahu@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox