* [PATCH] erofs: remove unused enum type
@ 2025-04-28 14:26 Hongbo Li
2025-04-28 15:17 ` Gao Xiang
0 siblings, 1 reply; 2+ messages in thread
From: Hongbo Li @ 2025-04-28 14:26 UTC (permalink / raw)
To: xiang, chao, zbestahu, jefflexu
Cc: dhavale, linux-erofs, linux-kernel, lihongbo22
Opt_err is not used in EROFS, we can remove it.
Signed-off-by: Hongbo Li <lihongbo22@huawei.com>
---
fs/erofs/super.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/fs/erofs/super.c b/fs/erofs/super.c
index c1c350c6fbf4..fd365a611f13 100644
--- a/fs/erofs/super.c
+++ b/fs/erofs/super.c
@@ -356,8 +356,7 @@ static void erofs_default_options(struct erofs_sb_info *sbi)
enum {
Opt_user_xattr, Opt_acl, Opt_cache_strategy, Opt_dax, Opt_dax_enum,
- Opt_device, Opt_fsid, Opt_domain_id, Opt_directio,
- Opt_err
+ Opt_device, Opt_fsid, Opt_domain_id, Opt_directio
};
static const struct constant_table erofs_param_cache_strategy[] = {
--
2.22.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] erofs: remove unused enum type
2025-04-28 14:26 [PATCH] erofs: remove unused enum type Hongbo Li
@ 2025-04-28 15:17 ` Gao Xiang
0 siblings, 0 replies; 2+ messages in thread
From: Gao Xiang @ 2025-04-28 15:17 UTC (permalink / raw)
To: Hongbo Li
Cc: xiang, chao, zbestahu, jefflexu, dhavale, linux-erofs,
linux-kernel
On Mon, Apr 28, 2025 at 02:26:31PM +0000, Hongbo Li wrote:
> Opt_err is not used in EROFS, we can remove it.
>
> Signed-off-by: Hongbo Li <lihongbo22@huawei.com>
> ---
> fs/erofs/super.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/fs/erofs/super.c b/fs/erofs/super.c
> index c1c350c6fbf4..fd365a611f13 100644
> --- a/fs/erofs/super.c
> +++ b/fs/erofs/super.c
> @@ -356,8 +356,7 @@ static void erofs_default_options(struct erofs_sb_info *sbi)
>
> enum {
> Opt_user_xattr, Opt_acl, Opt_cache_strategy, Opt_dax, Opt_dax_enum,
> - Opt_device, Opt_fsid, Opt_domain_id, Opt_directio,
> - Opt_err
> + Opt_device, Opt_fsid, Opt_domain_id, Opt_directio
We'd better to leave the trailing ',' so that we don't need to change
this line again if a new line is introduced.
Otherwise LGTM.
Thanks,
Gao Xiang
> };
>
> static const struct constant_table erofs_param_cache_strategy[] = {
> --
> 2.22.0
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2025-04-28 15:18 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-04-28 14:26 [PATCH] erofs: remove unused enum type Hongbo Li
2025-04-28 15:17 ` Gao Xiang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox