From: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
To: WangYuli <wangyuli@uniontech.com>
Cc: robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org,
devicetree@vger.kernel.org, linux-mips@vger.kernel.org,
linux-kernel@vger.kernel.org, jiaxun.yang@flygoat.com,
chenhuacai@kernel.org, yangtiezhu@loongson.cn,
zhanjun@uniontech.com, niecheng1@uniontech.com,
guanwentao@uniontech.com
Subject: Re: [PATCH] MIPS: Loongson64: Add missing '#interrupt-cells' for loongson64c_ls7a
Date: Sun, 27 Apr 2025 09:54:26 +0200 [thread overview]
Message-ID: <aA3islGKVa7cKUaT@alpha.franken.de> (raw)
In-Reply-To: <6E749D043BC7BD99+20250416034548.805069-1-wangyuli@uniontech.com>
On Wed, Apr 16, 2025 at 11:45:48AM +0800, WangYuli wrote:
> Similar to commit 98a9e2ac3755 ("MIPS: Loongson64: DTS: Fix msi node for ls7a").
>
> Fix follow warnings:
> arch/mips/boot/dts/loongson/loongson64c_4core_ls7a.dts:28.31-36.4: Warning (interrupt_provider): /bus@10000000/msi-controller@2ff00000: Missing '#interrupt-cells' in interrupt provider
> arch/mips/boot/dts/loongson/loongson64c_4core_ls7a.dtb: Warning (interrupt_map): Failed prerequisite 'interrupt_provider'
>
> Fixes: 24af105962c8 ("MIPS: Loongson64: DeviceTree for LS7A PCH")
> Tested-by: WangYuli <wangyuli@uniontech.com>
> Signed-off-by: WangYuli <wangyuli@uniontech.com>
> ---
> arch/mips/boot/dts/loongson/loongson64c_4core_ls7a.dts | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/mips/boot/dts/loongson/loongson64c_4core_ls7a.dts b/arch/mips/boot/dts/loongson/loongson64c_4core_ls7a.dts
> index c7ea4f1c0bb2..6c277ab83d4b 100644
> --- a/arch/mips/boot/dts/loongson/loongson64c_4core_ls7a.dts
> +++ b/arch/mips/boot/dts/loongson/loongson64c_4core_ls7a.dts
> @@ -29,6 +29,7 @@ msi: msi-controller@2ff00000 {
> compatible = "loongson,pch-msi-1.0";
> reg = <0 0x2ff00000 0 0x8>;
> interrupt-controller;
> + #interrupt-cells = <1>;
> msi-controller;
> loongson,msi-base-vec = <64>;
> loongson,msi-num-vecs = <64>;
> --
> 2.49.0
applied to mips-next.
Thomas.
--
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea. [ RFC1925, 2.3 ]
next prev parent reply other threads:[~2025-04-27 8:48 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-16 3:45 [PATCH] MIPS: Loongson64: Add missing '#interrupt-cells' for loongson64c_ls7a WangYuli
2025-04-16 12:06 ` Philippe Mathieu-Daudé
2025-04-27 7:54 ` Thomas Bogendoerfer [this message]
2025-05-05 11:24 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aA3islGKVa7cKUaT@alpha.franken.de \
--to=tsbogend@alpha.franken.de \
--cc=chenhuacai@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=guanwentao@uniontech.com \
--cc=jiaxun.yang@flygoat.com \
--cc=krzk+dt@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=niecheng1@uniontech.com \
--cc=robh@kernel.org \
--cc=wangyuli@uniontech.com \
--cc=yangtiezhu@loongson.cn \
--cc=zhanjun@uniontech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox