The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
To: Thorsten Blum <thorsten.blum@linux.dev>
Cc: linux-hardening@vger.kernel.org, linux-mips@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] MIPS: Replace strcpy() with strscpy() in vpe_elfload()
Date: Sun, 27 Apr 2025 09:56:19 +0200	[thread overview]
Message-ID: <aA3jI7dlNJZ1pTsG@alpha.franken.de> (raw)
In-Reply-To: <20250425074651.1362-2-thorsten.blum@linux.dev>

On Fri, Apr 25, 2025 at 09:46:48AM +0200, Thorsten Blum wrote:
> strcpy() is deprecated; use strscpy() instead.
> 
> Link: https://github.com/KSPP/linux/issues/88
> Signed-off-by: Thorsten Blum <thorsten.blum@linux.dev>
> ---
>  arch/mips/kernel/vpe.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/arch/mips/kernel/vpe.c b/arch/mips/kernel/vpe.c
> index 737d0d4fdcd3..2b67c44adab9 100644
> --- a/arch/mips/kernel/vpe.c
> +++ b/arch/mips/kernel/vpe.c
> @@ -22,6 +22,7 @@
>  #include <linux/vmalloc.h>
>  #include <linux/elf.h>
>  #include <linux/seq_file.h>
> +#include <linux/string.h>
>  #include <linux/syscalls.h>
>  #include <linux/moduleloader.h>
>  #include <linux/interrupt.h>
> @@ -582,7 +583,7 @@ static int vpe_elfload(struct vpe *v)
>  	struct module mod; /* so we can re-use the relocations code */
>  
>  	memset(&mod, 0, sizeof(struct module));
> -	strcpy(mod.name, "VPE loader");
> +	strscpy(mod.name, "VPE loader");
>  
>  	hdr = (Elf_Ehdr *) v->pbuffer;
>  	len = v->plen;
> -- 
> 2.49.0

applied to mips-next.

Thomas.

-- 
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea.                                                [ RFC1925, 2.3 ]

      reply	other threads:[~2025-04-27  8:48 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-04-25  7:46 [PATCH] MIPS: Replace strcpy() with strscpy() in vpe_elfload() Thorsten Blum
2025-04-27  7:56 ` Thomas Bogendoerfer [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aA3jI7dlNJZ1pTsG@alpha.franken.de \
    --to=tsbogend@alpha.franken.de \
    --cc=linux-hardening@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mips@vger.kernel.org \
    --cc=thorsten.blum@linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox