From: "Dr. David Alan Gilbert" <linux@treblig.org>
To: Mark Brown <broonie@kernel.org>
Cc: lgirdwood@gmail.com, linux-doc@vger.kernel.org, corbet@lwn.net,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/5] Regulator deadcode cleanups
Date: Sun, 27 Apr 2025 14:58:03 +0000 [thread overview]
Message-ID: <aA5F-_kJO0jFgKpQ@gallifrey> (raw)
In-Reply-To: <aA5Ad6bXfH5jPiss@finisterre.sirena.org.uk>
* Mark Brown (broonie@kernel.org) wrote:
> On Sat, Apr 26, 2025 at 06:51:38PM +0100, linux@treblig.org wrote:
>
> > This is a bunch of deadcode cleanups for functions
> > that are unused (for quite some time).
> > The first patch was originally sent in October last
> > year but didn't get any traction; the rest are new.
>
> Please do some analysis as to why the functions are there, don't just
> blindly delete things.
I'd appreciate some more idea of what you're after; each patch
shows where and when the function was added or last used. Some have
comments saying things like the devm_ version is being used (so it
seemed reasonable to me to delete the plain version if no one uses it).
For each one I've checked _when_ it was last used and not deleted
anything that's been used in the last few years; I've not deleted
anything which has been recently added or only recently unused.
That level seems to have been fine on the other ~300 clean up
patches other maintainers have taken; you seem to be after something
different - I'm fine to add that if you can just explain what
you want.
Just point me in the right direction and I can have more of a dig.
Dave
--
-----Open up your eyes, open up your mind, open up your code -------
/ Dr. David Alan Gilbert | Running GNU/Linux | Happy \
\ dave @ treblig.org | | In Hex /
\ _________________________|_____ http://www.treblig.org |_______/
next prev parent reply other threads:[~2025-04-27 14:58 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-26 17:51 [PATCH 0/5] Regulator deadcode cleanups linux
2025-04-26 17:51 ` [PATCH 1/5] regulator: devres: Remove unused devm_regulator_bulk_register_supply_alias linux
2025-04-26 17:51 ` [PATCH 2/5] regulator: core: Remove unused regulator_bulk_force_disable linux
2025-04-26 17:51 ` [PATCH 3/5] regulator: core: Remove unused regulator_*drvdata functions linux
2025-04-26 17:51 ` [PATCH 4/5] regulator: core: Remove unused regulator_suspend_(disable|enable) linux
2025-04-26 17:51 ` [PATCH 5/5] regulator: core: Remove unused regulator_set_suspend_voltage linux
2025-04-27 14:34 ` [PATCH 0/5] Regulator deadcode cleanups Mark Brown
2025-04-27 14:58 ` Dr. David Alan Gilbert [this message]
2025-04-30 23:18 ` Mark Brown
2025-05-01 0:03 ` Dr. David Alan Gilbert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aA5F-_kJO0jFgKpQ@gallifrey \
--to=linux@treblig.org \
--cc=broonie@kernel.org \
--cc=corbet@lwn.net \
--cc=lgirdwood@gmail.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox