From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from elvis.franken.de (elvis.franken.de [193.175.24.41]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 5136E522A; Sun, 27 Apr 2025 16:23:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=193.175.24.41 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745770992; cv=none; b=cQBdbGPxZd8HWxfUcKSoLWaMVIub+rFQRQ26UyYVHPFzANfgyc0nA8oMnJJ7zsVZV7cR8tjQmfODYZgze689raukYpehI+mb+yvhElZ4xj5G8dPKGCjvQWQ8GNgzzPfcQyhsiUdiFvMP/18q3+2PD7NGfLz8cFpLxpdcxJVfIkk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745770992; c=relaxed/simple; bh=EIOPmxx/fF9h+f6rhelUy6/ZY96XIzB0YB+Bilpm+es=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=G9D+qxdXisIQ/h+o9+zyus/SCTAqVMWEngvv2WWxzndQ2JTv6BcR5OZpmj9oJ/ybL1KVAyAqojB/K+w3lzxlrkBkmN+UDDd/uvkXiMltDvjTtx40EcVzQ8Vcx+8AH53MJ7FWqS+K6dWEtnKnzvCw6LydilmMYp49t5/WBQ1vu28= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=alpha.franken.de; spf=pass smtp.mailfrom=alpha.franken.de; arc=none smtp.client-ip=193.175.24.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=alpha.franken.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=alpha.franken.de Received: from uucp by elvis.franken.de with local-rmail (Exim 3.36 #1) id 1u94mV-0001Ut-00; Sun, 27 Apr 2025 18:23:03 +0200 Received: by alpha.franken.de (Postfix, from userid 1000) id D6D1CC01A2; Sun, 27 Apr 2025 18:22:50 +0200 (CEST) Date: Sun, 27 Apr 2025 18:22:50 +0200 From: Thomas Bogendoerfer To: Thorsten Blum Cc: "Maciej W. Rozycki" , Oleg Nesterov , linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] MIPS: Fix MAX_REG_OFFSET and remove zero-length struct member Message-ID: References: <20250417174712.69292-2-thorsten.blum@linux.dev> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Fri, Apr 18, 2025 at 03:38:36PM +0200, Thorsten Blum wrote: > Would it make sense to also change the register arrays 'mpl' and 'mtp' > from ULL to UL? ULL seems unnecessarily confusing to me. no, ULL is correct. These registers are always 64bit independent whether CPU is in 32bit or 64bit mode. Thomas. -- Crap can work. Given enough thrust pigs will fly, but it's not necessarily a good idea. [ RFC1925, 2.3 ]