From: Niklas Cassel <cassel@kernel.org>
To: Vidya Sagar <vidyas@nvidia.com>
Cc: lpieralisi@kernel.org, kw@linux.com,
manivannan.sadhasivam@linaro.org, robh@kernel.org,
bhelgaas@google.com, linux-pci@vger.kernel.org,
linux-kernel@vger.kernel.org, treding@nvidia.com,
jonathanh@nvidia.com, kthota@nvidia.com, mmaddireddy@nvidia.com,
sagar.tv@gmail.com, Vinod Koul <vkoul@kernel.org>
Subject: Re: [PATCH V3] PCI: dwc: tegra194: Broaden architecture dependency
Date: Thu, 17 Apr 2025 09:51:50 +0200 [thread overview]
Message-ID: <aACzFo2wNYpo4-TN@ryzen> (raw)
In-Reply-To: <20250417074607.2281010-1-vidyas@nvidia.com>
+CC PHY maintainer.
On Thu, Apr 17, 2025 at 01:16:07PM +0530, Vidya Sagar wrote:
> Replace ARCH_TEGRA_194_SOC dependency with a more generic ARCH_TEGRA
> check, allowing the PCIe controller to be built on Tegra platforms
> beyond Tegra194. Additionally, ensure compatibility by requiring
> ARM64 or COMPILE_TEST.
>
> Link: https://patchwork.kernel.org/project/linux-pci/patch/20250128044244.2766334-1-vidyas@nvidia.com/
> Signed-off-by: Vidya Sagar <vidyas@nvidia.com>
> ---
> v3:
> * Addressed warning from kernel test robot
>
> v2:
> * Addressed review comments from Niklas Cassel and Manivannan Sadhasivam
>
> drivers/pci/controller/dwc/Kconfig | 4 ++--
> drivers/phy/tegra/Kconfig | 2 +-
> 2 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/pci/controller/dwc/Kconfig b/drivers/pci/controller/dwc/Kconfig
> index d9f0386396ed..815b6e0d6a0c 100644
> --- a/drivers/pci/controller/dwc/Kconfig
> +++ b/drivers/pci/controller/dwc/Kconfig
> @@ -226,7 +226,7 @@ config PCIE_TEGRA194
>
> config PCIE_TEGRA194_HOST
> tristate "NVIDIA Tegra194 (and later) PCIe controller (host mode)"
> - depends on ARCH_TEGRA_194_SOC || COMPILE_TEST
> + depends on ARCH_TEGRA && (ARM64 || COMPILE_TEST)
> depends on PCI_MSI
> select PCIE_DW_HOST
> select PHY_TEGRA194_P2U
> @@ -241,7 +241,7 @@ config PCIE_TEGRA194_HOST
>
> config PCIE_TEGRA194_EP
> tristate "NVIDIA Tegra194 (and later) PCIe controller (endpoint mode)"
> - depends on ARCH_TEGRA_194_SOC || COMPILE_TEST
> + depends on ARCH_TEGRA && (ARM64 || COMPILE_TEST)
> depends on PCI_ENDPOINT
> select PCIE_DW_EP
> select PHY_TEGRA194_P2U
> diff --git a/drivers/phy/tegra/Kconfig b/drivers/phy/tegra/Kconfig
> index f30cfb42b210..342fb736da4b 100644
> --- a/drivers/phy/tegra/Kconfig
> +++ b/drivers/phy/tegra/Kconfig
> @@ -13,7 +13,7 @@ config PHY_TEGRA_XUSB
>
> config PHY_TEGRA194_P2U
> tristate "NVIDIA Tegra194 PIPE2UPHY PHY driver"
> - depends on ARCH_TEGRA_194_SOC || ARCH_TEGRA_234_SOC || COMPILE_TEST
> + depends on ARCH_TEGRA || COMPILE_TEST
> select GENERIC_PHY
> help
> Enable this to support the P2U (PIPE to UPHY) that is part of Tegra 19x
> --
> 2.25.1
>
next prev parent reply other threads:[~2025-04-17 7:51 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-17 7:46 [PATCH V3] PCI: dwc: tegra194: Broaden architecture dependency Vidya Sagar
2025-04-17 7:51 ` Niklas Cassel [this message]
2025-04-18 11:18 ` Vinod Koul
2025-04-18 17:21 ` Manivannan Sadhasivam
2025-05-05 6:47 ` Vidya Sagar
[not found] ` <SN7PR12MB8028F87148D1B635F832EEB9B88E2@SN7PR12MB8028.namprd12.prod.outlook.com>
2025-05-05 8:24 ` Manivannan Sadhasivam
2025-05-08 5:19 ` [PATCH V4] " Vidya Sagar
2025-05-08 12:17 ` Niklas Cassel
2025-05-08 12:51 ` Thierry Reding
2025-05-08 13:22 ` Krzysztof Wilczyński
2025-05-08 13:20 ` Krzysztof Wilczyński
2025-05-14 11:38 ` Vinod Koul
2025-05-14 13:02 ` Niklas Cassel
2025-05-14 13:17 ` Vinod Koul
2025-05-15 11:33 ` Manivannan Sadhasivam
2026-01-05 12:20 ` Manivannan Sadhasivam
2025-05-08 5:20 ` [PATCH V4] phy: tegra: p2u: " Vidya Sagar
2025-05-08 12:17 ` Niklas Cassel
2025-05-08 12:51 ` Thierry Reding
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aACzFo2wNYpo4-TN@ryzen \
--to=cassel@kernel.org \
--cc=bhelgaas@google.com \
--cc=jonathanh@nvidia.com \
--cc=kthota@nvidia.com \
--cc=kw@linux.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lpieralisi@kernel.org \
--cc=manivannan.sadhasivam@linaro.org \
--cc=mmaddireddy@nvidia.com \
--cc=robh@kernel.org \
--cc=sagar.tv@gmail.com \
--cc=treding@nvidia.com \
--cc=vidyas@nvidia.com \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox