From: Breno Leitao <leitao@debian.org>
To: Zijun Hu <zijun_hu@icloud.com>
Cc: Joel Becker <jlbec@evilplan.org>,
Pantelis Antoniou <pantelis.antoniou@konsulko.com>,
Al Viro <viro@zeniv.linux.org.uk>,
linux-kernel@vger.kernel.org, Zijun Hu <quic_zijuhu@quicinc.com>
Subject: Re: [PATCH 1/4] configfs: Delete semicolon from macro type_print() definition
Date: Thu, 17 Apr 2025 07:38:52 -0700 [thread overview]
Message-ID: <aAESfDy5M26hQ7CY@gmail.com> (raw)
In-Reply-To: <20250408-fix_configfs-v1-1-5a4c88805df7@quicinc.com>
Hello Zijun,
On Tue, Apr 08, 2025 at 09:26:07PM +0800, Zijun Hu wrote:
> From: Zijun Hu <quic_zijuhu@quicinc.com>
>
> Macro type_print() definition ends with semicolon, so will cause
> the subsequent macro invocations end with two semicolons.
where is the type_print() macro invoked today?
I haven't found any reference for it in fs/configfs/dir.c
Thanks
--breno
next prev parent reply other threads:[~2025-04-17 14:38 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-08 13:26 [PATCH 0/4] configfs: fix bugs Zijun Hu
2025-04-08 13:26 ` [PATCH 1/4] configfs: Delete semicolon from macro type_print() definition Zijun Hu
2025-04-08 22:12 ` Joel Becker
2025-04-17 14:38 ` Breno Leitao [this message]
2025-04-17 14:47 ` Zijun Hu
2025-04-08 13:26 ` [PATCH 2/4] configfs: Do not override creating attribute file failure in populate_attrs() Zijun Hu
2025-04-08 22:14 ` Joel Becker
2025-04-08 13:26 ` [PATCH 3/4] configfs: Correct error value returned by API config_item_set_name() Zijun Hu
2025-04-08 22:26 ` Joel Becker
2025-04-08 13:26 ` [PATCH 4/4] configfs: Correct condition for returning -EEXIST in configfs_symlink() Zijun Hu
2025-04-08 22:49 ` Joel Becker
2025-04-10 1:17 ` Zijun Hu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aAESfDy5M26hQ7CY@gmail.com \
--to=leitao@debian.org \
--cc=jlbec@evilplan.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pantelis.antoniou@konsulko.com \
--cc=quic_zijuhu@quicinc.com \
--cc=viro@zeniv.linux.org.uk \
--cc=zijun_hu@icloud.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox