From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f41.google.com (mail-wm1-f41.google.com [209.85.128.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 378C126A086 for ; Fri, 18 Apr 2025 08:11:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.41 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744963883; cv=none; b=dhaWP1yo9z0x0RukvukYmVBW1twQ7sRrK4OLoH6vRrQ4X59CkPHrmxv48hKj3K2UNocab2LMzeDUdv3DGF5OWO4PKat2TSzlZlOXcffOg/9ZdLjBw/S6EocTavYcOKp+ZknY8gPvK7mHCNIKt+c8MU2/y/rOwYociHujDFg6zFo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744963883; c=relaxed/simple; bh=JTfpzxPO7tlw1FRlN8arOMR/8L4Ql6vMZq9I1vDRuzw=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Nl0KM+0kNwj6bwvMT2C+v0/6i/5jvuB5kq0baqvHNZqjnuD8fP4eM+Nn8zxl1xycHlNIS8z+eVLtSjoDfpnsLxq7899bAkH0T7Xyux/LAtlf/cy5MscGdyhs/GOJvB1ShIGWydkVn79lt0U+6JCdW1hfNhPOnlQf9lLkA7nHGsc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=WMLkeJl9; arc=none smtp.client-ip=209.85.128.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="WMLkeJl9" Received: by mail-wm1-f41.google.com with SMTP id 5b1f17b1804b1-43cef035a3bso10623375e9.1 for ; Fri, 18 Apr 2025 01:11:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1744963878; x=1745568678; darn=vger.kernel.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=hBAVQUSIG8/FVcTA2w6Be8v3FlriNZP6ZHZpLpZIhIc=; b=WMLkeJl9lZabsHs40IjQE+sxYfoS3TbFdDZ3RKrWXzxn/WMLfVPnXQWr+Nlby4D2+W TqURlXHe5M9V0icpM7CVVk9tlE8u1JphMBEb46tFjmQIWqpm4YYtBXHmYmv2gyr0FdIe RRDKGzxHieIwOCx/2ayR+LGNkzEdtmTvzVSqVtWUrEuKoUfsLT0iHVAUCY7mJR65jqui 9Hwr+t9UTnMmsdS2KDWOCqDpBY+CmBabonpfZvIFs5gqLPj1YYU6qqSC3Q3lAU4pC4qo 0hv2qroh1ax7fQxqKCgaPasGBUATg95TpanneKTUhI2ue67pvU086ne0Le+9KEf6ZTws aH+A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744963878; x=1745568678; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=hBAVQUSIG8/FVcTA2w6Be8v3FlriNZP6ZHZpLpZIhIc=; b=i+9m3k6Ocixj37DvazQ/23yrT4Ho+XLJWNaqrmfEg/8VUfAeYUeeOz4Y0abl6ThLtt 18ZnXCV+JXrBOZE4JCy8Ow1Q1jT4QRCUwYivayZgFriVP0rQMSfM504FAxSrMdaZ7HMo RwTbzLSPBfqzhSPqjnvJ5FyNnHTrBrxHRblG+vjrnjrJjiSTNbOb3jLurEPtHBbRXH7O HqHdoplV2ehsK7fQiAr1VR7nZm6K/a8i3bEayLI5DjW44gfkKaOTPKp8DaCyXmTzPnkt +A6qUHzSnPnjcTxCzX7arbqdHH5ompR8b/0reSu+drRfirCJMDSYWzHvTMqywMr6gst4 BNMw== X-Forwarded-Encrypted: i=1; AJvYcCWEHvgGt4lgOHRF5KFWC61Q+YAF3eyEBBsrEqeXLPqcSy5UC6mDSgUCEN9/7sZW7gRiEtlKraHrSoqyBpA=@vger.kernel.org X-Gm-Message-State: AOJu0YwSeVUpAkraEs3sOyBIEKbaz4UP3VvjJg/IokZja/BfwGd8TX6W PXhLI2qtviSFBaHEXIyUkZZeXKxf+E40b20l/dzcg9w85UHzJvg8qPxH4rtklXQ= X-Gm-Gg: ASbGncsV2dAgbiMHSEn3+Qaknza1mzWORploUlY1vx+xRw30OEWSOnduRLshg5kv4mL ce1csojczTqNspqdVhKdgwbHU6Dx0q7FINRdXyoDBJuIy0cF4bUubVC/XpOw1Svy+gprDKETqnz 8k699MasAh2d6cq6m8jk0263VXXb/f6VG0o35IY72atogSiXOusdkV5FvZE7W9tCmQEZoxFvDIg Y9lF1tcDHrSnhr2btbfN9o+afXCgqt70hJc3WqzCigqk4WziWMyhc8AmLDoimXsOSP/gxuBwZpY ZeX/6JE9S737Ns9NQkLgTA4d/RR27ExqNn41U4gCxLmVGhex4fq4dzB8XGVvGgB3XXDFUozrq9Z 2UpxagYcaiMd6lQ== X-Google-Smtp-Source: AGHT+IEqy72HPc2JLxk7cwyoLf4zIk+ZCEFJN86qbQUa/AJZooBD3mTTOHD22C31nQiUieXQmKAm3g== X-Received: by 2002:a05:600c:4ecc:b0:43c:eeee:b70a with SMTP id 5b1f17b1804b1-4406ac0aec8mr10500975e9.22.1744963878336; Fri, 18 Apr 2025 01:11:18 -0700 (PDT) Received: from mai.linaro.org (146725694.box.freepro.com. [130.180.211.218]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4406d5bbd12sm12743035e9.20.2025.04.18.01.11.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 18 Apr 2025 01:11:17 -0700 (PDT) Date: Fri, 18 Apr 2025 10:11:16 +0200 From: Daniel Lezcano To: Anand Moon Cc: Bartlomiej Zolnierkiewicz , Krzysztof Kozlowski , "Rafael J. Wysocki" , Zhang Rui , Lukasz Luba , Alim Akhtar , Nathan Chancellor , Nick Desaulniers , Bill Wendling , Justin Stitt , "open list:SAMSUNG THERMAL DRIVER" , "open list:SAMSUNG THERMAL DRIVER" , "moderated list:ARM/SAMSUNG S3C, S5P AND EXYNOS ARM ARCHITECTURES" , open list , "open list:CLANG/LLVM BUILD SUPPORT:Keyword:b(?i:clang|llvm)b" Subject: Re: [PATCH v5 2/3] drivers/thermal/exymos: Remove redundant IS_ERR() checks for clk_sec clock Message-ID: References: <20250410063754.5483-1-linux.amoon@gmail.com> <20250410063754.5483-3-linux.amoon@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20250410063754.5483-3-linux.amoon@gmail.com> On Thu, Apr 10, 2025 at 12:07:49PM +0530, Anand Moon wrote: > Remove unnecessary IS_ERR() checks for the clk_sec clock, > the clk_enable() and clk_disable() functions can handle NULL clock > pointers, so the additional checks are redundant and have been removed > to simplify the code. > > Signed-off-by: Anand Moon Typo in the subject: s/exymos/exynos/ > --- > v5: None > v4: drop IE_ERR() for clk_unprepare() as its handle in earlier code. > v3: improve the commit message. > --- > drivers/thermal/samsung/exynos_tmu.c | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git a/drivers/thermal/samsung/exynos_tmu.c b/drivers/thermal/samsung/exynos_tmu.c > index 3657920de000..ac3b9d2c900c 100644 > --- a/drivers/thermal/samsung/exynos_tmu.c > +++ b/drivers/thermal/samsung/exynos_tmu.c > @@ -258,8 +258,7 @@ static int exynos_tmu_initialize(struct platform_device *pdev) > > mutex_lock(&data->lock); > clk_enable(data->clk); > - if (!IS_ERR(data->clk_sec)) > - clk_enable(data->clk_sec); > + clk_enable(data->clk_sec); > > status = readb(data->base + EXYNOS_TMU_REG_STATUS); > if (!status) { > @@ -269,8 +268,7 @@ static int exynos_tmu_initialize(struct platform_device *pdev) > data->tmu_clear_irqs(data); > } > > - if (!IS_ERR(data->clk_sec)) > - clk_disable(data->clk_sec); > + clk_disable(data->clk_sec); > clk_disable(data->clk); > mutex_unlock(&data->lock); To be replaced by devm_clk_get_enabled() ? > > -- > 2.49.0 > -- Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog