From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f41.google.com (mail-wr1-f41.google.com [209.85.221.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A9EB5215057 for ; Fri, 18 Apr 2025 10:10:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.41 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744971052; cv=none; b=gH6oVHV/10HjNBRRd0ZObf8nMwbaK1Pr9Z0ZefQHo+X5okQ1W6nURM/nxy3Snp/rfkQSV5StGOQfP/0AqLYcLIrlsclFhebZnj59hUE46y4zYsKHDjtXS+r081dRP7nLOKPdITHbkka0/Yf3ZvU7gLbolKP7yfUVgEQoInlD9to= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744971052; c=relaxed/simple; bh=oxo8zJvG+XexDH4GV9ba7u6yzdBoFEqWEzjIqCoHiyU=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=RUVDvGL9pm0LJ1pqwXS0K3zyTMDFpFbiPDHmE4Yu08YuhyHiIgYO2r/5Y11+3gohr3Vx3QoCtiKwg+GSXTNc4xHOZYOyi81QQZkIR6RcssdqghE5cBTId98Frdc0wT0RxpnMZ00ViNpXSMD5Ht74u+bUp8ZZZ18P7Gsl5tx0s5E= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=AeueT/YR; arc=none smtp.client-ip=209.85.221.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="AeueT/YR" Received: by mail-wr1-f41.google.com with SMTP id ffacd0b85a97d-39141ffa9fcso2095003f8f.0 for ; Fri, 18 Apr 2025 03:10:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1744971048; x=1745575848; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=ozue1u0UD/lMowwm+i9KBTDQgenusJImLUvjM+8MVbc=; b=AeueT/YRylIPJ4g7w6ZwgV6AQL7LGieRpYSklr8yT3XahUT6A+CLnlOkEHkhSbQ2tD 5w4A/NeCYYu+iFcDCzmuvGGiekZ1mmmj4OC8qGP1PuXUwfMFWCbGqwfoCsfMQQ2KBqQK ScLmUMDtaJgEeuGiMQcA4Gkp/MMXblHmgfCrFfVB1ULR3TShILgPmTURHMZWUCs0SMuJ JIlPM0M3uiCv40EnQ+ySuxnb6evXCm4/vjVLLez95dKtspZhl8yJPQqNY9ifwETSNAS8 rFx7Aw+ZkW2uRb4tdoS4vu15aHYOFE8+M4mJGw1427BqruQPTYnuH2dzkrtil+msdrl1 f9IA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744971048; x=1745575848; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=ozue1u0UD/lMowwm+i9KBTDQgenusJImLUvjM+8MVbc=; b=J+r1QQOf2VegQFN+yHt43VFIKmfFYw0iPim4OnlZzAMvBSAMC9nKRZZV82k0CJ16lv keeOt0DFxGfmVtw8uxZ3DK7dlT//+7LzilJlOv9oBp6SJLdOYU6lC+4oht+gIyZoMnxw 9Icl4uCkdU27qQi0yUQvNKN74qU9AsQs1lLvmFE/U8MvDWpvOIFuDtLKMNHSdAUBw12m W9ZqMxINTKRlmmOW4TaYuFgde3r4eqOtDVeviebYL7b2KWRUd1AIGSt/+J8SyzTEkOAv DcZ52woK8mY56axEVX67t1WkPwS4ektf4H1y+WcDxmYHwDIVUfP7EV7RbSHzVuplF7Ua twVw== X-Forwarded-Encrypted: i=1; AJvYcCUiHjI35ixX5G1Yy/gDYESoOkTpxX50b06886UWttXm+P2Zv9jDbdirTr/onIOPOu7mKl5gX8/YRgFE3Os=@vger.kernel.org X-Gm-Message-State: AOJu0Yx6oxrLBrWY62BKO2YKAS5pmzVAqXa+yYFg2AHRHlE/pbB9BdxQ P7GOEI3Zw/17OkgCRs2BnzdUgn2ZvAZ2f9jx2Oz+dS+krn7IKy6YuR0TZXMaHjg= X-Gm-Gg: ASbGnctE2v/Tb0maJzPXZFDM6HSlO1emCA9Af1J1XFvH+LKwnwLSVwGDD45I8ah7atX GmWlC2TBE2ecOoLFsHNT9Fr1Ulo4p7RHhzx2D+Lh235f1BXIjoVlc+3yixHWpwJ7XQNUrCcMuWO gtB96eO3P2RP0j57czKYaj8kX8AS5Msmuk5lqy6r/XOrBFLzkbzhLZzVP1NDwtB9zMVhpRPCqLB k+sMdyEWQHXQVvd2ilirjACPDDOm9gECl8ASxv9+oacdFGr0smpENvaYD4NXAxkliJP2RRKcoEV km7LK/aex5QbU5rsaaVBhBESRg4CUebR/KNmJcRX9N0/huu/alufeULY97WHUebGI3LpOU3itGw NYUE= X-Google-Smtp-Source: AGHT+IGMO5NilTQ/i8XjooFiGASJrvfFcSDr2VmmYPyU7LJt3JOcj+Z5vFGa9j6IQlSeom/a+LiTrg== X-Received: by 2002:a5d:6da6:0:b0:39d:724f:a8ec with SMTP id ffacd0b85a97d-39efbace5efmr1565326f8f.44.1744971048079; Fri, 18 Apr 2025 03:10:48 -0700 (PDT) Received: from mai.linaro.org (146725694.box.freepro.com. [130.180.211.218]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4406d5d69bbsm16142205e9.34.2025.04.18.03.10.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 18 Apr 2025 03:10:47 -0700 (PDT) Date: Fri, 18 Apr 2025 12:10:45 +0200 From: Daniel Lezcano To: Luca Ceresoli Cc: "Rafael J. Wysocki" , Zhang Rui , Lukasz Luba , Florian Fainelli , Ray Jui , Scott Branden , Broadcom internal kernel review list , Petr Mladek , Steven Rostedt , Andy Shevchenko , Rasmus Villemoes , Sergey Senozhatsky , Jonathan Corbet , Andrew Morton , Alex Shi , Yanteng Si , Binbin Zhou , Thomas Petazzoni , Michael Turquette , Stephen Boyd , Geert Uytterhoeven , Liu Ying , linux-clk@vger.kernel.org, linux-pm@vger.kernel.org, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org Subject: Re: [PATCH v2 0/2] vsprintf: remove redundant %pCn format specifier Message-ID: References: <20250311-vsprintf-pcn-v2-0-0af40fc7dee4@bootlin.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250311-vsprintf-pcn-v2-0-0af40fc7dee4@bootlin.com> On Tue, Mar 11, 2025 at 10:21:21AM +0100, Luca Ceresoli wrote: > There are two printk format specifiers for clocks: %pC and %pCn, and they > print exactly the same string. Geert confirmed the intended reason for > having two was that %pC would act as a default, like some (but not all) > formats do. However there seem to be no advantage in having two instead of > one, especially now that there is no other %pC specifier since commit > 666902e42fd8 ("lib/vsprintf: Remove atomic-unsafe support for %pCr"). > > Definitely having two without properly documenting they do the same creates > misunderstandings [0]. > > Since %pCn is used in a single place, replace it with %pC and remove %pCn > to simplify such format specifiers implementation and avoid > misunderstandings. > > [0] https://lore.kernel.org/dri-devel/f8df2b5e-b005-4ada-8108-159b2b94a72e@nxp.com/ > > Signed-off-by: Luca Ceresoli > --- Applied, thanks