From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EDF29288CC; Sat, 19 Apr 2025 07:51:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745049116; cv=none; b=SgF5zVN+6UCqL68HqnEt9Wu4yMsNlvNodnyyz27LLiZ/PbMcuJdVSZZIS78RM2yG02tJlvFNAmXd9kZl+k8aocKnw7OayV7Jyqe1GoSfWhwvu9yi+twR6vJ9Sos8AwsrOsAnTxH26FooAHgYgf38byGHuoK8SHIPjKW7vQkvQXA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745049116; c=relaxed/simple; bh=E25V98aVCwrCilbltTLlWt2+/aCJN7l5q9y98oKOc9o=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=pfCqYWEbThZPxfflwt080UfAShg77EDq2sZVpcFQWeHxRY+FaAFREZ8tIFetzFxpiBZ+Q94Dd+A7Z+pwwXrM2pVjnRnms53mHgX8xf/B6lllDJdPvUGfQGTul1pwfhwRjRsfJpGtPyiUglIcJYpyRj7ExN0RHi0ApVl9a89DhIA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=cBfoLQox; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="cBfoLQox" Received: by smtp.kernel.org (Postfix) with ESMTPSA id B03E2C4CEE7; Sat, 19 Apr 2025 07:51:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1745049115; bh=E25V98aVCwrCilbltTLlWt2+/aCJN7l5q9y98oKOc9o=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=cBfoLQoxO0nmDpeDfxZD4Hke/hxs26KgdXJXCEsaz/TXl8ohNPna2SWzdn7hfnCsJ otvtUAOIF/vf7nas6lNOc92rrG/gP33Tm1JMq9bH+CY6fSUQQHqTwzYIiI8pX1NgYg rWGVJsmAXOHYN2OaP1e4qCyzbbS94E8NOg2MGlADP7/5cJp+9NbfxWBVtAMsOXWibS 0xGGzQSen4+Al7XEInYTICel6ifyjdOcDSBS2s2Jwd+OVJYIV8R6kL814MeZ+OLeME g3E/weD77lKzJJGRhJlOZrdH/bWLNm3aqyxFEuaDp3rQmzBGLbWVOmtagrOJkjTr+0 BTM5Xum45YhhQ== Date: Sat, 19 Apr 2025 10:51:46 +0300 From: Mike Rapoport To: Yuquan Wang Cc: chenhuacai@kernel.org, kernel@xen0n.name, jiaxun.yang@flygoat.com, akpm@linux-foundation.org, david@redhat.com, Jonathan.Cameron@huawei.com, dave.hansen@linux.intel.com, dan.j.williams@intel.com, alison.schofield@intel.com, chenbaozi@phytium.com.cn, loongarch@lists.linux.dev, linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org, linux-cxl@vger.kernel.org Subject: Re: [PATCH 1/1] LoongArch: Introduce the numa_memblks conversion Message-ID: References: <20250409070250.3225839-1-wangyuquan1236@phytium.com.cn> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250409070250.3225839-1-wangyuquan1236@phytium.com.cn> Hi Yuquan, On Wed, Apr 09, 2025 at 03:02:50PM +0800, Yuquan Wang wrote: > "mm: introduce numa_memblks"(87482708210f) has moved numa_memblks > from x86 to the generic code, but loongarch was left out of this > conversion. > > This patch introduces the generic numa_memblks. > > Signed-off-by: Yuquan Wang > --- > > Background > ---------- > I am managed to land the patch[1] "mm: numa_memblks: introduce numa_add_reserved_memblk" > but kernel test CI noticed build errors[2] from loongarch64-linux-gcc. I think you can just add a dummy static inline numa_add_reserved_memblk() to arch/loongarch/include/asm/numa.h to fix the build. Then moving loongarch to numa_memblks won't be a stopper for your change. > Link: > [1]: https://lore.kernel.org/all/20250409040121.3212489-1-wangyuquan1236@phytium.com.cn/ > [2]: https://lore.kernel.org/all/202503282026.QNaOAK79-lkp@intel.com/ -- Sincerely yours, Mike.