From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: xiaopeitux@foxmail.com
Cc: linux-kernel@vger.kernel.org, f.fangjian@huawei.com,
robh@kernel.org, john.g.garry@oracle.com, xuwei5@hisilicon.com,
Pei Xiao <xiaopei01@kylinos.cn>
Subject: Re: [PATCH 2/2] logic_pio: Add detailed comments for find_io_range() and logic_pio_trans_cpuaddr()
Date: Sat, 19 Apr 2025 18:21:41 +0300 [thread overview]
Message-ID: <aAO_hdYdKW1_Z-T8@smile.fi.intel.com> (raw)
In-Reply-To: <tencent_CDDCEC54C190265E5927ED7353AE68116A08@qq.com>
On Fri, Apr 18, 2025 at 04:51:45PM +0800, xiaopeitux@foxmail.com wrote:
> From: Pei Xiao <xiaopei01@kylinos.cn>
>
> Add comments that we were previously overlooked for find_io_range()
> and logic_pio_trans_cpuaddr().
You haven't run definitely the kernel-doc validator. There are missing Return
sections. And even style for returned value description differs in two...
Also, you have an issue with your tools, the cover letter is detached from the
patches. Please, take your time and fix that.
--
With Best Regards,
Andy Shevchenko
prev parent reply other threads:[~2025-04-19 15:21 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <cover.1744964101.git.xiaopei01@kylinos.cn>
2025-04-18 8:51 ` [PATCH 1/2] bus: hisi_lpc: remove unused head file in hisi_lpc.c xiaopeitux
2025-04-19 8:01 ` kernel test robot
2025-04-19 15:22 ` Andy Shevchenko
2025-04-21 2:06 ` Pei Xiao
2025-04-22 7:58 ` Andy Shevchenko
2025-04-22 11:35 ` Pei Xiao
2025-04-21 11:34 ` kernel test robot
2025-04-18 8:51 ` [PATCH 2/2] logic_pio: Add detailed comments for find_io_range() and logic_pio_trans_cpuaddr() xiaopeitux
2025-04-19 15:21 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aAO_hdYdKW1_Z-T8@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=f.fangjian@huawei.com \
--cc=john.g.garry@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
--cc=xiaopei01@kylinos.cn \
--cc=xiaopeitux@foxmail.com \
--cc=xuwei5@hisilicon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox