Re: [PATCH v1 1/1] usb: Add checks for snprintf() calls in usb_alloc_dev()

[Andy Shevchenko <andy.shevchenko@gmail.com>]

Sun, Apr 20, 2025 at 08:27:59AM +0200, Greg Kroah-Hartman kirjoitti:
> On Sat, Apr 19, 2025 at 07:27:08PM +0300, Andy Shevchenko wrote:
> > On Fri, Mar 21, 2025 at 06:49:49PM +0200, Andy Shevchenko wrote:
> > > When creating a device path in the driver the snprintf() takes
> > > up to 16 characters long argument along with the additional up to
> > > 12 characters for the signed integer (as it can't see the actual limits)
> > > and tries to pack this into 16 bytes array. GCC complains about that
> > > when build with `make W=1`:
> > > 
> > >   drivers/usb/core/usb.c:705:25: note: ‘snprintf’ output between 3 and 28 bytes into a destination of size 16
> > > 
> > > Since everything works until now, let's just check for the potential
> > > buffer overflow and bail out. It is most likely a never happen situation,
> > > but at least it makes GCC happy.
> > 
> > Any comments anybody?
> 
> It's been added to my tree last week, 

Thank you!

> why comment again?

Ah, I missed that, too many emails lately. :-(

> confused,

-- 
With Best Regards,
Andy Shevchenko