RE: [PATCH v5 14/16] x86/bugs: Restructure SSB mitigation

Kaplan, David
2025-04-29T14:09:34Z

[AMD Official Use Only - AMD Internal Distribution Only]

> -----Original Message-----
> From: Borislav Petkov <bp@alien8.de>
> Sent: Tuesday, April 29, 2025 7:54 AM
> To: Kaplan, David <David.Kaplan@amd.com>
> Cc: Thomas Gleixner <tglx@linutronix.de>; Peter Zijlstra <peterz@infradead.org>;
> Josh Poimboeuf <jpoimboe@kernel.org>; Pawan Gupta
> <pawan.kumar.gupta@linux.intel.com>; Ingo Molnar <mingo@redhat.com>; Dave
> Hansen <dave.hansen@linux.intel.com>; x86@kernel.org; H . Peter Anvin
> <hpa@zytor.com>; linux-kernel@vger.kernel.org
> Subject: Re: [PATCH v5 14/16] x86/bugs: Restructure SSB mitigation
>
> Caution: This message originated from an External Source. Use proper caution
> when opening attachments, clicking links, or responding.
>
>
> On Fri, Apr 18, 2025 at 11:17:19AM -0500, David Kaplan wrote:
> > @@ -2224,19 +2226,18 @@ static enum ssb_mitigation_cmd __init
> ssb_parse_cmdline(void)
> > return cmd;
> > }
> >
> > -static enum ssb_mitigation __init __ssb_select_mitigation(void)
> > +static void ssb_select_mitigation(void)
>
> I don't think you meant to drop the __init section here ...
>

Yeah looks like a typo, my apologies. The prototype was correct and has the __init.

--David Kaplan