RE: [PATCH v5 03/16] x86/bugs: Restructure MMIO mitigation

Borislav Petkov
2025-04-26T11:23:21Z

On April 25, 2025 4:28:14 PM GMT+03:00, "Kaplan, David" <David.Kaplan@amd.com> wrote:
>It was the intent to imply that. If you look at patch 1, 2, and 4 then if verw_mitigation_selected is ever set to true, it means that some mitigation is going to force X86_FEATURE_CLEAR_CPU_BUF.

Aaaand the other shoe dropped...

>Maybe the solution here is to clarify the comment above verw_mitigation_selected that it is set if any of those 4 bugs are going to enable X86_FEATURE_CLEAR_CPU_BUF. So it implies that specific VERW-based mitigation.
>
>Or perhaps I could even rename the variable to be 'clear_cpu_buf_selected'?

Right, I think both should be the optimal thing as it would make it crystal clear.

>I think clarifying what verw_mitigation_selected means is better. When that becomes clear, I think that the existing comments make sense.
>

Ok, all clear.

But you don't have to resend an updated set - I'll fix that up while applying.

Thx.

--
Sent from a small device: formatting sucks and brevity is inevitable.