Re: [PATCH v5 16/16] x86/bugs: Restructure SRSO mitigation

Borislav Petkov
2025-04-30T08:25:44Z

On Tue, Apr 29, 2025 at 05:18:27PM +0000, Kaplan, David wrote:
> The comment doesn't make any sense in the new structure. In the old code,
> SBPB gets enabled at the start of the function, before we check if you're on
> a Zen1/2 with SMT off. The comment arguably made some sense in the old code
> because you're disabling SRSO mitigations but after you had done the SBPB
> check...but the comment is pointing out this is ok because these CPUs never
> support SBPB anyway. Normally, if SRSO is off, you try to use SBPB.

Ok, lemme add a note about that in the commit message.

Thx.

--
Regards/Gruss,
Boris.