Re: [PATCH v4 1/3] lib/vsprintf: Add support for generic FourCCs by extending %p4cc

Andy Shevchenko
2025-04-22T10:16:25Z

On Tue, Apr 22, 2025 at 10:43:59AM +0200, Geert Uytterhoeven wrote:
> On Tue, 22 Apr 2025 at 10:30, Aditya Garg <gargaditya08@live.com> wrote:
> > On 22-04-2025 01:37 pm, Geert Uytterhoeven wrote:
> > > On Tue, 8 Apr 2025 at 08:48, Aditya Garg <gargaditya08@live.com> wrote:

...

> > Originally, it was %p4cr (reverse-endian), but on the request of the
> > maintainers, it was changed to %p4cn.
>
> Ah, I found it[1]:
>
> | so, it needs more information that this mimics htonl() / ntohl() for
> networking.
>
> IMHO this does not mimic htonl(), as htonl() is a no-op on big-endian.
> while %p4ch and %p4cl yield different results on big-endian.
>
> > So here network means reverse of host, not strictly big-endian.
>
> Please don't call it "network byte order" if that does not have the same
> meaning as in the network subsystem.
>
> Personally, I like "%p4r" (reverse) more...
> (and "%p4ch" might mean human-readable ;-)

It will confuse the reader. h/r is not very established pair. If you really
wont see h/n, better to drop them completely for now then. Because I'm against
h/r pair.

> [1] https://lore.kernel.org/all/Z8B6DwcRbV-8D8GB@smile.fi.intel.com

--
With Best Regards,
Andy Shevchenko