Re: [PATCH 05/11] pmdomain: core: Use device_set_node() to assign the fwnode too

Ulf Hansson
2025-04-23T07:31:22Z

On Thu, 17 Apr 2025 at 22:56, Saravana Kannan <saravanak@google.com> wrote:
>
> On Thu, Apr 17, 2025 at 7:25 AM Ulf Hansson <ulf.hansson@linaro.org> wrote:
> >
> > Rather than just assigning the dev->of_node for the genpd's device, let's
> > use device_set_node() to make sure the fwnode gets assigned too. This is
> > needed to allow fw_devlink to work correctly, for example.
> >
> > Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
> > ---
> > drivers/pmdomain/core.c | 14 ++++++++++----
> > 1 file changed, 10 insertions(+), 4 deletions(-)
> >
> > diff --git a/drivers/pmdomain/core.c b/drivers/pmdomain/core.c
> > index da51a61a974c..3911d3e96626 100644
> > --- a/drivers/pmdomain/core.c
> > +++ b/drivers/pmdomain/core.c
> > @@ -2627,6 +2627,7 @@ static bool genpd_present(const struct generic_pm_domain *genpd)
> > int of_genpd_add_provider_simple(struct device_node *np,
> > struct generic_pm_domain *genpd)
> > {
> > + struct fwnode_handle *fwnode;
> > int ret;
> >
> > if (!np || !genpd)
> > @@ -2635,7 +2636,9 @@ int of_genpd_add_provider_simple(struct device_node *np,
> > if (!genpd_present(genpd))
> > return -EINVAL;
> >
> > - genpd->dev.of_node = np;
> > + fwnode = &np->fwnode;
>
> Use of_fwnode_handle() please.

Sure! Thanks for reviewing!

[...]

Kind regards
Uffe