Re: [PATCH v3 2/7] rust: alloc: add Vec::pop

Tamir Duberstein
2025-04-24T13:49:18Z

On Thu, Apr 24, 2025 at 7:48 AM Alice Ryhl <aliceryhl@google.com> wrote:
>
> On Wed, Apr 23, 2025 at 11:42:52AM -0400, Tamir Duberstein wrote:
> > On Tue, Apr 22, 2025 at 5:53 AM Alice Ryhl <aliceryhl@google.com> wrote:
> > >
> > > This introduces a basic method that our custom Vec is missing. I expect
> > > that it will be used in many places, but at the time of writing, Rust
> > > Binder has six calls to Vec::pop.
> > >
> > > Signed-off-by: Alice Ryhl <aliceryhl@google.com>
> >
> > Could this be written in terms of `remove`?
>
> The `remove` method has a lot of logic to move around elements, so I'm
> not sure we would want to do that.

Wouldn't we want `remove(len-1)` to avoid that logic anyhow?