Re: [PATCH 2/4] crypto: sun8i-ce-cipher - use crypto_skcipher_driver_name()

Herbert Xu
2025-04-28T11:39:47Z

On Fri, Apr 25, 2025 at 03:45:15PM +0300, Ovidiu Panait wrote:
> Use crypto_skcipher_driver_name() helper from <crypto/skcipher.h>, instead
> of accessing struct crypto_alg directly.
>
> Signed-off-by: Ovidiu Panait <ovidiu.panait.oss@gmail.com>
> ---
> drivers/crypto/allwinner/sun8i-ce/sun8i-ce-cipher.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/crypto/allwinner/sun8i-ce/sun8i-ce-cipher.c b/drivers/crypto/allwinner/sun8i-ce/sun8i-ce-cipher.c
> index 05f67661553c..f03a8fa7bfa2 100644
> --- a/drivers/crypto/allwinner/sun8i-ce/sun8i-ce-cipher.c
> +++ b/drivers/crypto/allwinner/sun8i-ce/sun8i-ce-cipher.c
> @@ -17,6 +17,7 @@
> #include <linux/io.h>
> #include <linux/pm_runtime.h>
> #include <crypto/scatterwalk.h>
> +#include <crypto/skcipher.h>
> #include <crypto/internal/des.h>
> #include <crypto/internal/skcipher.h>

If you include internal/skcipher.h, there is no need to include
skcipher.h.

There is no need to resend this as I'll just remove this hunk when
applying the patch.

Thanks,
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt