* sound/soc/qcom/sdw.c:93: warning: cannot understand function prototype: 'ret = sdw_enable_stream(sruntime); '
@ 2025-04-26 13:32 kernel test robot
2025-04-29 8:18 ` Krzysztof Kozlowski
0 siblings, 1 reply; 4+ messages in thread
From: kernel test robot @ 2025-04-26 13:32 UTC (permalink / raw)
To: Krzysztof Kozlowski; +Cc: oe-kbuild-all, linux-kernel, Mark Brown
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: 02ddfb981de88a2c15621115dd7be2431252c568
commit: db7e59e6a39a4d3d54ca8197c796557e6d480b0d ASoC: qcom: sc7280: Fix missing Soundwire runtime stream alloc
date: 6 months ago
config: sh-randconfig-002-20250426 (https://download.01.org/0day-ci/archive/20250426/202504262154.sBmNTrcB-lkp@intel.com/config)
compiler: sh4-linux-gcc (GCC) 12.4.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250426/202504262154.sBmNTrcB-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202504262154.sBmNTrcB-lkp@intel.com/
All warnings (new ones prefixed by >>):
>> sound/soc/qcom/sdw.c:93: warning: cannot understand function prototype: 'ret = sdw_enable_stream(sruntime); '
Kconfig warnings: (for reference only)
WARNING: unmet direct dependencies detected for GET_FREE_REGION
Depends on [n]: SPARSEMEM [=n]
Selected by [y]:
- RESOURCE_KUNIT_TEST [=y] && RUNTIME_TESTING_MENU [=y] && KUNIT [=y]
vim +93 sound/soc/qcom/sdw.c
d32bac9cb09cce Krzysztof Kozlowski 2023-11-28 52
0cbf1ecd8c4801 Stephan Gerhold 2022-12-31 53 int qcom_snd_sdw_prepare(struct snd_pcm_substream *substream,
0cbf1ecd8c4801 Stephan Gerhold 2022-12-31 54 struct sdw_stream_runtime *sruntime,
0cbf1ecd8c4801 Stephan Gerhold 2022-12-31 55 bool *stream_prepared)
0cbf1ecd8c4801 Stephan Gerhold 2022-12-31 56 {
77678a25d1ecf7 Krzysztof Kozlowski 2024-04-30 57 struct snd_soc_pcm_runtime *rtd = snd_soc_substream_to_rtd(substream);
9b1a2dfa8a00ff Kuninori Morimoto 2023-09-11 58 struct snd_soc_dai *cpu_dai = snd_soc_rtd_to_cpu(rtd, 0);
0cbf1ecd8c4801 Stephan Gerhold 2022-12-31 59 int ret;
0cbf1ecd8c4801 Stephan Gerhold 2022-12-31 60
0cbf1ecd8c4801 Stephan Gerhold 2022-12-31 61 if (!sruntime)
0cbf1ecd8c4801 Stephan Gerhold 2022-12-31 62 return 0;
0cbf1ecd8c4801 Stephan Gerhold 2022-12-31 63
0cbf1ecd8c4801 Stephan Gerhold 2022-12-31 64 switch (cpu_dai->id) {
0cbf1ecd8c4801 Stephan Gerhold 2022-12-31 65 case WSA_CODEC_DMA_RX_0:
0cbf1ecd8c4801 Stephan Gerhold 2022-12-31 66 case WSA_CODEC_DMA_RX_1:
0cbf1ecd8c4801 Stephan Gerhold 2022-12-31 67 case RX_CODEC_DMA_RX_0:
0cbf1ecd8c4801 Stephan Gerhold 2022-12-31 68 case RX_CODEC_DMA_RX_1:
0cbf1ecd8c4801 Stephan Gerhold 2022-12-31 69 case TX_CODEC_DMA_TX_0:
0cbf1ecd8c4801 Stephan Gerhold 2022-12-31 70 case TX_CODEC_DMA_TX_1:
0cbf1ecd8c4801 Stephan Gerhold 2022-12-31 71 case TX_CODEC_DMA_TX_2:
0cbf1ecd8c4801 Stephan Gerhold 2022-12-31 72 case TX_CODEC_DMA_TX_3:
0cbf1ecd8c4801 Stephan Gerhold 2022-12-31 73 break;
0cbf1ecd8c4801 Stephan Gerhold 2022-12-31 74 default:
0cbf1ecd8c4801 Stephan Gerhold 2022-12-31 75 return 0;
0cbf1ecd8c4801 Stephan Gerhold 2022-12-31 76 }
0cbf1ecd8c4801 Stephan Gerhold 2022-12-31 77
e2e53088635924 Srinivas Kandagatla 2023-03-23 78 if (*stream_prepared)
e2e53088635924 Srinivas Kandagatla 2023-03-23 79 return 0;
0cbf1ecd8c4801 Stephan Gerhold 2022-12-31 80
0cbf1ecd8c4801 Stephan Gerhold 2022-12-31 81 ret = sdw_prepare_stream(sruntime);
0cbf1ecd8c4801 Stephan Gerhold 2022-12-31 82 if (ret)
0cbf1ecd8c4801 Stephan Gerhold 2022-12-31 83 return ret;
0cbf1ecd8c4801 Stephan Gerhold 2022-12-31 84
0cbf1ecd8c4801 Stephan Gerhold 2022-12-31 85 /**
0cbf1ecd8c4801 Stephan Gerhold 2022-12-31 86 * NOTE: there is a strict hw requirement about the ordering of port
0cbf1ecd8c4801 Stephan Gerhold 2022-12-31 87 * enables and actual WSA881x PA enable. PA enable should only happen
0cbf1ecd8c4801 Stephan Gerhold 2022-12-31 88 * after soundwire ports are enabled if not DC on the line is
0cbf1ecd8c4801 Stephan Gerhold 2022-12-31 89 * accumulated resulting in Click/Pop Noise
0cbf1ecd8c4801 Stephan Gerhold 2022-12-31 90 * PA enable/mute are handled as part of codec DAPM and digital mute.
0cbf1ecd8c4801 Stephan Gerhold 2022-12-31 91 */
0cbf1ecd8c4801 Stephan Gerhold 2022-12-31 92
0cbf1ecd8c4801 Stephan Gerhold 2022-12-31 @93 ret = sdw_enable_stream(sruntime);
0cbf1ecd8c4801 Stephan Gerhold 2022-12-31 94 if (ret) {
0cbf1ecd8c4801 Stephan Gerhold 2022-12-31 95 sdw_deprepare_stream(sruntime);
0cbf1ecd8c4801 Stephan Gerhold 2022-12-31 96 return ret;
0cbf1ecd8c4801 Stephan Gerhold 2022-12-31 97 }
0cbf1ecd8c4801 Stephan Gerhold 2022-12-31 98 *stream_prepared = true;
0cbf1ecd8c4801 Stephan Gerhold 2022-12-31 99
0cbf1ecd8c4801 Stephan Gerhold 2022-12-31 100 return ret;
0cbf1ecd8c4801 Stephan Gerhold 2022-12-31 101 }
0cbf1ecd8c4801 Stephan Gerhold 2022-12-31 102 EXPORT_SYMBOL_GPL(qcom_snd_sdw_prepare);
0cbf1ecd8c4801 Stephan Gerhold 2022-12-31 103
:::::: The code at line 93 was first introduced by commit
:::::: 0cbf1ecd8c4801ec7566231491f7ad9cec31098b ASoC: qcom: Fix building APQ8016 machine driver without SOUNDWIRE
:::::: TO: Stephan Gerhold <stephan@gerhold.net>
:::::: CC: Mark Brown <broonie@kernel.org>
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: sound/soc/qcom/sdw.c:93: warning: cannot understand function prototype: 'ret = sdw_enable_stream(sruntime); '
2025-04-26 13:32 sound/soc/qcom/sdw.c:93: warning: cannot understand function prototype: 'ret = sdw_enable_stream(sruntime); ' kernel test robot
@ 2025-04-29 8:18 ` Krzysztof Kozlowski
2025-04-30 6:43 ` Geert Uytterhoeven
0 siblings, 1 reply; 4+ messages in thread
From: Krzysztof Kozlowski @ 2025-04-29 8:18 UTC (permalink / raw)
To: kernel test robot; +Cc: oe-kbuild-all, linux-kernel, Mark Brown
On 26/04/2025 15:32, kernel test robot wrote:
> tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
> head: 02ddfb981de88a2c15621115dd7be2431252c568
> commit: db7e59e6a39a4d3d54ca8197c796557e6d480b0d ASoC: qcom: sc7280: Fix missing Soundwire runtime stream alloc
> date: 6 months ago
> config: sh-randconfig-002-20250426 (https://download.01.org/0day-ci/archive/20250426/202504262154.sBmNTrcB-lkp@intel.com/config)
> compiler: sh4-linux-gcc (GCC) 12.4.0
> reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250426/202504262154.sBmNTrcB-lkp@intel.com/reproduce)
>
> If you fix the issue in a separate patch/commit (i.e. not just a new version of
> the same patch/commit), kindly add following tags
> | Reported-by: kernel test robot <lkp@intel.com>
> | Closes: https://lore.kernel.org/oe-kbuild-all/202504262154.sBmNTrcB-lkp@intel.com/
>
> All warnings (new ones prefixed by >>):
>
>>> sound/soc/qcom/sdw.c:93: warning: cannot understand function prototype: 'ret = sdw_enable_stream(sruntime); '
This looks like compiler issue. I check the config and SOUNDWIRE is
selected thus sdw_enable_stream() is reachable. I also cannot reproduce
it sh4-linux-gnu-gcc v14.2.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: sound/soc/qcom/sdw.c:93: warning: cannot understand function prototype: 'ret = sdw_enable_stream(sruntime); '
2025-04-29 8:18 ` Krzysztof Kozlowski
@ 2025-04-30 6:43 ` Geert Uytterhoeven
2025-04-30 7:49 ` Philip Li
0 siblings, 1 reply; 4+ messages in thread
From: Geert Uytterhoeven @ 2025-04-30 6:43 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: kernel test robot, oe-kbuild-all, linux-kernel, Mark Brown
On Tue, 29 Apr 2025 at 10:18, Krzysztof Kozlowski <krzk@kernel.org> wrote:
> On 26/04/2025 15:32, kernel test robot wrote:
> > tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
> > head: 02ddfb981de88a2c15621115dd7be2431252c568
> > commit: db7e59e6a39a4d3d54ca8197c796557e6d480b0d ASoC: qcom: sc7280: Fix missing Soundwire runtime stream alloc
> > date: 6 months ago
> > config: sh-randconfig-002-20250426 (https://download.01.org/0day-ci/archive/20250426/202504262154.sBmNTrcB-lkp@intel.com/config)
> > compiler: sh4-linux-gcc (GCC) 12.4.0
> > reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250426/202504262154.sBmNTrcB-lkp@intel.com/reproduce)
> >
> > If you fix the issue in a separate patch/commit (i.e. not just a new version of
> > the same patch/commit), kindly add following tags
> > | Reported-by: kernel test robot <lkp@intel.com>
> > | Closes: https://lore.kernel.org/oe-kbuild-all/202504262154.sBmNTrcB-lkp@intel.com/
> >
> > All warnings (new ones prefixed by >>):
> >
> >>> sound/soc/qcom/sdw.c:93: warning: cannot understand function prototype: 'ret = sdw_enable_stream(sruntime); '
>
> This looks like compiler issue. I check the config and SOUNDWIRE is
> selected thus sdw_enable_stream() is reachable. I also cannot reproduce
> it sh4-linux-gnu-gcc v14.2.
I also couldn't reproduce it, using the specified commit ID and
the reproducer instructions, with gcc versions 12.3.0 (Ubuntu
12.3.0-17ubuntu1) and 13.3.0 (Ubuntu 13.3.0-6ubuntu2~24.04).
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: sound/soc/qcom/sdw.c:93: warning: cannot understand function prototype: 'ret = sdw_enable_stream(sruntime); '
2025-04-30 6:43 ` Geert Uytterhoeven
@ 2025-04-30 7:49 ` Philip Li
0 siblings, 0 replies; 4+ messages in thread
From: Philip Li @ 2025-04-30 7:49 UTC (permalink / raw)
To: Geert Uytterhoeven
Cc: Krzysztof Kozlowski, kernel test robot, oe-kbuild-all,
linux-kernel, Mark Brown
On Wed, Apr 30, 2025 at 08:43:55AM +0200, Geert Uytterhoeven wrote:
> On Tue, 29 Apr 2025 at 10:18, Krzysztof Kozlowski <krzk@kernel.org> wrote:
> > On 26/04/2025 15:32, kernel test robot wrote:
> > > tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
> > > head: 02ddfb981de88a2c15621115dd7be2431252c568
> > > commit: db7e59e6a39a4d3d54ca8197c796557e6d480b0d ASoC: qcom: sc7280: Fix missing Soundwire runtime stream alloc
> > > date: 6 months ago
> > > config: sh-randconfig-002-20250426 (https://download.01.org/0day-ci/archive/20250426/202504262154.sBmNTrcB-lkp@intel.com/config)
> > > compiler: sh4-linux-gcc (GCC) 12.4.0
> > > reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250426/202504262154.sBmNTrcB-lkp@intel.com/reproduce)
> > >
> > > If you fix the issue in a separate patch/commit (i.e. not just a new version of
> > > the same patch/commit), kindly add following tags
> > > | Reported-by: kernel test robot <lkp@intel.com>
> > > | Closes: https://lore.kernel.org/oe-kbuild-all/202504262154.sBmNTrcB-lkp@intel.com/
> > >
> > > All warnings (new ones prefixed by >>):
> > >
> > >>> sound/soc/qcom/sdw.c:93: warning: cannot understand function prototype: 'ret = sdw_enable_stream(sruntime); '
> >
> > This looks like compiler issue. I check the config and SOUNDWIRE is
> > selected thus sdw_enable_stream() is reachable. I also cannot reproduce
> > it sh4-linux-gnu-gcc v14.2.
>
> I also couldn't reproduce it, using the specified commit ID and
> the reproducer instructions, with gcc versions 12.3.0 (Ubuntu
> 12.3.0-17ubuntu1) and 13.3.0 (Ubuntu 13.3.0-6ubuntu2~24.04).
Sorry for the false positive, it does appear during the bisection process and
results in this first bad commit, which could be related to kernel-doc.
But fail to reproduce it now as well on gcc-12.4. We will follow up to further
check the bisection process and reproduce steps.
>
> Gr{oetje,eeting}s,
>
> Geert
>
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
>
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
> -- Linus Torvalds
>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2025-04-30 7:50 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-04-26 13:32 sound/soc/qcom/sdw.c:93: warning: cannot understand function prototype: 'ret = sdw_enable_stream(sruntime); ' kernel test robot
2025-04-29 8:18 ` Krzysztof Kozlowski
2025-04-30 6:43 ` Geert Uytterhoeven
2025-04-30 7:49 ` Philip Li
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox