From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (mail-mw2nam12on2069.outbound.protection.outlook.com [40.107.244.69]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6152820E718; Wed, 30 Apr 2025 07:59:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.244.69 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745999953; cv=fail; b=AZongcEe7F1E+noyahvb17CvTf1YHujz1YNKUtiF626raRytj011cwN4Mmn+IIlRuDW5bIqcsbgs70YgKMLMVBcD5tWQmqPhnEyv3itapgGf3w3+2smooLeLTxaH7w2cVBGLru/H60PJ5vQ1XBvST+Cb7QyRmARo+eURpLPpoW8= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745999953; c=relaxed/simple; bh=JzYQPm23qNrPRXnaS9iezKcDBviQLGtKKZ/5TfP/LFA=; h=Date:From:To:CC:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=keVJc8v4vr5b4wQf8Nwa7D549tyZoBcvtIX8P3a3MRJIFXusKU4/E8tb5vbttHr8Lo+WZS4INkA9N/v5D43W5qXYepH3llOS3/cppdxrjMWzmVuGvuA2cX9YR3n+xyMiTzBUFZoZL+L+HRaBpezPmWKxgZ18TwzDfww+5qxYiPw= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com; spf=fail smtp.mailfrom=nvidia.com; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b=b9M5/d/Q; arc=fail smtp.client-ip=40.107.244.69 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=nvidia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b="b9M5/d/Q" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=RPxI9y2+PN+PWcdUmj/WrZNZDiSCYycci3ool92mEmwlTlnz9/EcwGP7bPcLtXANJqshtwQj/hH42Pu54VKz//qI8XO9P11VsnpvQ3bcBopk14BEE3FLNAdIYIH7cLZ4UFFCsILRI7wVmyygbe9SUbqblCGYnlo2S4jLXscpLFvSIQ0D8E5a7ud4YuqeXtmdETeDFZBRK+i6VhSb+TsZAxjTQtk54ad9KRbUklv3eqM5zzUSmiobLB+GPbIVPDE9R7nPNmmZCjJrnLVr8l3wXmaXo6M1WtJ7cV9R6wi2jDPEVApovtJT726wQuW0DgLvils2/GEpCGpurdWjlwVzoA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=gQKujtkdZylL6trpnmxecIheT4dPO86t6oMqcG3RmN8=; b=VyA4A+KDHXeT7nojcrysprndF5g8gK/+THNA06KZ6dgVJwnthpZxGzSZHiFRURKTz9ozzx3FFZum7mc4/9fQAEbGPXw46WYLbEkG0+yti66foz1ElU7ACdL8SB+G8vqSTFvdvi0ONaYoLe+AuqUSz7mnDiXolIsDmbmp7CLowygkZybnL3PftCFgH2Wit864Oa6Zt5DbqsQfwDLQC76l9+6t/bVZfyaNs2QARlQfmzSyb5TnN+RYyqq54PDsfUlmPHznXhDEqyAfV0cnwf3ENvJtV+vSgAE87D+Q9HAlGsj/QHFqVRnTmO5hh5YEJtMaSAV4vhCZCOsyKJSC6uriQQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.118.233) smtp.rcpttodomain=amd.com smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=gQKujtkdZylL6trpnmxecIheT4dPO86t6oMqcG3RmN8=; b=b9M5/d/QNMvUI2EU2HCC+22WX8Zv07BwRpovXhh9jDgsaYm1EPzF0oca67E9+5+Wy1FvcVkAFaDgR4DZRISk+TdtKgmS2QQLchQbq+BjguncA46+7I5x/vWP+/khdCr0jc+sNm7Jh0ffRZGDY3toJU1tjFdhnPJKHgFZSfnjtiBpjTtborRONBJu50nnGZLQ8WnVRPuvhkEv6+S21emkAeX7QBxiceBgDV0zwNpsmx3IX2RkPp5JhB0QCcqJEfwwXWt2mRMI4A19V2gY+t10YMP31AM1WX6sLQ8Dz07qUmrBQqkoC8R4/dOYz6z/EpiP1gTtv9wMyd7PUjoN9IpC+Q== Received: from PH3PEPF000040AC.namprd05.prod.outlook.com (2603:10b6:518:1::5b) by PH7PR12MB9102.namprd12.prod.outlook.com (2603:10b6:510:2f8::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8678.31; Wed, 30 Apr 2025 07:59:07 +0000 Received: from SA2PEPF000015CC.namprd03.prod.outlook.com (2a01:111:f403:c801::5) by PH3PEPF000040AC.outlook.office365.com (2603:1036:903:49::3) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.8655.33 via Frontend Transport; Wed, 30 Apr 2025 07:59:07 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.118.233) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.118.233 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.118.233; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.118.233) by SA2PEPF000015CC.mail.protection.outlook.com (10.167.241.202) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8699.20 via Frontend Transport; Wed, 30 Apr 2025 07:59:06 +0000 Received: from drhqmail202.nvidia.com (10.126.190.181) by mail.nvidia.com (10.127.129.6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.4; Wed, 30 Apr 2025 00:58:51 -0700 Received: from drhqmail202.nvidia.com (10.126.190.181) by drhqmail202.nvidia.com (10.126.190.181) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.14; Wed, 30 Apr 2025 00:58:50 -0700 Received: from Asurada-Nvidia (10.127.8.14) by mail.nvidia.com (10.126.190.181) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.14 via Frontend Transport; Wed, 30 Apr 2025 00:58:49 -0700 Date: Wed, 30 Apr 2025 00:58:47 -0700 From: Nicolin Chen To: Alexey Kardashevskiy CC: Jason Gunthorpe , , , , , , , , , , , , , , , , , , , Subject: Re: [PATCH v2 06/19] iommufd/viommu: Add IOMMU_VIOMMU_SET/UNSET_VDEV_ID ioctl Message-ID: References: <6348cc7a72ce9f2ac0e9caf9737e70177a01eb74.1724776335.git.nicolinc@nvidia.com> <35701c5e-030a-4f52-b6f6-ed18368fb2cd@amd.com> <20241004114147.GF1365916@nvidia.com> <95ab62fa-bb1c-4e4a-a210-b0bdba0d4ad2@amd.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <95ab62fa-bb1c-4e4a-a210-b0bdba0d4ad2@amd.com> X-NV-OnPremToCloud: AnonymousSubmission X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SA2PEPF000015CC:EE_|PH7PR12MB9102:EE_ X-MS-Office365-Filtering-Correlation-Id: 8563886d-54c0-46d2-30ff-08dd87bce1d7 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|82310400026|1800799024|36860700013|7416014|376014; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?o/E8uGl4ZNFothA62QZTkeoxQ6YqIwHHQhkYvfLN+qTWIXjW8i1Iwf6tjN9C?= =?us-ascii?Q?179Ni7rP+X237J3fLF9CnV/7VxYncpw3FvX2mguNAHrzUaCqeBH5zT6At/XD?= =?us-ascii?Q?tFfCWY/AJ8mYaSIgRp1070c7/8Gs5U5+E/rxTY3YLjfi3EQR53IKyp27qiGY?= =?us-ascii?Q?KyfJ4fFM2jwjElapFmtHD0zh37QZaCzHj622Ywt3YKZhbfHx/DOiALl7Ni/q?= =?us-ascii?Q?nV7G785dh6x/rmrLK/mbxM5exYOjl/YQjZnBbwXqGsujbvuBQaV6xFz4r70q?= =?us-ascii?Q?8eoU87TfcqwHt+xcNvQWyiz6HEtIZ4ysSOuGnFNLEDXC+sD4Y8plGGtRjfNa?= =?us-ascii?Q?/6NlI2BdYoPAGLPI6RVimz/AukMpEUVrWBnPJfPo+tFFA6vjvuKAbe68ybPb?= =?us-ascii?Q?12EDwIvLIQ38HjeEeC71eU4KKKj6hWN/OM3qQWYoQ+VSvWp6lBDvmfkE1ggx?= =?us-ascii?Q?FYj858txHyDuikxeR99aSZXC83wM6hGv189Z0y0AQVLD1Yxm9bRVmAfHrhC2?= =?us-ascii?Q?QgOk2hjoNgG0btzIllF4M/5fzJyCGL8zN0uavL9wiUYMBNL8/+I0xrxxoI9e?= =?us-ascii?Q?/Kcr3+LLOs9PbeXlqX6OTjiZWn6S61ZJoaNDvfGS0ahjHbSvQsAwk4Jqqit8?= =?us-ascii?Q?Gt7ttPXucx3xjGBJ4Z53FB4ZA3PeaL84OlC5fJrCyC58W93qBkjXOk4cD268?= =?us-ascii?Q?DhGNCc+lfgZogqbu5uBNYLG7dxB2TDAEM9LJcDr2REmrg6zg56P/GTdvgfE7?= =?us-ascii?Q?5W0UrJHlrLzamvxr8RO5L7mJLuUI+koChaFl9vpACDfENdSCcVsUTGCO6Av6?= =?us-ascii?Q?wMQN6ZxItSSauIVZW4Hv7btXYKC8hdV42WqixvI25dqVWzBkoMfS/IXTMHUA?= =?us-ascii?Q?GIVkxs/kxvVsLGX8JsS7aPGWbQXXdDlvlQO7rfQeLY2VcU+kR7hoESmBYS/r?= =?us-ascii?Q?SsTLkGq85NUcV2f6FxQuOpjAxduFS7w+sFT1DLJAk2F2csdiYg/q96BOZWxP?= =?us-ascii?Q?G0PCGMlYTehpBELFq3EWNkXC1YWaaRkx/PrswL/deBxC2BM/atTHRGOopE8i?= =?us-ascii?Q?PFirJ4cf26/hKfmdwTRONWVDJErQuI6xn5p65HcttA+Ld5NeIts66AHf/cia?= =?us-ascii?Q?K6R6uqYztV95iCbKNPoAJxn8XSA+PF2kdOXTxNnlE1m0wxYxyepjGcV7hDSI?= =?us-ascii?Q?x+uk7jd0s2xRXQb9znzvfMZfxM+eg671Qv+57C9d4MVXr+FHLtxWMy9PL/s6?= =?us-ascii?Q?RUzkhbt7H6TrBudALrojI96VmSJeg1yM5tE9VWIQSBwUwWnlpJ5Bya3b5H6v?= =?us-ascii?Q?+BVObBrrlxbcDY8ZaZ4LS6Ccs9K/U9mUuWrnHcemvhkXEFwbFH8f3BewmNLD?= =?us-ascii?Q?uiEdpd9CXeeSuOO97TDzgvRXCo8C3Nmj1FUhevs5v6SgaQ84RjDjJwz7nQ9G?= =?us-ascii?Q?0+ZDA/UhdiO+24Gff99msH8A9z7tQ2anLjNhoLCfAjaCJiHrqfmWmRegtDpl?= =?us-ascii?Q?4/8nc2EynwKNwW/kF/AuK1nb04GvcyLumabh?= X-Forefront-Antispam-Report: CIP:216.228.118.233;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:mail.nvidia.com;PTR:dc7edge2.nvidia.com;CAT:NONE;SFS:(13230040)(82310400026)(1800799024)(36860700013)(7416014)(376014);DIR:OUT;SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Apr 2025 07:59:06.7762 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 8563886d-54c0-46d2-30ff-08dd87bce1d7 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a;Ip=[216.228.118.233];Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: SA2PEPF000015CC.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR12MB9102 On Wed, Apr 30, 2025 at 05:54:53PM +1000, Alexey Kardashevskiy wrote: > On 4/10/24 21:41, Jason Gunthorpe wrote: > > On Fri, Oct 04, 2024 at 02:32:28PM +1000, Alexey Kardashevskiy wrote: > > > > > > + __u32 __reserved; > > > > + __aligned_u64 vdev_id; > > I believe this ended up being "virt_id"... Yes. > > > > > > What is the nature of this id? > > > > It should be the vIOMMU's HW representation for the virtual device. > > > > On ARM it is the stream id, the index into the Stream Table > > > > On AMD it would be the "DeviceID" the index in the Device Table > > > ... and I just hit a problem with it - this is basically guest BDFn > and it works as long as I'm hotplugging the TEE-IO VF into an SNP VM > but does not when I pass through via the QEMU cmdline - bus numbers > are not assigned yet. So I have to postpone the vdevice allocation > till run time, did I miss something here? Thanks, I have a similar case with QEMU ARM64's VM: so vDEVICE on ARM is allocated at runtime as well because the BDF number isn't ready at the boot time. Nicolin