Re: [REPOST PATCH] virt: acrn: Remove unused list 'acrn_irqfd_clients'

["Dr. David Alan Gilbert" <linux@treblig.org>]

* Greg KH (gregkh@linuxfoundation.org) wrote:
> On Wed, Apr 30, 2025 at 01:36:23AM +0100, linux@treblig.org wrote:
> > From: "Dr. David Alan Gilbert" <linux@treblig.org>
> > 
> > It doesn't look like this was ever used.
> > 
> > Build tested only.
> > 
> > Signed-off-by: Dr. David Alan Gilbert <linux@treblig.org>
> > Acked-by: Fei Li <fei1.li@intel.com>
> > ---
> > This is a repost of the patch originally posted last in May
> > last year as id 20240504174725.93495-1-linux@treblig.org and
> > Ack'd by Fei Li on 20th May, in Zkq183IzBA6cV9FE@louislifei-OptiPlex-7090
> > No one picked it up.
> > (Fixed one typo in the subject line)
> > 
> >  drivers/virt/acrn/irqfd.c | 2 --
> >  1 file changed, 2 deletions(-)
> > 
> > diff --git a/drivers/virt/acrn/irqfd.c b/drivers/virt/acrn/irqfd.c
> > index b7da24ca1475..64d32c8fbf79 100644
> > --- a/drivers/virt/acrn/irqfd.c
> > +++ b/drivers/virt/acrn/irqfd.c
> > @@ -16,8 +16,6 @@
> >  
> >  #include "acrn_drv.h"
> >  
> > -static LIST_HEAD(acrn_irqfd_clients);
> > -
> 
> Odd, why doesn't the compiler complain about this?

Because it is used - by its own initialiser!
I filed a gcc bug for it:
  https://gcc.gnu.org/bugzilla/show_bug.cgi?id=115027
and someone has written a patch but it hasn't gone further.

> I'll queue it up in a bit, thanks!

Thanks!

Dave

> greg k-h
-- 
 -----Open up your eyes, open up your mind, open up your code -------   
/ Dr. David Alan Gilbert    |       Running GNU/Linux       | Happy  \ 
\        dave @ treblig.org |                               | In Hex /
 \ _________________________|_____ http://www.treblig.org   |_______/