linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jarkko Sakkinen <jarkko@kernel.org>
To: Stuart Yoder <stuart.yoder@arm.com>
Cc: linux-integrity@vger.kernel.org, peterhuewe@gmx.de, jgg@ziepe.ca,
	sudeep.holla@arm.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] tpm_crb: ffa_tpm: fix cut/paste error in comment
Date: Wed, 30 Apr 2025 18:32:10 +0300	[thread overview]
Message-ID: <aBJCeoapwgdaPONq@kernel.org> (raw)
In-Reply-To: <20250429221519.1022170-1-stuart.yoder@arm.com>

On Tue, Apr 29, 2025 at 05:15:17PM -0500, Stuart Yoder wrote:
> Fix the comment for the 'start' function, which was a cut/paste
> mistake for a different function.
> 
> Signed-off-by: Stuart Yoder <stuart.yoder@arm.com>
> ---
>  drivers/char/tpm/tpm_crb_ffa.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/char/tpm/tpm_crb_ffa.c b/drivers/char/tpm/tpm_crb_ffa.c
> index 3169a87a56b60..65b01a46d4b88 100644
> --- a/drivers/char/tpm/tpm_crb_ffa.c
> +++ b/drivers/char/tpm/tpm_crb_ffa.c
> @@ -68,7 +68,8 @@
>  #define CRB_FFA_GET_INTERFACE_VERSION 0x0f000001
>  
>  /*
> - * Return information on a given feature of the TPM service
> + * Notifies the TPM service that a TPM command or TPM locality request is
> + * ready to be processed, and allows the TPM service to process it.
>   * Call register usage:
>   * w3:    Not used (MBZ)
>   * w4:    TPM service function ID, CRB_FFA_START
> -- 
> 2.34.1
> 

Can you squash the comment updates into single patch instead and
enumerate the changes? Does not really serve any purpose because
comments do not "run".

BR, Jarkko

  parent reply	other threads:[~2025-04-30 15:32 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-04-29 22:15 [PATCH 1/2] tpm_crb: ffa_tpm: fix cut/paste error in comment Stuart Yoder
2025-04-29 22:15 ` [PATCH] tpm_crb: ffa_tpm: update comment to include 64-bit calling convention Stuart Yoder
2025-04-29 22:15 ` [PATCH 2/2] " Stuart Yoder
2025-04-30 15:32 ` Jarkko Sakkinen [this message]
2025-04-30 15:33   ` [PATCH 1/2] tpm_crb: ffa_tpm: fix cut/paste error in comment Stuart Yoder

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aBJCeoapwgdaPONq@kernel.org \
    --to=jarkko@kernel.org \
    --cc=jgg@ziepe.ca \
    --cc=linux-integrity@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=peterhuewe@gmx.de \
    --cc=stuart.yoder@arm.com \
    --cc=sudeep.holla@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).