From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 035E125525E for ; Fri, 2 May 2025 13:39:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746193167; cv=none; b=ksoSFJt731OUWv3shDAvCKE792YdyKi+m8PuSDRiH8KGNZopHaI3ra82fLXny7miYkeT+i80mODxLXKHv0pBJAE1u97+k03qDxttQt1s5jzs1iaJZOeIVn81dUnxp+4liVOG9YfMlbogkwyutSzJEvviGa+Vo6eLSkVc+0z0w/c= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746193167; c=relaxed/simple; bh=ei9NJ049uGIX5yQhrHbMy78H/I6x/HWbcZ6Sft85qyc=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Ag7Jyfoy+qCc1DtOZ4+DCAnkHmJk2Rk7RRk5O42iDMrLg11cU9OtJe5BSTyH88IaAwPDInsJCk3CL2HvXvh4LxxJ3AlRozG2H3Sv3qe5CFl4yNAkUqvolH5TkzGWEPGC2/b0Yc65UIbkP572b1+SqF5+pLgtNKu1+/ggPspMghw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=DTFfkXyh; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="DTFfkXyh" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1746193164; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=K0hWQbEiVuqrU1ymk0jKVlMwDBtK6gb14Cqvrvj+pXI=; b=DTFfkXyhTOC0ocpw/AvKnMByHTuZbALOv3ST8nnOx02OlvU+VbcxKIX2ryS6qgVET4nSXL gqAaXgw0Z8gu7ZlZpQhPWuSOuOKtkUeAKtenNkFz+cjF6XAgGDnqevddo+nCGG6g6m5wnX geOCYPcQCKgQuTXf45PVHQ3Mtoo7K+s= Received: from mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-680-6xq3AcOBM7mdk4HaYssYfg-1; Fri, 02 May 2025 09:39:19 -0400 X-MC-Unique: 6xq3AcOBM7mdk4HaYssYfg-1 X-Mimecast-MFC-AGG-ID: 6xq3AcOBM7mdk4HaYssYfg_1746193158 Received: from mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.15]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id DDC60180087A; Fri, 2 May 2025 13:39:17 +0000 (UTC) Received: from fedora (unknown [10.72.116.6]) by mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 6A41A1956094; Fri, 2 May 2025 13:39:13 +0000 (UTC) Date: Fri, 2 May 2025 21:39:08 +0800 From: Ming Lei To: Caleb Sander Mateos Cc: Jens Axboe , Uday Shankar , linux-block@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 4/9] ublk: take const ubq pointer in ublk_get_iod() Message-ID: References: <20250430225234.2676781-1-csander@purestorage.com> <20250430225234.2676781-5-csander@purestorage.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250430225234.2676781-5-csander@purestorage.com> X-Scanned-By: MIMEDefang 3.0 on 10.30.177.15 On Wed, Apr 30, 2025 at 04:52:29PM -0600, Caleb Sander Mateos wrote: > ublk_get_iod() doesn't modify the struct ublk_queue it is passed. > Clarify that by making the argument a const pointer. > > Move the function definition earlier in the file so it doesn't need a > forward declaration. > > Signed-off-by: Caleb Sander Mateos Reviewed-by: Ming Lei thanks, Ming