From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: Mathieu Dubois-Briand <mathieu.dubois-briand@bootlin.com>
Cc: "Lee Jones" <lee@kernel.org>, "Rob Herring" <robh@kernel.org>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
"Conor Dooley" <conor+dt@kernel.org>,
"Kamel Bouhara" <kamel.bouhara@bootlin.com>,
"Linus Walleij" <linus.walleij@linaro.org>,
"Bartosz Golaszewski" <brgl@bgdev.pl>,
"Dmitry Torokhov" <dmitry.torokhov@gmail.com>,
"Uwe Kleine-König" <ukleinek@kernel.org>,
"Michael Walle" <mwalle@kernel.org>,
"Mark Brown" <broonie@kernel.org>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Rafael J. Wysocki" <rafael@kernel.org>,
"Danilo Krummrich" <dakr@kernel.org>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-gpio@vger.kernel.org, linux-input@vger.kernel.org,
linux-pwm@vger.kernel.org,
"Grégory Clement" <gregory.clement@bootlin.com>,
"Thomas Petazzoni" <thomas.petazzoni@bootlin.com>
Subject: Re: [PATCH v7 10/11] input: misc: Add support for MAX7360 rotary
Date: Fri, 2 May 2025 17:09:58 +0300 [thread overview]
Message-ID: <aBTSNsCupbpAscwA@smile.fi.intel.com> (raw)
In-Reply-To: <D9LQ7NV1LJM9.F2GF0YEEDFEY@bootlin.com>
On Fri, May 02, 2025 at 03:58:04PM +0200, Mathieu Dubois-Briand wrote:
> On Fri May 2, 2025 at 12:52 PM CEST, Andy Shevchenko wrote:
> > On Mon, Apr 28, 2025 at 01:57:28PM +0200, Mathieu Dubois-Briand wrote:
...
> >> + pos = max(0, (int)pos + steps);
> >
> > Please, no castings for min()/max()/clamp(). It diminishes the use of those
> > macros.
>
> Sorry, I'm not sure to get the point. Should I use MIN_T() instead?
Are the second argument is compile-time constant? I don't think so. Hence no
use for MIN*()/MAX*(). First of all, try to answer to the Q: Why is the explicit
casting being used? The second Q: How can it be easily fixed without using _t()
variants of the macros?
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2025-05-02 14:10 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-28 11:57 [PATCH v7 00/11] Add support for MAX7360 Mathieu Dubois-Briand
2025-04-28 11:57 ` [PATCH v7 01/11] dt-bindings: mfd: gpio: Add MAX7360 Mathieu Dubois-Briand
2025-04-28 11:57 ` [PATCH v7 02/11] mfd: Add max7360 support mathieu.dubois-briand
2025-05-01 12:59 ` Lee Jones
2025-05-02 7:35 ` Mathieu Dubois-Briand
2025-05-02 8:26 ` Lee Jones
2025-05-02 9:13 ` Andy Shevchenko
2025-05-02 10:10 ` Andy Shevchenko
2025-04-28 11:57 ` [PATCH v7 03/11] pinctrl: Add MAX7360 pinctrl driver Mathieu Dubois-Briand
2025-05-02 10:15 ` Andy Shevchenko
2025-05-02 12:07 ` Mathieu Dubois-Briand
2025-04-28 11:57 ` [PATCH v7 04/11] pwm: max7360: Add MAX7360 PWM support mathieu.dubois-briand
2025-05-02 10:19 ` Andy Shevchenko
2025-05-02 12:13 ` Mathieu Dubois-Briand
2025-04-28 11:57 ` [PATCH v7 05/11] regmap: irq: Add support for chips without separate IRQ status Mathieu Dubois-Briand
2025-04-28 11:57 ` [PATCH v7 06/11] gpio: regmap: Allow to allocate regmap-irq device Mathieu Dubois-Briand
2025-05-02 10:20 ` Andy Shevchenko
2025-04-28 11:57 ` [PATCH v7 07/11] gpio: regmap: Allow to provide init_valid_mask callback Mathieu Dubois-Briand
2025-04-28 11:57 ` [PATCH v7 08/11] gpio: max7360: Add MAX7360 gpio support Mathieu Dubois-Briand
2025-05-02 10:39 ` Andy Shevchenko
2025-05-02 12:31 ` Mathieu Dubois-Briand
2025-05-02 13:03 ` Andy Shevchenko
2025-05-07 7:07 ` kernel test robot
2025-04-28 11:57 ` [PATCH v7 09/11] input: keyboard: Add support for MAX7360 keypad Mathieu Dubois-Briand
2025-05-02 10:46 ` Andy Shevchenko
2025-05-02 13:15 ` Mathieu Dubois-Briand
2025-05-02 13:32 ` Andy Shevchenko
2025-05-06 5:11 ` Dmitry Torokhov
2025-05-06 5:14 ` Dmitry Torokhov
2025-05-06 12:41 ` Mathieu Dubois-Briand
2025-04-28 11:57 ` [PATCH v7 10/11] input: misc: Add support for MAX7360 rotary Mathieu Dubois-Briand
2025-05-02 10:52 ` Andy Shevchenko
2025-05-02 13:58 ` Mathieu Dubois-Briand
2025-05-02 14:09 ` Andy Shevchenko [this message]
2025-05-05 11:52 ` Mathieu Dubois-Briand
2025-04-28 11:57 ` [PATCH v7 11/11] MAINTAINERS: Add entry on MAX7360 driver Mathieu Dubois-Briand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aBTSNsCupbpAscwA@smile.fi.intel.com \
--to=andriy.shevchenko@intel.com \
--cc=brgl@bgdev.pl \
--cc=broonie@kernel.org \
--cc=conor+dt@kernel.org \
--cc=dakr@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=gregory.clement@bootlin.com \
--cc=kamel.bouhara@bootlin.com \
--cc=krzk+dt@kernel.org \
--cc=lee@kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=mathieu.dubois-briand@bootlin.com \
--cc=mwalle@kernel.org \
--cc=rafael@kernel.org \
--cc=robh@kernel.org \
--cc=thomas.petazzoni@bootlin.com \
--cc=ukleinek@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox