From: Ingo Molnar <mingo@kernel.org>
To: linux-kernel@vger.kernel.org
Cc: linux-tip-commits@vger.kernel.org,
"Borislav Petkov (AMD)" <bp@alien8.de>,
stable@kernel.org, x86@kernel.org
Subject: Re: [tip: x86/urgent] x86/microcode: Consolidate the loader enablement checking
Date: Sun, 4 May 2025 08:14:23 +0200 [thread overview]
Message-ID: <aBcFv6BzmRNWqLY8@gmail.com> (raw)
In-Reply-To: <174628529460.22196.11450380316905137027.tip-bot2@tip-bot2>
* tip-bot2 for Borislav Petkov (AMD) <tip-bot2@linutronix.de> wrote:
> The following commit has been merged into the x86/urgent branch of tip:
>
> Commit-ID: eb72bdfbd0a757f30ebe4f9ec161cb246d19e5ed
> Gitweb: https://git.kernel.org/tip/eb72bdfbd0a757f30ebe4f9ec161cb246d19e5ed
> Author: Borislav Petkov (AMD) <bp@alien8.de>
> AuthorDate: Mon, 14 Apr 2025 11:59:33 +02:00
> Committer: Borislav Petkov (AMD) <bp@alien8.de>
> CommitterDate: Sat, 03 May 2025 16:40:56 +02:00
>
> x86/microcode: Consolidate the loader enablement checking
>
> Consolidate the whole logic which determines whether the microcode loader
> should be enabled or not into a single function and call it everywhere.
>
> Well, almost everywhere - not in mk_early_pgtbl_32() because there the kernel
> is running without paging enabled and checking dis_ucode_ldr et al would
> require physical addresses and uglification of the code.
>
> But since this is 32-bit, the easier thing to do is to simply map the initrd
> unconditionally especially since that mapping is getting removed later anyway
> by zap_early_initrd_mapping() and avoid the uglification.
>
> Fixes: 4c585af7180c1 ("x86/boot/32: Temporarily map initrd for microcode loading")
> Signed-off-by: Borislav Petkov (AMD) <bp@alien8.de>
> Cc: <stable@kernel.org>
> Link: https://lore.kernel.org/r/CANpbe9Wm3z8fy9HbgS8cuhoj0TREYEEkBipDuhgkWFvqX0UoVQ@mail.gmail.com
So the title claims this 'consolidates' microcode loader enablement,
which is basically a code refactoring, but then there's a Fixes tag -
what exactly does it fix? There's no explanation in the changelog that
I can see that justifies that tag and why it's in x86/urgent.
Thanks,
Ingo
next prev parent reply other threads:[~2025-05-04 6:14 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-19 6:29 [PATCH] x86/microcode: Fix crashes on early 486 CPUs due to usage of 'cpuid' Oerg866
2024-10-19 9:49 ` Borislav Petkov
2024-10-19 14:06 ` Oerg866
2025-04-05 2:03 ` Kevin Koster
2025-04-05 9:32 ` Borislav Petkov
2025-04-05 20:33 ` H. Peter Anvin
2025-04-05 20:50 ` Borislav Petkov
2025-04-05 21:03 ` Borislav Petkov
2025-04-06 6:40 ` Kevin Koster
2025-04-06 7:46 ` Kevin Koster
2025-04-06 19:02 ` Borislav Petkov
2025-04-06 23:58 ` Kevin Koster
2025-04-07 10:29 ` Borislav Petkov
2025-04-07 14:21 ` Kevin Koster
2025-04-07 13:55 ` Borislav Petkov
2025-04-07 14:28 ` Oerg866
2025-04-08 10:37 ` Maciej W. Rozycki
2025-04-08 17:22 ` [PATCH] x86/microcode: Consolidate the loader enablement Borislav Petkov
2025-04-09 7:51 ` Kevin Koster
2025-04-10 11:53 ` Thomas Gleixner
2025-04-11 11:07 ` Borislav Petkov
2025-04-14 9:59 ` [PATCH -v2] x86/microcode: Consolidate the loader enablement checking Borislav Petkov
2025-04-14 10:48 ` Ingo Molnar
2025-04-14 11:26 ` Borislav Petkov
2025-05-03 10:51 ` David Laight
2025-04-30 19:16 ` Thomas Gleixner
2025-05-02 16:22 ` Borislav Petkov
2025-05-02 19:15 ` Thomas Gleixner
2025-04-07 14:38 ` [PATCH] x86/microcode: Fix crashes on early 486 CPUs due to usage of 'cpuid' H. Peter Anvin
2025-04-07 23:20 ` Kevin Koster
2025-04-07 18:10 ` David Laight
2025-04-07 14:36 ` H. Peter Anvin
2025-04-08 10:16 ` Maciej W. Rozycki
2025-04-08 10:31 ` Borislav Petkov
2025-04-08 12:29 ` Maciej W. Rozycki
2025-04-08 17:28 ` Borislav Petkov
2025-04-06 16:49 ` H. Peter Anvin
2025-05-03 15:14 ` [tip: x86/urgent] x86/microcode: Consolidate the loader enablement checking tip-bot2 for Borislav Petkov (AMD)
2025-05-04 6:14 ` Ingo Molnar [this message]
2025-05-05 5:15 ` [PATCH] x86/microcode: Add microcode_loader_disabled() storage class for the !CONFIG_MICROCODE case Ingo Molnar
2025-05-05 5:32 ` [tip: x86/microcode] " tip-bot2 for Ingo Molnar
2025-05-05 7:27 ` tip-bot2 for Ingo Molnar
2025-05-05 7:47 ` [PATCH] " Borislav Petkov
2025-05-06 10:57 ` Ingo Molnar
2025-05-06 12:19 ` Borislav Petkov
2025-05-06 10:44 ` [tip: x86/urgent] x86/microcode: Consolidate the loader enablement checking tip-bot2 for Borislav Petkov (AMD)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aBcFv6BzmRNWqLY8@gmail.com \
--to=mingo@kernel.org \
--cc=bp@alien8.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=stable@kernel.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox