From: Corentin Labbe <clabbe.montjoie@gmail.com>
To: ldewangan@nvidia.com, broonie@kernel.org,
thierry.reding@gmail.com, jonathanh@nvidia.com,
linux-spi@vger.kernel.org
Cc: linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [regression] jetson-tk1: spi do not probe anymore
Date: Sun, 4 May 2025 13:23:29 +0200 [thread overview]
Message-ID: <aBdOMUhuUqbZm9w1@Red> (raw)
Hello
On my jetson-tk1, SPI do not probe anymore:
[ 1.330681] spi spi1.0: Invalid delay unit 2, should be SPI_DELAY_UNIT_SCK
[ 1.335185] spi-tegra114 7000da00.spi: can't setup spi1.0, status -22
[ 1.341643] spi_master spi1: spi_device register error /spi@7000da00/flash@0
[ 1.348637] spi_master spi1: Failed to create SPI device for /spi@7000da00/flash@0
I tested 6.14.7
The SPI probed perfectly in 4.17.14
I tried to debug a bit, and the driver requires units to be SPI_DELAY_UNIT_SCK, but it seems there is no way to set it.
Removing the "return -EINVAL" in tegra_spi_set_hw_cs_timing() lead to a successfull probe and the flash device appear.
But I agree, it is not a correct fix:)
Since only the test made it fail, I think the driver is bad since commit 810593668468 ("spi: tegra114: change format for `spi_set_cs_timing()` function")
Regards
next reply other threads:[~2025-05-04 11:23 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-04 11:23 Corentin Labbe [this message]
2025-05-04 22:37 ` [regression] jetson-tk1: spi do not probe anymore Mark Brown
2025-05-05 2:10 ` Aaron Kling
2025-05-05 8:54 ` Corentin Labbe
2025-05-05 10:28 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aBdOMUhuUqbZm9w1@Red \
--to=clabbe.montjoie@gmail.com \
--cc=broonie@kernel.org \
--cc=jonathanh@nvidia.com \
--cc=ldewangan@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox