The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: Leonardo Bras <leobras@redhat.com>
To: Vlastimil Babka <vbabka@suse.cz>
Cc: Leonardo Bras <leobras@redhat.com>,
	Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
	Alexei Starovoitov <ast@kernel.org>,
	"Peter Zijlstra (Intel)" <peterz@infradead.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	linux-kernel@vger.kernel.org
Subject: Re: [RFC PATCH 1/1] local_lock: Minor improvements of local_trylock*() documentation
Date: Mon,  5 May 2025 14:10:33 -0300	[thread overview]
Message-ID: <aBjxCZEnqWuKJw3I@LeoBras> (raw)
In-Reply-To: <1a679bb9-b701-47cf-83a5-b0f5cc4a5eaf@suse.cz>

On Mon, May 05, 2025 at 10:01:32AM +0200, Vlastimil Babka wrote:
> On 4/30/25 16:59, Sebastian Andrzej Siewior wrote:
> > On 2025-04-30 04:36:10 [-0300], Leonardo Bras wrote:
> >> Fix local_trylock_init() documentation, as it was mentioning the non-try
> >> helper instead, and use the opportunity to make clear the try_lock*() needs
> >> to receive a try-enabled variable as parameter.
> > 
> > Maybe replaced "try-enabled lock" with "local_trylock_t". "Try enabled
> > lock" as mentioned in the documentation or "try-enabled variable" as here
> > in the description does not really fit.
> 
> I agree, it's more clear that way.
> 
> Thanks,
> Vlastimil
> 
> >> Signed-off-by: Leonardo Bras <leobras@redhat.com>
> > 
> > Sebastian
> 


Hi Sebastian, Vlastimil,

Thanks for the feedback!
I implemented the suggested changes and just sent a v1 for this patch, 
which can be seen in:
https://lore.kernel.org/all/20250505170244.253170-1-leobras@redhat.com/T/#u

Thanks!
Leo


      reply	other threads:[~2025-05-05 17:10 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-04-30  7:36 [RFC PATCH 1/1] local_lock: Minor improvements of local_trylock*() documentation Leonardo Bras
2025-04-30 14:59 ` Sebastian Andrzej Siewior
2025-05-05  8:01   ` Vlastimil Babka
2025-05-05 17:10     ` Leonardo Bras [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aBjxCZEnqWuKJw3I@LeoBras \
    --to=leobras@redhat.com \
    --cc=ast@kernel.org \
    --cc=bigeasy@linutronix.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=peterz@infradead.org \
    --cc=tglx@linutronix.de \
    --cc=vbabka@suse.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox