From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx.treblig.org (mx.treblig.org [46.235.229.95]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C9ADD27701 for ; Wed, 7 May 2025 00:32:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=46.235.229.95 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746577940; cv=none; b=B2fauahwN7CByeEr3QBxdYxRgxVFTV7Vh/TM7787C4VPymKHF8y05FRJ/Y+tA8Xt9fEuozqGUqsbh/x/y2NIxNS5o+9FXO+v47XdcTgxxj+spFz1Dd4LQsYzxDEGFL1Et1kwxhs8DMN62/VT0I/ExVaCTxL27wzrMfj+GMl/vVw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746577940; c=relaxed/simple; bh=VULOp0LIMldb7GzmVd7VIdKyOn1UThY8CZyqpn55T+4=; h=Date:From:To:Cc:Subject:Message-ID:MIME-Version:Content-Type: Content-Disposition; b=Y0RYQ0sX9oFVwHFjyNMKdmuJU5YQbGsOFAqBOPpL1fZH777GDglW9cTkeUr353pel9msfGKF1Czs1Xlk8JfYFd3nwJ+BWzlZHXTJpIWWhUX3HVCoIPrfuayuPCUeoup68C0cAl3MADQwQmPB7jsbhZjCe7taLjw8wN7AiXjleo8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=treblig.org; spf=pass smtp.mailfrom=treblig.org; dkim=pass (2048-bit key) header.d=treblig.org header.i=@treblig.org header.b=Ez1Arzbw; arc=none smtp.client-ip=46.235.229.95 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=treblig.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=treblig.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=treblig.org header.i=@treblig.org header.b="Ez1Arzbw" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=treblig.org ; s=bytemarkmx; h=Content-Type:MIME-Version:Message-ID:Subject:From:Date:From :Subject; bh=zZKq2VYLVrTR55LFDRvI18F3cQXBDBw2Zts2GwPpQLo=; b=Ez1ArzbwxwNsZkGE nE8fA0pstdG60mn+8VJXztq9joAJPqc63XHZQWfOjMdghK/bAMqOWX+Qx3twvJSzshE1noVKjK0+0 l+kPmjkwr4tv6bvG6PuiuT9DA/2oNX1qexbqQuMDusYPUcH35GmfzyZSh6nt+A+Uz0wrHD7e35UYd NCtZjYlN15M066FbeqSr+lg0E1ZS6iz0Xe7WYv6fAXyIpTkRLDVXCwD2WQVaPs6nkaEk0wCGoFbmZ MjaqTagqx6Ci1p2IhyxCeDQ0lrQs9SFEZzMr+unQL0Iyq441uOTO2wJHgW9yFolNMMIbWJbdr+HBw AtnMvf2JhXAsRADzCg==; Received: from dg by mx.treblig.org with local (Exim 4.96) (envelope-from ) id 1uCShm-0021Pz-2M; Wed, 07 May 2025 00:32:10 +0000 Date: Wed, 7 May 2025 00:32:10 +0000 From: "Dr. David Alan Gilbert" To: alexander.deucher@amd.com, kenneth.feng@amd.com, christian.koenig@amd.com Cc: amd-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: questions about smu_mode2_reset_is_support and smu_v13_0_init_display_count Message-ID: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline X-Chocolate: 70 percent or better cocoa solids preferably X-Operating-System: Linux/6.1.0-34-amd64 (x86_64) X-Uptime: 00:27:05 up 9 days, 8:40, 1 user, load average: 0.03, 0.04, 0.01 User-Agent: Mutt/2.2.12 (2023-09-09) Hi, I noticed two functions that are unused but I wasn't sure what to do with them: smu_v13_0_init_display_count() isn't called/wired up, where as the v11 version is wired up: drivers/gpu/drm/amd/pm/swsmu/smu11/navi10_ppt.c 3574: .init_display_count = smu_v11_0_init_display_count, so is v13 really unused or should it be wired up in a similar way? secondly, smu_mode2_reset_is_support() is uncalled, but it's the only caller through the mode2_reset_is_support() function pointer; so if smu_mode2_reset_is_support() was deleted, does it then make sense to clean up all of sienna_cichlid_is_mode2_reset_supported, aldebaran_is_mode2_reset_supported, smu_v13_0_6_is_mode2_reset_supported which that function pointer is sett to. Thanks in advance, Dave -- -----Open up your eyes, open up your mind, open up your code ------- / Dr. David Alan Gilbert | Running GNU/Linux | Happy \ \ dave @ treblig.org | | In Hex / \ _________________________|_____ http://www.treblig.org |_______/