From: Frederic Weisbecker <frederic@kernel.org>
To: Gabriele Monaco <gmonaco@redhat.com>
Cc: linux-kernel@vger.kernel.org,
Thomas Gleixner <tglx@linutronix.de>,
Waiman Long <longman@redhat.com>
Subject: Re: [PATCH v4 2/5] timers: Add the available mask in timer migration
Date: Wed, 7 May 2025 16:27:40 +0200 [thread overview]
Message-ID: <aBtt3C4dFIxNgO0q@localhost.localdomain> (raw)
In-Reply-To: <dfb2721b2619130a3b3ed45c3e6d18916faf5ccb.camel@redhat.com>
Le Wed, May 07, 2025 at 03:54:32PM +0200, Gabriele Monaco a écrit :
>
>
> On Wed, 2025-05-07 at 15:40 +0200, Frederic Weisbecker wrote:
> > Le Wed, May 07, 2025 at 02:46:39PM +0200, Gabriele Monaco a écrit :
> > >
> > > I'm not so sure about this one though.
> > > As far as I understand [1], is preventing the user from setting
> > > different CPUs while doing isolcpus=nohz, and nohz_full= (which is
> > > now
> > > equivalent). But I seem to be able to do isolcpus=0-3 and
> > > nohz_full=4-7
> > > without any problem and I believe I'd hit the issue you're
> > > mentioning.
> >
> > Duh!
> >
> > > (The same would work if I swap the masks as 0 cannot be nohz_full).
> >
> > Unfortunately 0 can be nohz_full...
>
> Well, I haven't found what enforces it, but I wasn't able to set 0 as
> nohz_full, no matter what I tried on x86 and arm64. Not sure if 0 was
> just by chance in this case (I'm guessing it has something to do with
> tick_do_timer_cpu, I'm not quite familiar with this code).
Ah looks like you need CONFIG_PM_SLEEP_SMP_NONZERO_CPU. IIUC it's only
powerpc.
You can try to deactivate CONFIG_SUSPEND and CONFIG_HIBERNATE_CALLBACKS
otherwise.
Thanks.
--
Frederic Weisbecker
SUSE Labs
next prev parent reply other threads:[~2025-05-07 14:27 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-06 9:15 [PATCH v4 0/5] timers: Exclude isolated cpus from timer migation Gabriele Monaco
2025-05-06 9:15 ` [PATCH v4 1/5] timers: Rename tmigr 'online' bit to 'available' Gabriele Monaco
2025-05-06 9:15 ` [PATCH v4 2/5] timers: Add the available mask in timer migration Gabriele Monaco
2025-05-06 16:07 ` Frederic Weisbecker
2025-05-07 7:57 ` Gabriele Monaco
2025-05-07 12:25 ` Frederic Weisbecker
2025-05-07 12:46 ` Gabriele Monaco
2025-05-07 13:40 ` Frederic Weisbecker
2025-05-07 13:54 ` Gabriele Monaco
2025-05-07 14:27 ` Frederic Weisbecker [this message]
2025-05-06 9:15 ` [PATCH v4 3/5] cgroup/cpuset: Rename update_unbound_workqueue_cpumask to update_exclusion_cpumasks Gabriele Monaco
2025-05-06 9:15 ` [PATCH v4 4/5] timers: Add timer_base_remote_is_idle to query from remote cpus Gabriele Monaco
2025-05-06 9:15 ` [PATCH v4 5/5] timers: Exclude isolated cpus from timer migation Gabriele Monaco
2025-05-06 16:00 ` Frederic Weisbecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aBtt3C4dFIxNgO0q@localhost.localdomain \
--to=frederic@kernel.org \
--cc=gmonaco@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=longman@redhat.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox