From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f45.google.com (mail-wm1-f45.google.com [209.85.128.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 15652218EA8 for ; Thu, 8 May 2025 06:40:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.45 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746686433; cv=none; b=eqfv+UgjlYAN3MzkeFFlzOzPHPSqwvLSZbjIC4BlkXsU78qS3ajJdlH1rSFhe00R899XhiZoS3NC0vKjVFJL9DMu8q6ZOJQRN9odXiMwMizZp1CLkacl5dqbSP9z7UIWtxLjrnkWVOYP5J/Bpkng9zr3jFKCs2WThZseJOxY0qQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746686433; c=relaxed/simple; bh=mo7aBOYxy2laS+VfZHPupXplp+OJ0XZ0QwmwUj+Cx7E=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=odTm66gk4Pw5ThpWiS3A48j0ZRjFCu9A94JLgDHSsLSsjWvix0ICltrrlqlWPUV9cJ8RWOb73z4B7bkGXJkU1WXKqJaVVoKxVHYsvrCe1DQV7PShPJLdjrXlM/G4pXMQJc0ZXh+X/HZtJt3ppIIMQ92azkQAfsLThAWzXmPJR5M= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=CkVsDYMz; arc=none smtp.client-ip=209.85.128.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="CkVsDYMz" Received: by mail-wm1-f45.google.com with SMTP id 5b1f17b1804b1-441ab63a415so6269455e9.3 for ; Wed, 07 May 2025 23:40:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1746686429; x=1747291229; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=m0BYhiXUdA6i9dCcFIqo30mmGVKS8d1Kjub/7fShZA0=; b=CkVsDYMzDpzRHRO6FcVVzzHLgRGY4XxjKvk3TqtyBCrBQQMfFO0SleHFkpRLJZPB89 terLxyDUCkNb/9OW1fmRTLcNTGnDwWS3OB/mCPUR28HD8+j8WA3IeQQEyItIgOK/gnUR 88VcAsrNKud4mY4WMJ87NrUHoiBzwFP8LGA7qag3DYb+QG4dAQGjwIgH22k445UE2fDv tsNpQhiTladg92zjGW2oS90vcZ5JzZG2nfHeWwj15lJgXJjks1lTSPL7j+EnmNFIAVV/ 1RXk5sRaPtimqAnJjb/VnHsH5PQnsJuAS731kwCsv9xO8SYMHqfKvQh/TeX0LOa/RyNX 7Ihg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1746686429; x=1747291229; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=m0BYhiXUdA6i9dCcFIqo30mmGVKS8d1Kjub/7fShZA0=; b=oc8jtWwFqyFq1UaHi4TUmXMDWWJDPwkE6sIfBSQ7to6hcMKAvd3J31ik1UYZLTCqh5 KXHeZYZv2kBCup3xD6LJYmp74dDlDtiLA9I94LM7vfpcEiFS2Jnq/G33FfqosEPn80sH kGLRdaNxQQ80jih/dXBX/A7d6MubpEb1yvkaF4OCqYxF6ah6egKdJVSNUiuD2MVmSWlm T00MHmaborm3xIs7J7sVA0uqzgiGCNEK9c2mIsV+HtjrVvdxgrioYQBy0ceYU50bcT3f RBLy3P96qrdr9Qe3bM67FtsSbcANGy4HBV9Psn4MliImCY0R7+PNI9o1pyyvN/2xcAKr QkRg== X-Forwarded-Encrypted: i=1; AJvYcCW4K3rxB9IwzQ+gfaktjmATFG/cN1J4Xtv890G9w26JenfAs/h/8umo4ktRCovxhGS7TEv/XUu+88GRmpA=@vger.kernel.org X-Gm-Message-State: AOJu0YzbMFvHA2eTQkDomSmxfrl+Z0VjUy02wKz6wiAUPv+SpORrhauz /MCykxnSid5n0GokZ/Mgj0rDGK4BhoSVzNiRGCAfDCRigjXF/ww5eGvQ96MbfT8= X-Gm-Gg: ASbGncv39Yzzg1+rrqSRCfjNeCzjdSBxs1TVyRckZkaz3ZlrW/3HgoEnH/dI66JLjkt XYIEksTsOUVTKXdFZ7XNLnn+zTxS+gG4ChgjPLu+//D5dSr6GC0RBLUAuk4jTw+q1UsnxUV2OeI XXsD+pCKhT+UiMcwRJV0eCsA0ae5Tt+tu95pTph5/RB3PkoWV3dguYhS3CRncy0ptGpxCeJBN4a CrrTCnMj/vfsJUeRh8DCOetNLbpuA7Ii9GTBDQiqE5AhloVQ64Us1kYjxEBJOjtfUQgMMJ8aRe+ l4zGv2l2znQ2CfP3i2sMZ6M7sDklyCpVfB/lSIYC822PBdgWPF5rEiL/ X-Google-Smtp-Source: AGHT+IFZRIfE5PxRRbMe4B54cwayzKdn3VEZhgxzfmBDRkxcWCbiRLfEqYjfrSNjGm+C2f+T0IBaxg== X-Received: by 2002:a05:600c:628d:b0:43d:fa:1f9a with SMTP id 5b1f17b1804b1-441d44e3359mr67512805e9.30.1746686429396; Wed, 07 May 2025 23:40:29 -0700 (PDT) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with UTF8SMTPSA id 5b1f17b1804b1-442cd35f40asm25158595e9.27.2025.05.07.23.40.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 07 May 2025 23:40:28 -0700 (PDT) Date: Thu, 8 May 2025 09:40:26 +0300 From: Dan Carpenter To: Bjorn Andersson , Naresh Kamboju Cc: Mathieu Poirier , linux-arm-msm@vger.kernel.org, linux-remoteproc@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org, Greg Kroah-Hartman , stable@vger.kernel.org, patches@lists.linux.dev, torvalds@linux-foundation.org, akpm@linux-foundation.org, linux@roeck-us.net, shuah@kernel.org, patches@kernelci.org, lkft-triage@lists.linaro.org, pavel@denx.de, jonathanh@nvidia.com, f.fainelli@gmail.com, sudipm.mukherjee@gmail.com, srw@sladewatkins.net, rwarsow@gmx.de, conor@kernel.org, hargar@microsoft.com, broonie@kernel.org, Arnd Bergmann , Liam Girdwood , Frieder Schrempf , Marek Vasut , Anders Roxell Subject: Re: [PATCH] rpmsg: qcom_smd: Fix uninitialized return variable in __qcom_smd_send() Message-ID: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Hi Greg, I'm sorry I forgot to add the: Cc: stable@vger.kernel.org to this patch. Could we backport it to stable, please? regards, dan carpenter On Wed, Apr 23, 2025 at 08:22:05PM +0300, Dan Carpenter wrote: > The "ret" variable isn't initialized if we don't enter the loop. For > example, if "channel->state" is not SMD_CHANNEL_OPENED. > > Fixes: 33e3820dda88 ("rpmsg: smd: Use spinlock in tx path") > Signed-off-by: Dan Carpenter > --- > Naresh, could you test this patch and see if it fixes the boot > problems you saw? > > drivers/rpmsg/qcom_smd.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/rpmsg/qcom_smd.c b/drivers/rpmsg/qcom_smd.c > index 40d386809d6b..bb161def3175 100644 > --- a/drivers/rpmsg/qcom_smd.c > +++ b/drivers/rpmsg/qcom_smd.c > @@ -746,7 +746,7 @@ static int __qcom_smd_send(struct qcom_smd_channel *channel, const void *data, > __le32 hdr[5] = { cpu_to_le32(len), }; > int tlen = sizeof(hdr) + len; > unsigned long flags; > - int ret; > + int ret = 0; > > /* Word aligned channels only accept word size aligned data */ > if (channel->info_word && len % 4) > -- > 2.47.2